From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alexandre Courbot" <acourbot@nvidia.com>
Cc: "Timur Tabi" <ttabi@nvidia.com>, <driver-core@lists.linux.dev>,
<nova-gpu@lists.linux.dev>, <rust-for-linux@vger.kernel.org>,
"Eliot Courtney" <ecourtney@nvidia.com>,
"Zhi Wang" <zhiw@nvidia.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Russ Weight" <russ.weight@linux.dev>,
"Miguel Ojeda" <ojeda@kernel.org>, "Gary Guo" <gary@garyguo.net>
Subject: Re: [PATCH v3 1/7] rust: firmware: add request_into_buf()
Date: Mon, 06 Jul 2026 12:50:29 +0200 [thread overview]
Message-ID: <DJRFIANMW0AM.2LAQJ114NJQYH@kernel.org> (raw)
In-Reply-To: <DJR9ZKFB5WQQ.1CGI0N3GS1SFM@nvidia.com>
On Mon Jul 6, 2026 at 8:30 AM CEST, Alexandre Courbot wrote:
> Sashiko is correct to point out that this doesn't return the number of
> bytes actually written into `buf`. We might not use that information in
> nova-core, but this is a kernel-wide API.
Returning the size only doesn't carry a lot of value, please see [1].
> Returning a `Result<&[u8]>` would take care of this and cover the
> general use-case nicely.
I'm fine with either this or just Result, as we don't have a user for the
former.
[1] https://lore.kernel.org/nova-gpu/DJ6JV2QQY0QD.1ZK1PRRBN5BRP@kernel.org/
next prev parent reply other threads:[~2026-07-06 10:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 19:27 [PATCH v3 0/7] Transition Nova Core to TLV firmare images Timur Tabi
2026-07-02 19:27 ` [PATCH v3 1/7] rust: firmware: add request_into_buf() Timur Tabi
2026-07-03 2:51 ` Alvin Sun
2026-07-03 3:06 ` Timur Tabi
2026-07-03 13:51 ` Danilo Krummrich
2026-07-06 6:30 ` Alexandre Courbot
2026-07-06 10:50 ` Danilo Krummrich [this message]
2026-07-07 2:54 ` Timur Tabi
2026-07-07 5:10 ` Alexandre Courbot
2026-07-07 13:32 ` Danilo Krummrich
2026-07-02 19:27 ` [PATCH v3 2/7] gpu: nova-core: add TLV parser for firmware files Timur Tabi
2026-07-02 19:45 ` Timur Tabi
2026-07-06 6:31 ` Alexandre Courbot
2026-07-07 2:56 ` Timur Tabi
2026-07-07 5:13 ` Alexandre Courbot
2026-07-08 22:48 ` Timur Tabi
2026-07-09 3:43 ` Alexandre Courbot
2026-07-09 21:29 ` Timur Tabi
2026-07-06 6:31 ` Alexandre Courbot
2026-07-08 20:12 ` Timur Tabi
2026-07-09 1:55 ` Alexandre Courbot
2026-07-02 19:27 ` [PATCH v3 3/7] gpu: nova-core: transition booter_load to TLV images Timur Tabi
2026-07-06 6:31 ` Alexandre Courbot
2026-07-08 20:46 ` Timur Tabi
2026-07-09 3:51 ` Alexandre Courbot
2026-07-09 21:31 ` Timur Tabi
2026-07-02 19:27 ` [PATCH v3 4/7] gpu: nova-core: transition gsp " Timur Tabi
2026-07-02 19:27 ` [PATCH v3 5/7] gpu: nova-core: transition gen_bootloader " Timur Tabi
2026-07-06 6:31 ` Alexandre Courbot
2026-07-08 22:26 ` Timur Tabi
2026-07-09 2:24 ` Alexandre Courbot
2026-07-09 21:27 ` Timur Tabi
2026-07-09 21:49 ` John Hubbard
2026-07-09 22:13 ` Timur Tabi
2026-07-09 22:29 ` John Hubbard
2026-07-09 22:39 ` Timur Tabi
2026-07-09 22:41 ` John Hubbard
2026-07-09 22:44 ` Timur Tabi
2026-07-02 19:27 ` [PATCH v3 6/7] gpu: nova-core: transition fsp " Timur Tabi
2026-07-02 19:27 ` [PATCH v3 7/7] gpu: nova-core: update firmware module info for " Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJRFIANMW0AM.2LAQJ114NJQYH@kernel.org \
--to=dakr@kernel.org \
--cc=acourbot@nvidia.com \
--cc=driver-core@lists.linux.dev \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=mcgrof@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=russ.weight@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=ttabi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.