From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Timur Tabi" <ttabi@nvidia.com>
Cc: "John Hubbard" <jhubbard@nvidia.com>,
"gary@garyguo.net" <gary@garyguo.net>,
"Eliot Courtney" <ecourtney@nvidia.com>,
"nova-gpu@lists.linux.dev" <nova-gpu@lists.linux.dev>,
"Zhi Wang" <zhiw@nvidia.com>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"dakr@kernel.org" <dakr@kernel.org>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
"driver-core@lists.linux.dev" <driver-core@lists.linux.dev>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"russ.weight@linux.dev" <russ.weight@linux.dev>
Subject: Re: [PATCH v3 2/7] gpu: nova-core: add TLV parser for firmware files
Date: Tue, 07 Jul 2026 14:13:24 +0900 [thread overview]
Message-ID: <DJS2YR1BBMPC.2X5MMLHOM0LL7@nvidia.com> (raw)
In-Reply-To: <09d1fd87272e7c7dee79d1e0841f49de76ccd82b.camel@nvidia.com>
On Tue Jul 7, 2026 at 11:56 AM JST, Timur Tabi wrote:
> On Mon, 2026-07-06 at 15:31 +0900, Alexandre Courbot wrote:
>> > I forgot to update get_bytes() to return an error if the value is empty. That should
>> > address a lot
>> > of potential issues, including the ones that Sashiko raised.
>>
>> The spec says that
>>
>> Lengths of zero are allowed and indicate that the tag is a boolean.
>>
>> though, so we probably don't want to return an error in that case.
>
> Just don't call get_bytes() if you expect it to have no value. I can add a get_bool() or
> is_true() function to handle booleans, but there are no users.
>
> Returning error on length==0 simplifies a lot of code on the caller side.
Can you give an example of such a simplification? I'm fine if there is a
benefit to doing so, but would like to understand what we gain.
next prev parent reply other threads:[~2026-07-07 5:13 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 19:27 [PATCH v3 0/7] Transition Nova Core to TLV firmare images Timur Tabi
2026-07-02 19:27 ` [PATCH v3 1/7] rust: firmware: add request_into_buf() Timur Tabi
2026-07-03 2:51 ` Alvin Sun
2026-07-03 3:06 ` Timur Tabi
2026-07-03 13:51 ` Danilo Krummrich
2026-07-06 6:30 ` Alexandre Courbot
2026-07-06 10:50 ` Danilo Krummrich
2026-07-07 2:54 ` Timur Tabi
2026-07-07 5:10 ` Alexandre Courbot
2026-07-07 13:32 ` Danilo Krummrich
2026-07-02 19:27 ` [PATCH v3 2/7] gpu: nova-core: add TLV parser for firmware files Timur Tabi
2026-07-02 19:45 ` Timur Tabi
2026-07-06 6:31 ` Alexandre Courbot
2026-07-07 2:56 ` Timur Tabi
2026-07-07 5:13 ` Alexandre Courbot [this message]
2026-07-08 22:48 ` Timur Tabi
2026-07-09 3:43 ` Alexandre Courbot
2026-07-09 21:29 ` Timur Tabi
2026-07-06 6:31 ` Alexandre Courbot
2026-07-08 20:12 ` Timur Tabi
2026-07-09 1:55 ` Alexandre Courbot
2026-07-02 19:27 ` [PATCH v3 3/7] gpu: nova-core: transition booter_load to TLV images Timur Tabi
2026-07-06 6:31 ` Alexandre Courbot
2026-07-08 20:46 ` Timur Tabi
2026-07-09 3:51 ` Alexandre Courbot
2026-07-09 21:31 ` Timur Tabi
2026-07-02 19:27 ` [PATCH v3 4/7] gpu: nova-core: transition gsp " Timur Tabi
2026-07-02 19:27 ` [PATCH v3 5/7] gpu: nova-core: transition gen_bootloader " Timur Tabi
2026-07-06 6:31 ` Alexandre Courbot
2026-07-08 22:26 ` Timur Tabi
2026-07-09 2:24 ` Alexandre Courbot
2026-07-09 21:27 ` Timur Tabi
2026-07-09 21:49 ` John Hubbard
2026-07-09 22:13 ` Timur Tabi
2026-07-09 22:29 ` John Hubbard
2026-07-09 22:39 ` Timur Tabi
2026-07-09 22:41 ` John Hubbard
2026-07-09 22:44 ` Timur Tabi
2026-07-02 19:27 ` [PATCH v3 6/7] gpu: nova-core: transition fsp " Timur Tabi
2026-07-02 19:27 ` [PATCH v3 7/7] gpu: nova-core: update firmware module info for " Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJS2YR1BBMPC.2X5MMLHOM0LL7@nvidia.com \
--to=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=mcgrof@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=russ.weight@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=ttabi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.