All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Walle" <mwalle@kernel.org>
To: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Runyu Xiao" <runyu.xiao@seu.edu.cn>
Cc: <pratyush@kernel.org>, <miquel.raynal@bootlin.com>,
	<richard@nod.at>, <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<jianhao.xu@seu.edu.cn>, <stable@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: scope the exclusive RWW lock
Date: Wed, 12 Aug 2026 08:14:18 +0200	[thread overview]
Message-ID: <DKMQSZRM4QEZ.2EXQD5U58EVTI@kernel.org> (raw)
In-Reply-To: <6e208a8b-da11-4ba1-adfc-f1e80c891310@linaro.org>

On Tue Aug 11, 2026 at 12:05 PM CEST, Tudor Ambarus wrote:
>
>
> On 8/10/26 11:25 AM, Michael Walle wrote:
>> Tudor, do
>> you know why you've omitted the guard() in spi_nor_rww_start_exclusive()?
>
> because using guard changes the behavior of the code.

But that commit removed the mutex_unlock(), thus keeping the lock.
That wasn't the case before the commit. IMHO the Fixes: tag is
correct.

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: "Michael Walle" <mwalle@kernel.org>
To: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Runyu Xiao" <runyu.xiao@seu.edu.cn>
Cc: <pratyush@kernel.org>, <miquel.raynal@bootlin.com>,
	<richard@nod.at>, <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<jianhao.xu@seu.edu.cn>, <stable@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: scope the exclusive RWW lock
Date: Wed, 12 Aug 2026 08:14:18 +0200	[thread overview]
Message-ID: <DKMQSZRM4QEZ.2EXQD5U58EVTI@kernel.org> (raw)
In-Reply-To: <6e208a8b-da11-4ba1-adfc-f1e80c891310@linaro.org>

On Tue Aug 11, 2026 at 12:05 PM CEST, Tudor Ambarus wrote:
>
>
> On 8/10/26 11:25 AM, Michael Walle wrote:
>> Tudor, do
>> you know why you've omitted the guard() in spi_nor_rww_start_exclusive()?
>
> because using guard changes the behavior of the code.

But that commit removed the mutex_unlock(), thus keeping the lock.
That wasn't the case before the commit. IMHO the Fixes: tag is
correct.

-michael

  reply	other threads:[~2026-08-12  6:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-09  8:42 [PATCH] mtd: spi-nor: scope the exclusive RWW lock Runyu Xiao
2026-08-09  8:42 ` Runyu Xiao
2026-08-10  8:25 ` Michael Walle
2026-08-10  8:25   ` Michael Walle
2026-08-10 12:47   ` Miquel Raynal
2026-08-10 12:47     ` Miquel Raynal
2026-08-11  4:13   ` [PATCH v2] " Runyu Xiao
2026-08-11  4:13     ` Runyu Xiao
2026-08-11  7:51     ` Miquel Raynal
2026-08-11  7:51       ` Miquel Raynal
2026-08-11  8:31     ` [PATCH v3] mtd: spi-nor: use guard() in spi_nor_rww_start_exclusive Runyu Xiao
2026-08-11  8:31       ` Runyu Xiao
2026-08-11  8:41       ` Miquel Raynal
2026-08-11  8:41         ` Miquel Raynal
2026-08-11 10:11       ` Tudor Ambarus
2026-08-11 10:11         ` Tudor Ambarus
2026-08-11 10:42         ` Tudor Ambarus
2026-08-11 10:42           ` Tudor Ambarus
2026-08-11 14:36           ` Miquel Raynal
2026-08-11 14:36             ` Miquel Raynal
2026-08-11 15:38             ` Miquel Raynal
2026-08-11 15:38               ` Miquel Raynal
2026-08-11  8:50     ` [PATCH v2] mtd: spi-nor: scope the exclusive RWW lock Michael Walle
2026-08-11  8:50       ` Michael Walle
2026-08-11 10:05   ` [PATCH] " Tudor Ambarus
2026-08-11 10:05     ` Tudor Ambarus
2026-08-12  6:14     ` Michael Walle [this message]
2026-08-12  6:14       ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKMQSZRM4QEZ.2EXQD5U58EVTI@kernel.org \
    --to=mwalle@kernel.org \
    --cc=jianhao.xu@seu.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=runyu.xiao@seu.edu.cn \
    --cc=stable@vger.kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.