From: "Gary Guo" <gary@garyguo.net>
To: "John Hubbard" <jhubbard@nvidia.com>,
"Vladislav Zaharov" <vladazaharova2018@gmail.com>,
<dakr@kernel.org>
Cc: <acourbot@nvidia.com>, <aliceryhl@google.com>, <ttabi@nvidia.com>,
<gary@garyguo.net>, <nova-gpu@lists.linux.dev>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] gpu: nova-core: gsp: retain the GSP-RM log buffers after unbind
Date: Thu, 13 Aug 2026 20:58:42 +0100 [thread overview]
Message-ID: <DKO2YQVU889X.3BX9MWOBCQ4F2@garyguo.net> (raw)
In-Reply-To: <439f1fac-0745-45b1-a6e4-5c6fbcc32ee9@nvidia.com>
On Thu Aug 13, 2026 at 8:37 PM BST, John Hubbard wrote:
> On 8/12/26 10:50 PM, Vladislav Zaharov wrote:
>> On Thu Aug 13, 2026, Danilo Krummrich wrote:
>>> I'd *much* rather use a kernel parameter: keep_gsp_logs, instead of
>>> requiring a rebuild of the kernel.
>>
>> Agreed, and it makes the patch smaller: with a module parameter the cfg gating
>> disappears and the code is simply always built. I used a Kconfig because of the
>> "the only Kconfig needed is for retaining the GSP log buffers after driver
>> unbind" remark in the earlier thread, which I took literally instead of asking.
>>
>> That one needs a decision, though. The Rust module parameter abstraction has no
>> bool: rust/kernel/module_param.rs only instantiates param ops for i8..u64,
>
> Yes, this seems perfectly acceptable, given that we don't have bool support yet:
>
> keep_gsp_logs=[0|1]
>
>
> thanks,
We have bool support.
https://rust.docs.kernel.org/next/kernel/module_param/trait.ModuleParam.html#impl-ModuleParam-for-bool
Best,
Gary
prev parent reply other threads:[~2026-08-13 19:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 11:37 [PATCH 0/2] gpu: nova-core: retain the GSP-RM log buffers Vladislav Zaharov
2026-08-12 11:37 ` [PATCH 1/2] gpu: nova-core: gsp: retain the GSP-RM log buffers after unbind Vladislav Zaharov
2026-08-12 11:53 ` sashiko-bot
2026-08-12 12:06 ` Vladislav Zaharov
2026-08-12 14:00 ` Gary Guo
2026-08-12 14:38 ` Vladislav Zaharov
2026-08-12 22:41 ` John Hubbard
2026-08-12 23:15 ` Danilo Krummrich
2026-08-13 0:00 ` John Hubbard
2026-08-13 16:29 ` Timur Tabi
2026-08-13 19:30 ` John Hubbard
2026-08-13 20:00 ` Danilo Krummrich
2026-08-13 20:21 ` John Hubbard
2026-08-12 23:43 ` Danilo Krummrich
2026-08-12 11:37 ` [PATCH 2/2] Documentation: nova: remove completed GSP log buffer task Vladislav Zaharov
2026-08-12 15:54 ` [PATCH 0/2] gpu: nova-core: retain the GSP-RM log buffers Danilo Krummrich
2026-08-12 16:08 ` Vladislav Zaharov
2026-08-13 5:50 ` [PATCH 1/2] gpu: nova-core: gsp: retain the GSP-RM log buffers after unbind Vladislav Zaharov
2026-08-13 19:37 ` John Hubbard
2026-08-13 19:58 ` Gary Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKO2YQVU889X.3BX9MWOBCQ4F2@garyguo.net \
--to=gary@garyguo.net \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ttabi@nvidia.com \
--cc=vladazaharova2018@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.