Re: [PATCH v3 1/5] lib: sbi: select expected trap handler per hart

From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "Alvin Chang" <alvinga@andestech.com>
Cc: <opensbi@lists.infradead.org>, <troy.mitchell@linux.spacemit.com>,
	"Xianbin Zhu" <xianbin.zhu@linux.spacemit.com>,
	"Anup Patel" <anup@brainfault.org>, "Bo Gan" <ganboing@gmail.com>,
	"Samuel Holland" <samuel.holland@sifive.com>,
	"Heinrich Schuchardt" <heinrich.schuchardt@canonical.com>
Subject: Re: [PATCH v3 1/5] lib: sbi: select expected trap handler per hart
Date: Tue, 01 Sep 2026 13:45:05 +0800	[thread overview]
Message-ID: <DL3QPISZDL01.36F0N37XBPA54@linux.spacemit.com> (raw)
In-Reply-To: <20260831022156.2060561-1-alvinga@andestech.com>

[-- Attachment #1.1: Type: text/plain, Size: 800 bytes --]

On Mon, Aug 31, 2026 at 10:21 AM +0800, Alvin Chang wrote:
> Have you tried stack protector?
>
> I changed them to use extern symbol directly because they break stack
> protector.
> Please check my patchset sent last year:
> https://lore.kernel.org/all/20250703151957.2545958-1-alvinga@andestech.com/

I had not tested this version with stack protector enabled. I have now
built and booted it under QEMU with CONFIG_STACK_PROTECTOR_ALL. It boots,
but the generated code confirms that the accessor itself is instrumented
and introduces an out-of-line call in this low-level path.

I will replace it with a per-hart handler address stored in scratch and
loaded directly at each use, then test it on K3 with stack protector
enabled.

                                            - Troy

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 248 bytes --]

[-- Attachment #2: Type: text/plain, Size: 105 bytes --]

-- 
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi