From: "Danilo Krummrich" <dakr@kernel.org>
To: "Jim Cromie via B4 Relay" <devnull+jim.cromie.gmail.com@kernel.org>
Cc: jim.cromie@gmail.com,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Simona Vetter <simona@ffwll.ch>, Dave Airlie <airlied@redhat.com>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Daniel Campos Ramos <Capitain_Jack@yahoo.com>
Subject: Re: [PATCH v2 2/3] nouveau: Fix NULL pointer dereference in GET_ZCULL_INFO ioctl
Date: Fri, 09 Oct 2026 23:48:46 +0200 [thread overview]
Message-ID: <DM0N02GT1YII.Z30F7OBT9XKX@kernel.org> (raw)
In-Reply-To: <20261009-my-fixups-v2-2-839e2bbe514d@gmail.com>
On Fri Oct 9, 2026 at 7:44 PM CEST, Jim Cromie via B4 Relay wrote:
> From: Jim Cromie <jim.cromie@gmail.com>
>
> When graphics engine firmware fails to load or initialization aborts
> early, nvxx_gr(drm) returns NULL. Calling DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO
> causes nouveau_abi16_ioctl_get_zcull_info() to dereference gr at offset
> 0xf0 without checking for NULL, triggering a kernel page fault.
>
> Validate that gr is non-NULL before inspecting gr->has_zcull_info.
>
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Please add a Fixes: tag and CC stable.
WARNING: multiple messages have this Message-ID (diff)
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Jim Cromie via B4 Relay" <devnull+jim.cromie.gmail.com@kernel.org>
Cc: <jim.cromie@gmail.com>, "Lyude Paul" <lyude@redhat.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Dave Airlie" <airlied@redhat.com>,
<dri-devel@lists.freedesktop.org>,
<nouveau@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
"Daniel Campos Ramos" <Capitain_Jack@yahoo.com>
Subject: Re: [PATCH v2 2/3] nouveau: Fix NULL pointer dereference in GET_ZCULL_INFO ioctl
Date: Fri, 09 Oct 2026 23:48:46 +0200 [thread overview]
Message-ID: <DM0N02GT1YII.Z30F7OBT9XKX@kernel.org> (raw)
In-Reply-To: <20261009-my-fixups-v2-2-839e2bbe514d@gmail.com>
On Fri Oct 9, 2026 at 7:44 PM CEST, Jim Cromie via B4 Relay wrote:
> From: Jim Cromie <jim.cromie@gmail.com>
>
> When graphics engine firmware fails to load or initialization aborts
> early, nvxx_gr(drm) returns NULL. Calling DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO
> causes nouveau_abi16_ioctl_get_zcull_info() to dereference gr at offset
> 0xf0 without checking for NULL, triggering a kernel page fault.
>
> Validate that gr is non-NULL before inspecting gr->has_zcull_info.
>
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Please add a Fixes: tag and CC stable.
next prev parent reply other threads:[~2026-10-09 21:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 17:44 [PATCH v2 0/3] nouveau: fix 3 null-ptr derefs Jim Cromie via B4 Relay
2026-10-09 17:44 ` Jim Cromie
2026-10-09 17:44 ` [PATCH v2 1/3] nouveau: Fix NULL pointer dereferences in GETPARAM ioctl Jim Cromie via B4 Relay
2026-10-09 17:44 ` Jim Cromie
2026-10-09 21:24 ` lyude
2026-10-09 21:47 ` Danilo Krummrich
2026-10-09 21:47 ` Danilo Krummrich
2026-10-09 17:44 ` [PATCH v2 2/3] nouveau: Fix NULL pointer dereference in GET_ZCULL_INFO ioctl Jim Cromie via B4 Relay
2026-10-09 17:44 ` Jim Cromie
2026-10-09 21:25 ` lyude
2026-10-09 21:48 ` Danilo Krummrich [this message]
2026-10-09 21:48 ` Danilo Krummrich
2026-10-09 17:44 ` [PATCH v2 3/3] nouveau: Fix NULL dereference in nvkm_gsp_gcx_ready() Jim Cromie via B4 Relay
2026-10-09 17:44 ` Jim Cromie
2026-10-09 21:26 ` lyude
2026-10-09 21:53 ` Danilo Krummrich
2026-10-09 21:53 ` Danilo Krummrich
2026-10-09 22:01 ` lyude
2026-10-09 22:01 ` lyude
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM0N02GT1YII.Z30F7OBT9XKX@kernel.org \
--to=dakr@kernel.org \
--cc=Capitain_Jack@yahoo.com \
--cc=airlied@redhat.com \
--cc=devnull+jim.cromie.gmail.com@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.