From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: <bot+bpf-ci@kernel.org>, <bpf@vger.kernel.org>
Cc: <daniel@iogearbox.net>, <andrii@kernel.org>, <eddyz87@gmail.com>,
<memxor@gmail.com>, <ast@kernel.org>, <martin.lau@kernel.org>,
<yonghong.song@linux.dev>, <mason@kernel.org>,
<ihor.solodrai@linux.dev>
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Test tracing_multi link with BTF ids of the same address
Date: Sun, 11 Oct 2026 18:45:44 +0000 [thread overview]
Message-ID: <DM28D0SAMO0S.1VTBTQHV699H@gmail.com> (raw)
In-Reply-To: <d51031962737267f48d83c86738616656b3024c9c7bed42330c77b3c6936cae1@mail.kernel.org>
On Sun Oct 11, 2026 at 6:15 PM UTC, bot+bpf-ci wrote:
>> selftests/bpf: Test tracing_multi link with BTF ids of the same address
>
> TL;DR: Test nit only: the attach_same_addr subtest skips without printing a
> reason, so a SKIP is hard to interpret. A printf() before test__skip() could
> help, though the review says a bare skip may be acceptable.
...
> A subsystem pattern flags this skip as potentially concerning. The
> selftests guide says to report a test that skips silently with no
> message.
bpf-ci... seriously?
humans and bots MUST not report nits.
next prev parent reply other threads:[~2026-10-11 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 16:48 [PATCH bpf-next 0/2] bpf: Reject BTF ids with the same address in tracing_multi link Alexei Starovoitov
2026-10-11 16:48 ` [PATCH bpf-next 1/2] " Alexei Starovoitov
2026-10-11 16:48 ` [PATCH bpf-next 2/2] selftests/bpf: Test tracing_multi link with BTF ids of the same address Alexei Starovoitov
2026-10-11 18:15 ` bot+bpf-ci
2026-10-11 18:45 ` Alexei Starovoitov [this message]
2026-10-12 4:59 ` [PATCH bpf-next 0/2] bpf: Reject BTF ids with the same address in tracing_multi link Leon Hwang
2026-10-12 5:30 ` patchwork-bot+netdevbpf
2026-10-12 8:26 ` Leon Hwang
2026-10-12 8:45 ` Kumar Kartikeya Dwivedi
2026-10-12 8:09 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM28D0SAMO0S.1VTBTQHV699H@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=martin.lau@kernel.org \
--cc=mason@kernel.org \
--cc=memxor@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.