All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <olsajiri@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf@vger.kernel.org, daniel@iogearbox.net, andrii@kernel.org,
	eddyz87@gmail.com, memxor@gmail.com
Subject: Re: [PATCH bpf-next 0/2] bpf: Reject BTF ids with the same address in tracing_multi link
Date: Mon, 12 Oct 2026 10:09:48 +0200	[thread overview]
Message-ID: <asyVzPrdjWi0uYeI@krava> (raw)
In-Reply-To: <20261011164836.2233874-1-alexei.starovoitov@gmail.com>

On Sun, Oct 11, 2026 at 04:48:34PM +0000, Alexei Starovoitov wrote:
> From: Alexei Starovoitov <ast@kernel.org>
> 
> tracing_multi link accepts different BTF ids that resolve to the same
> address. The attach succeeds, the detach fails in ftrace and the kernel
> crashes in freed trampoline images.
> 'test_progs -t tracing_multi' hits it when the kernel is built with
> CONFIG_DEBUG_INFO_BTF_INLINE. Without it the ids of aliased functions do
> the same.
> 
> Patch 1 - the fix.
> Patch 2 - selftest.
> 
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>

nice, fwiw:

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka


> 
> Alexei Starovoitov (2):
>   bpf: Reject BTF ids with the same address in tracing_multi link
>   selftests/bpf: Test tracing_multi link with BTF ids of the same
>     address
> 
>  include/linux/ftrace.h                        |  1 +
>  kernel/bpf/trampoline.c                       |  8 ++
>  kernel/trace/trace.h                          |  3 -
>  .../selftests/bpf/prog_tests/tracing_multi.c  | 99 +++++++++++++++++++
>  4 files changed, 108 insertions(+), 3 deletions(-)
> 
> -- 
> 2.55.0
> 
> 

      parent reply	other threads:[~2026-10-12  8:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11 16:48 [PATCH bpf-next 0/2] bpf: Reject BTF ids with the same address in tracing_multi link Alexei Starovoitov
2026-10-11 16:48 ` [PATCH bpf-next 1/2] " Alexei Starovoitov
2026-10-11 16:48 ` [PATCH bpf-next 2/2] selftests/bpf: Test tracing_multi link with BTF ids of the same address Alexei Starovoitov
2026-10-11 18:15   ` bot+bpf-ci
2026-10-11 18:45     ` Alexei Starovoitov
2026-10-12  4:59 ` [PATCH bpf-next 0/2] bpf: Reject BTF ids with the same address in tracing_multi link Leon Hwang
2026-10-12  5:30 ` patchwork-bot+netdevbpf
2026-10-12  8:26   ` Leon Hwang
2026-10-12  8:45     ` Kumar Kartikeya Dwivedi
2026-10-12  8:09 ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asyVzPrdjWi0uYeI@krava \
    --to=olsajiri@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=memxor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.