From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Ihor Solodrai" <ihor.solodrai@linux.dev>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
"Quentin Monnet" <qmo@kernel.org>
Cc: <bpf@vger.kernel.org>, "Alan Maguire" <alan.maguire@oracle.com>,
"Cupertino Miranda" <cupertino.miranda@oracle.com>,
"David Faust" <david.faust@oracle.com>,
"Ian Rogers" <irogers@google.com>,
"Jose E . Marchesi" <jose.marchesi@oracle.com>,
"Vineet Gupta" <vineet.gupta@linux.dev>,
"Yonghong Song" <yonghong.song@linux.dev>
Subject: Re: [PATCH bpf-next v1 1/8] bpftool: Dump C from a detached BTF copy
Date: Fri, 16 Oct 2026 01:18:44 +0000 [thread overview]
Message-ID: <DM5V83GMXC13.B0KDKO805LCG@gmail.com> (raw)
In-Reply-To: <20261016000012.2232059-2-ihor.solodrai@linux.dev>
On Thu, Oct 15, 2026 at 05:00 PM Ihor Solodrai <ihor.solodrai@linux.dev> wrote:
> Modifying the parsed BTF fails for some valid input: libbpf refuses to
> modify BTF whose header carries unknown nonzero extension bytes, so
> such a dump would stop with -EOPNOTSUPP.
>
> Dump from a flat copy built with btf__add_type(), which only requires
> the destination to be modifiable.
can we do btf__new_empty_split(btf) and add decl attrs there
instead of copying all types ?
It fails on such BTF only because btf__add_str() does
btf__find_str(base) and that calls btf_ensure_modifiable(base).
The lookup shouldn't need it.
next prev parent reply other threads:[~2026-10-16 1:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 0:00 [PATCH bpf-next v1 0/8] bpftool: Per-record CO-RE attributes in the C dump Ihor Solodrai
2026-10-16 0:00 ` [PATCH bpf-next v1 1/8] bpftool: Dump C from a detached BTF copy Ihor Solodrai
2026-10-16 1:18 ` Alexei Starovoitov [this message]
2026-10-16 9:44 ` Alan Maguire
2026-10-16 9:25 ` Alan Maguire
2026-10-16 0:00 ` [PATCH bpf-next v1 2/8] selftests/bpf: Cover unknown BTF header-extension bytes in btf dump Ihor Solodrai
2026-10-16 0:00 ` [PATCH bpf-next v1 3/8] bpftool: Apply __bpf_core_pai per record on BTF dump Ihor Solodrai
2026-10-16 0:39 ` bot+bpf-ci
2026-10-16 1:17 ` Alexei Starovoitov
2026-10-16 0:00 ` [PATCH bpf-next v1 4/8] bpftool: Skip __bpf_core_pai on verifier-rewritten context types Ihor Solodrai
2026-10-16 0:00 ` [PATCH bpf-next v1 5/8] bpftool: Emit __bpf_core_pso " Ihor Solodrai
2026-10-16 1:27 ` Alexei Starovoitov
2026-10-16 5:49 ` Ihor Solodrai
2026-10-16 15:53 ` Alexei Starovoitov
2026-10-16 0:00 ` [PATCH bpf-next v1 6/8] selftests/bpf: Cover record attributes in bpftool BTF dumps Ihor Solodrai
2026-10-16 0:00 ` [PATCH bpf-next v1 7/8] selftests/bpf: Cover context and socket accesses through vmlinux.h Ihor Solodrai
2026-10-16 0:00 ` [PATCH bpf-next v1 8/8] bpftool: Document __bpf_core_pai and __bpf_core_pso Ihor Solodrai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5V83GMXC13.B0KDKO805LCG@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cupertino.miranda@oracle.com \
--cc=daniel@iogearbox.net \
--cc=david.faust@oracle.com \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=irogers@google.com \
--cc=jose.marchesi@oracle.com \
--cc=memxor@gmail.com \
--cc=qmo@kernel.org \
--cc=vineet.gupta@linux.dev \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.