All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yoann Congal" <yoann.congal@smile.fr>
To: "Jinwang Li" <jinwang.li@oss.qualcomm.com>,
	<openembedded-core@lists.openembedded.org>
Cc: <cheng.jiang@oss.qualcomm.com>, <quic_chezhou@quicinc.com>,
	<wei.deng@oss.qualcomm.com>, <shuai.zhang@oss.qualcomm.com>,
	<mengshi.wu@oss.qualcomm.com>, <xiuzhuo.shang@oss.qualcomm.com>
Subject: Re: [OE-core] [wrynose][PATCH 5/5] bluez5: Fix u128_to_string skipping data[4]
Date: Wed, 21 Oct 2026 12:31:31 +0200	[thread overview]
Message-ID: <DMAG42F4ZSS1.HA6ACTW0CXCL@smile.fr> (raw)
In-Reply-To: <6f8cb2bb-93bc-48d1-93b8-cf62b7e44322@oss.qualcomm.com>

On Wed Oct 21, 2026 at 11:27 AM CEST, Jinwang Li wrote:
>
>
> On 10/20/2026 3:58 PM, Yoann Congal wrote:
>> On Mon Oct 19, 2026 at 10:23 AM CEST, Jinwang Li via lists.openembedded.org wrote:
>>> data[3] was used twice, skipping data[4] in the output string.
>>>
>>> Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
>>> ---
>>>   meta/recipes-connectivity/bluez5/bluez5.inc   |  1 +
>>>   ...p-Fix-u128_to_string-skipping-data-4.patch | 33 +++++++++++++++++++
>>>   2 files changed, 34 insertions(+)
>>>   create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch
>>>
>>> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
>>> index db650acdd0..75d76cf96d 100644
>>> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
>>> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
>>> @@ -80,6 +80,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
>>>              file://0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch \
>>>              file://0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch \
>>>              file://0001-gobex-Fix-ABORT-response-being-discarded.patch \
>>> +           file://0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch \
>>>              "
>>>   S = "${UNPACKDIR}/bluez-${PV}"
>>>   
>>> diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch
>>> new file mode 100644
>>> index 0000000000..338bc228c1
>>> --- /dev/null
>>> +++ b/meta/recipes-connectivity/bluez5/bluez5/0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch
>>> @@ -0,0 +1,33 @@
>>> +From 198f4e0785644cea2b2154b383fc4ad354707947 Mon Sep 17 00:00:00 2001
>>> +From: Jinwang Li <jinwang.li@oss.qualcomm.com>
>>> +Date: Wed, 23 Sep 2026 11:29:57 +0800
>>> +Subject: [PATCH] obexd/pbap: Fix u128_to_string skipping data[4]
>>> +
>>> +u128_to_string uses data[3] twice causing data[4] to be skipped and
>>> +DatabaseIdentifier, PrimaryCounter and SecondaryCounter properties to
>>> +be printed with wrong values.
>>> +
>>> +Fixes: 5ee26d43c65c ("obexd/client: Add DatabaseIdentifier property")
>>> +Upstream-Status: Backport [https://github.com/bluez/bluez/commit/8b4a4176063831476bc9244d20f43b552e4b5554]
>>> +Assisted-by: opencode:claude-sonnet-5
>>> +Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
>> Hello,
>> 
>> Is that commit included in master and blacksail? If not, can you send
>> the needed upgrades/backports so I can merge this here?
>> 
>> Thanks!
> This commit is already merged into the OE-Core master and blacksail.

Yes, right. Somehow, my tools (and I) missed that.
(patch 4/5 as well)

Regards,
-- 
Yoann Congal
Smile ECS

      reply	other threads:[~2026-10-21 10:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19  8:23 [wrynose][PATCH 0/5] bluez5: fix AVDTP and OBEX issues Jinwang Li
2026-10-19  8:23 ` [wrynose][PATCH 1/5] bluez5: Fix error handling for AVDTP_OPEN cmd Jinwang Li
2026-10-20  7:55   ` [OE-core] " Yoann Congal
2026-10-21  9:28     ` Jinwang Li
2026-10-19  8:23 ` [wrynose][PATCH 2/5] bluez5: Fix GET_CONFIGURATION cmd Jinwang Li
2026-10-20  7:55   ` [OE-core] " Yoann Congal
2026-10-19  8:23 ` [wrynose][PATCH 3/5] bluez5: Return correct error when SEP is inuse Jinwang Li
2026-10-20  7:56   ` [OE-core] " Yoann Congal
2026-10-19  8:23 ` [wrynose][PATCH 4/5] bluez5: Fix ABORT response being discarded Jinwang Li
2026-10-20  7:57   ` [OE-core] " Yoann Congal
2026-10-21  9:26     ` Jinwang Li
2026-10-19  8:23 ` [wrynose][PATCH 5/5] bluez5: Fix u128_to_string skipping data[4] Jinwang Li
2026-10-20  7:58   ` [OE-core] " Yoann Congal
2026-10-21  9:27     ` Jinwang Li
2026-10-21 10:31       ` Yoann Congal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMAG42F4ZSS1.HA6ACTW0CXCL@smile.fr \
    --to=yoann.congal@smile.fr \
    --cc=cheng.jiang@oss.qualcomm.com \
    --cc=jinwang.li@oss.qualcomm.com \
    --cc=mengshi.wu@oss.qualcomm.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=quic_chezhou@quicinc.com \
    --cc=shuai.zhang@oss.qualcomm.com \
    --cc=wei.deng@oss.qualcomm.com \
    --cc=xiuzhuo.shang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.