Re: [PATCH v4 8/9] iio: light: veml6031x00: annotate the event enable helpers

From: "Javier Carrasco" <javier.carrasco.cruz@gmail.com>
To: "Rupesh Majhi" <zoone.rupert@gmail.com>,
	"Alex Lanzano" <lanzano.alex@gmail.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Benson Leung" <bleung@chromium.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Guenter Roeck" <groeck@chromium.org>,
	"Jagath Jog J" <jagathjog1996@gmail.com>,
	"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
	"Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	"Jinseob Kim" <kimjinseob88@gmail.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Matti Vaittinen" <mazziesaccount@gmail.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Remi Buisson" <remi.buisson@tdk.com>
Cc: <chrome-platform@lists.linux.dev>,
	<linux-amlogic@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-iio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, "Marco Elver" <elver@google.com>,
	"Bart Van Assche" <bvanassche@acm.org>
Subject: Re: [PATCH v4 8/9] iio: light: veml6031x00: annotate the event enable helpers
Date: Tue, 27 Oct 2026 11:52:34 -0500	[thread overview]
Message-ID: <DMFRZ3B3A6CH.P7SKUZSQR23T@gmail.com> (raw)
In-Reply-To: <20261027124954.110697-9-zoone.rupert@gmail.com>

On Tue Oct 27, 2026 at 7:49 AM EST, Rupesh Majhi wrote:
> veml6031x00_event_enable() and veml6031x00_event_disable() call
> veml6031x00_set_interrupt(), which needs irq_lock held. Their only
> caller holds it, so mark both __must_hold(&data->irq_lock).
>
> Signed-off-by: Rupesh Majhi <zoone.rupert@gmail.com>
> ---
> Cc: Marco Elver <elver@google.com>
> Cc: Bart Van Assche <bvanassche@acm.org>
>
>  drivers/iio/light/veml6031x00.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/light/veml6031x00.c b/drivers/iio/light/veml6031x00.c
> index f6308498e422..476ac3717f8e 100644
> --- a/drivers/iio/light/veml6031x00.c
> +++ b/drivers/iio/light/veml6031x00.c
> @@ -784,6 +784,7 @@ static int veml6031x00_read_event_config(struct iio_dev *iio,
>  }
>
>  static int veml6031x00_event_enable(struct veml6031x00_data *data)
> +	__must_hold(&data->irq_lock)
>  {
>  	struct device *dev = regmap_get_device(data->regmap);
>  	int ret;
> @@ -804,6 +805,7 @@ static int veml6031x00_event_enable(struct veml6031x00_data *data)
>  }
>
>  static int veml6031x00_event_disable(struct veml6031x00_data *data)
> +	__must_hold(&data->irq_lock)
>  {
>  	struct device *dev = regmap_get_device(data->regmap);
>  	int ret;

Thanks!

Reviewed-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>