Re: [PATCH] tests/intel: Add edge case and race condition tests for GEM_CHANGE_HANDLE

[Sebastian Brzezinka <sebastian.brzezinka@intel.com>]

Hi David,

On Wed Oct 7, 2026 at 4:12 PM CEST, David Francis wrote:
> From: Vitaly Prosyak <vitaly.prosyak@amd.com>
>
> Add a GPU-agnostic GEM_CHANGE_HANDLE tests. These test for basic
> functionality, edge cases, and race conditions of this ioctl against
> itself, gem close, gem create, and prime import and export.
>
> GEM_CHANGE_HANDLE is currently wired to drm_invalid_op in DRM core. This IGT
> coverage is a prerequisite for validating the eventual kernel-side ioctl
> implementation and makes fixing its security bugs safer.
>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
> Cc: Christian Konig <christian.koenig@amd.com>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Vitaly Prosyak <vitaly.prosyak@amd.com>
> Signed-off-by: David Francis <David.Francis@amd.com>
> ---
To me these tests look reasonable, but we need to make sure we don't
pollute CI with failures. GEM_CHANGE_HANDLE is still drm_invalid_op 
in DRM core, so on current kernels every subtest fails.

The best path would be to merge the kernel side first. But since these
tests are a prerequisite for the kernel patches, we need to work around
that somehow. Until the kernel part lands, the tests could skip when the
ioctl returns -EINVAL or -ENOTTY. Could you add that in the next revision?

For the contribution process, please take a look at the guide:
https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/blob/master/CONTRIBUTING.md

In short, patches are reviewed on the igt-dev mailing list, not through
GitLab merge requests. It would be nice to get an ack from one of the
maintainers (Kamil is Cc'd) before this is merged.


-- 
Best regards,
Sebastian