All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "E Shattow" <e@freeshell.de>,
	"Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Yixun Lan" <dlan@kernel.org>, "Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>
Cc: <devicetree@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
	<spacemit@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] riscv: defconfig: Enable AT24 EEPROM and ONIE TLV layout
Date: Thu, 05 Nov 2026 14:20:52 +0000	[thread overview]
Message-ID: <DMNCDUADFF3L.2ZLV0D2ZZ8CRB@linux.spacemit.com> (raw)
In-Reply-To: <0c4b79f0-383a-4884-8132-59dcb3487cd3@freeshell.de>

[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]

On Thu Nov 5, 2026 at 10:42 AM GMT, E Shattow wrote:
> On 11/5/26 00:23, Troy Mitchell wrote:
>> The OrangePi RV2 and R2S device trees take the Ethernet MAC address from
>> the ONIE TLV data in an AT24 EEPROM, and the K3 CoM260 module stores its
>> MAC address the same way. Without the EEPROM driver and the ONIE TLV
>> layout, the MAC address lookup keeps returning -EPROBE_DEFER and the
>> Ethernet controller never probes unless the bootloader passes a MAC
>> address in the device tree.
>> 
>> Enable both drivers as built-in so the MAC address is available as soon
>> as the Ethernet driver probes, including for network root file systems.
>
> This does not make sense for platforms which have no use for EEPROM
> driver in Linux userspace.
>
>> 
>> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
>> ---
>>  arch/riscv/configs/defconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
>> index 04ae305d5511..a76f801d8eed 100644
>> --- a/arch/riscv/configs/defconfig
>> +++ b/arch/riscv/configs/defconfig
>> @@ -276,6 +276,8 @@ CONFIG_PHY_STARFIVE_JH7110_DPHY_RX=m
>>  CONFIG_PHY_STARFIVE_JH7110_PCIE=m
>>  CONFIG_PHY_STARFIVE_JH7110_USB=m
>>  CONFIG_LIBNVDIMM=y
>> +CONFIG_NVMEM_LAYOUT_ONIE_TLV=y
>> +CONFIG_EEPROM_AT24=y
>
> Enabled as module, please.
Yes, you are right. Will be module in the next version.

-- 
Troy Mitchell


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "E Shattow" <e@freeshell.de>,
	"Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Yixun Lan" <dlan@kernel.org>, "Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>
Cc: <devicetree@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
	<spacemit@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] riscv: defconfig: Enable AT24 EEPROM and ONIE TLV layout
Date: Thu, 05 Nov 2026 14:20:52 +0000	[thread overview]
Message-ID: <DMNCDUADFF3L.2ZLV0D2ZZ8CRB@linux.spacemit.com> (raw)
In-Reply-To: <0c4b79f0-383a-4884-8132-59dcb3487cd3@freeshell.de>


[-- Attachment #1.1: Type: text/plain, Size: 1465 bytes --]

On Thu Nov 5, 2026 at 10:42 AM GMT, E Shattow wrote:
> On 11/5/26 00:23, Troy Mitchell wrote:
>> The OrangePi RV2 and R2S device trees take the Ethernet MAC address from
>> the ONIE TLV data in an AT24 EEPROM, and the K3 CoM260 module stores its
>> MAC address the same way. Without the EEPROM driver and the ONIE TLV
>> layout, the MAC address lookup keeps returning -EPROBE_DEFER and the
>> Ethernet controller never probes unless the bootloader passes a MAC
>> address in the device tree.
>> 
>> Enable both drivers as built-in so the MAC address is available as soon
>> as the Ethernet driver probes, including for network root file systems.
>
> This does not make sense for platforms which have no use for EEPROM
> driver in Linux userspace.
>
>> 
>> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
>> ---
>>  arch/riscv/configs/defconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
>> index 04ae305d5511..a76f801d8eed 100644
>> --- a/arch/riscv/configs/defconfig
>> +++ b/arch/riscv/configs/defconfig
>> @@ -276,6 +276,8 @@ CONFIG_PHY_STARFIVE_JH7110_DPHY_RX=m
>>  CONFIG_PHY_STARFIVE_JH7110_PCIE=m
>>  CONFIG_PHY_STARFIVE_JH7110_USB=m
>>  CONFIG_LIBNVDIMM=y
>> +CONFIG_NVMEM_LAYOUT_ONIE_TLV=y
>> +CONFIG_EEPROM_AT24=y
>
> Enabled as module, please.
Yes, you are right. Will be module in the next version.

-- 
Troy Mitchell


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-11-05 14:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  8:23 [PATCH 0/5] riscv: dts: spacemit: k3-com260: Describe SD card, SPI NOR and MAC Troy Mitchell
2026-11-05  8:23 ` Troy Mitchell
2026-11-05  8:23 ` [PATCH 1/5] riscv: dts: spacemit: k3-com260-ifx: Drop wrong SD card vmmc-supply Troy Mitchell
2026-11-05  8:23   ` Troy Mitchell
2026-11-05  8:23 ` [PATCH 2/5] riscv: dts: spacemit: k3-com260: Move SD card to the module Troy Mitchell
2026-11-05  8:23   ` Troy Mitchell
2026-11-05  8:23 ` [PATCH 3/5] riscv: dts: spacemit: k3-com260: Add SPI NOR flash Troy Mitchell
2026-11-05  8:23   ` Troy Mitchell
2026-11-06 16:25   ` Sarah Emery
2026-11-06 16:25     ` Sarah Emery
2026-11-07 12:48     ` Troy Mitchell
2026-11-07 12:48       ` Troy Mitchell
2026-11-07 13:19       ` Troy Mitchell
2026-11-07 13:19         ` Troy Mitchell
2026-11-05  8:23 ` [PATCH 4/5] riscv: defconfig: Enable AT24 EEPROM and ONIE TLV layout Troy Mitchell
2026-11-05  8:23   ` Troy Mitchell
2026-11-05 10:42   ` E Shattow
2026-11-05 10:42     ` E Shattow
2026-11-05 14:20     ` Troy Mitchell [this message]
2026-11-05 14:20       ` Troy Mitchell
2026-11-05  8:23 ` [PATCH 5/5] riscv: dts: spacemit: k3-com260: Set Ethernet MAC from EEPROM Troy Mitchell
2026-11-05  8:23   ` Troy Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMNCDUADFF3L.2ZLV0D2ZZ8CRB@linux.spacemit.com \
    --to=troy.mitchell@linux.spacemit.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=e@freeshell.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.