[PATCH 1/7] Using svn pools seems to solve the memory leak problem

[PATCH 1/7] Using svn pools seems to solve the memory leak problem

[Yaacov Akiba Slama]

Signed-off-by: Yaacov Akiba Slama <ya@slamail.org>

---

 git-svnimport.perl |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

applies-to: b12655de9a371d7d16f7e8318da8c5b0099c39bd
4356b879b425644c436eacb6d43b523bab960704
diff --git a/git-svnimport.perl b/git-svnimport.perl
index 45b6a19..5bf9ef2 100755
--- a/git-svnimport.perl
+++ b/git-svnimport.perl
@@ -112,7 +112,9 @@ sub file {
 		    DIR => File::Spec->tmpdir(), UNLINK => 1);
 
 	print "... $rev $path ...\n" if $opt_v;
-	eval { $self->{'svn'}->get_file($path,$rev,$fh); };
+	my $pool = SVN::Pool->new();
+	eval { $self->{'svn'}->get_file($path,$rev,$fh,$pool); };
+	$pool->clear;
 	if($@) {
 		return undef if $@ =~ /Attempted to get checksum/;
 		die $@;
@@ -674,7 +676,9 @@ sub commit_all {
 }
 
 while(++$current_rev <= $svn->{'maxrev'}) {
-	$svn->{'svn'}->get_log("/",$current_rev,$current_rev,$current_rev,1,1,\&_commit_all,"");
+	my $pool=SVN::Pool->new;
+	$svn->{'svn'}->get_log("/",$current_rev,$current_rev,1,1,1,\&_commit_all,$pool);
+	$pool->clear;
 	commit_all();
 	if($opt_l and not --$opt_l) {
 		print STDERR "Stopping, because there is a memory leak (in the SVN library).\n";
---
0.99.9.GIT

Re: [PATCH 1/7] Using svn pools seems to solve the memory leak problem

[Junio C Hamano]

I see you are resending the previous round after splitting, but
could you be a bit more careful about the commit log?  One liner
title that is self-sufficient (as opposed to just the initial
part of one sentence, cut off at whereever your editor happened
to decide to fold line), which goes to Subject:, and the body of
the message as a separate paragraph.

Especially something like this (5/7) does not make much sense:

    From: Yaacov Akiba Slama <ya@slamail.org>
    Subject: [PATCH 5/7] When copying files and/or directories from several branches in one single
    Date: Wed, 02 Nov 2005 23:51:57 +0200

    revision, all these branches are used as parents of the commit.