[PATCH] dtc: fix endian issue when reading blobs

[PATCH] dtc: fix endian issue when reading blobs

[Michael Neuling]

The reserve mem regions are screwy if you read a blob on x86.  I'm
guessing there may be a few more of these lurking in the code. 

Signed-off-by: Michael Neuling <mikey@neuling.org>

---
This now gives clean diffs between running on big and little endian machines.

 flattree.c |    2 ++
 1 file changed, 2 insertions(+)

Index: dtc/flattree.c
===================================================================
--- dtc.orig/flattree.c
+++ dtc/flattree.c
@@ -619,6 +619,8 @@ static struct reserve_info *flat_read_me
 	p = inb->ptr;
 	while (1) {
 		flat_read_chunk(inb, &re, sizeof(re));
+		re.address  = cpu_to_be64(re.address);
+		re.size = cpu_to_be64(re.size);
 		if (re.size == 0)
 			break;
 

Re: [PATCH] dtc: fix endian issue when reading blobs

[Michael Neuling]

The reserve mem regions are screwy if you read a blob on x86.  I'm
guessing there may be a few more of these lurking in the code. 

Signed-off-by: Michael Neuling <mikey@neuling.org>

---
Oops.. wrong way around.. thanks Milton.

 flattree.c |    2 ++
 1 file changed, 2 insertions(+)

Index: dtc/flattree.c
===================================================================
--- dtc.orig/flattree.c
+++ dtc/flattree.c
@@ -619,6 +619,8 @@ static struct reserve_info *flat_read_me
 	p = inb->ptr;
 	while (1) {
 		flat_read_chunk(inb, &re, sizeof(re));
+		re.address  = be64_to_cpu(re.address);
+		re.size = be64_to_cpu(re.size);
 		if (re.size == 0)
 			break;
 

Re: [PATCH] dtc: fix endian issue when reading blobs

[Jon Loeliger]

So, like, the other day Michael Neuling mumbled:
> The reserve mem regions are screwy if you read a blob on x86.  I'm
> guessing there may be a few more of these lurking in the code. 
> 
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> 
> ---
> Oops.. wrong way around.. thanks Milton.
> 
>  flattree.c |    2 ++
>  1 file changed, 2 insertions(+)

Your wish has been granted.

Thanks!

jdl