All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [5053] husb: Fixup printfs and stuff based on the review comments ( Max Krasnyansky)
@ 2008-08-21 19:32 Anthony Liguori
  0 siblings, 0 replies; only message in thread
From: Anthony Liguori @ 2008-08-21 19:32 UTC (permalink / raw)
  To: qemu-devel

Revision: 5053
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5053
Author:   aliguori
Date:     2008-08-21 19:32:29 +0000 (Thu, 21 Aug 2008)

Log Message:
-----------
husb: Fixup printfs and stuff based on the review comments (Max Krasnyansky)

Addressing Anthony's comments regarding printf and stuff.

Anthony, if you you want I can fold this commit and resend
the original patch.

Signed-off-by: Max Krasnyansky <maxk@kernel.org>
Signed-off-by: AnthonY Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/usb-linux.c

Modified: trunk/usb-linux.c
===================================================================
--- trunk/usb-linux.c	2008-08-21 19:31:52 UTC (rev 5052)
+++ trunk/usb-linux.c	2008-08-21 19:32:29 UTC (rev 5053)
@@ -272,7 +272,7 @@
     }
 
     if (i >= dev->descr_len) {
-        printf("husb: update iface failed. no matching configuration\n");
+        fprintf(stderr, "husb: update iface failed. no matching configuration\n");
         goto fail;
     }
     nb_interfaces = dev->descr[i + 4];
@@ -815,9 +815,6 @@
         return 0;
 
     for (f = usb_auto_filter; f; f = f->next) {
-        // printf("Auto match: bus_num %d addr %d vid %d pid %d\n",
-	//    bus_num, addr, vendor_id, product_id);
-
 	if (f->bus_num >= 0 && f->bus_num != bus_num)
             continue;
 
@@ -860,8 +857,8 @@
 {
     struct USBAutoFilter *f = qemu_mallocz(sizeof(*f));
     if (!f) {
-        printf("husb: failed to allocate auto filter\n");
-	return;
+        fprintf(stderr, "husb: failed to allocate auto filter\n");
+        return;
     }
 
     f->bus_num = bus_num;
@@ -878,7 +875,7 @@
          */
 	usb_auto_timer = qemu_new_timer(rt_clock, usb_host_auto_timer, NULL);
 	if (!usb_auto_timer) {
-            printf("husb: failed to allocate timer\n");
+            fprintf(stderr, "husb: failed to allocate auto scan timer\n");
             qemu_free(f);
             return;
         }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-08-21 19:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-21 19:32 [Qemu-devel] [5053] husb: Fixup printfs and stuff based on the review comments ( Max Krasnyansky) Anthony Liguori

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.