[PATCH 1/2] libfdt: Add version.lds file

[PATCH 1/2] libfdt: Add version.lds file

[Josh Boyer]

Add the initial symbol versioning file as groundwork for creating
a libfdt shared library

Signed-off-by: Josh Boyer <jwboyer-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
 libfdt/version.lds |   48 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 48 insertions(+), 0 deletions(-)
 create mode 100644 libfdt/version.lds

diff --git a/libfdt/version.lds b/libfdt/version.lds
new file mode 100644
index 0000000..7d90672
--- /dev/null
+++ b/libfdt/version.lds
@@ -0,0 +1,48 @@
+LIBFDT_1.2 {
+	global:
+		fdt_next_node;
+		fdt_check_header;
+		fdt_move;
+		fdt_string;
+		fdt_num_mem_rsv;
+		fdt_get_mem_rsv;
+		fdt_subnode_offset_namelen;
+		fdt_subnode_offset;
+		fdt_path_offset;
+		fdt_get_name;
+		fdt_get_property_namelen;
+		fdt_get_property;
+		fdt_getprop_namelen;
+		fdt_getprop;
+		fdt_get_phandle;
+		fdt_get_alias_namelen;
+		fdt_get_alias;
+		fdt_get_path;
+		fdt_supernode_atdepth_offset;
+		fdt_node_depth;
+		fdt_parent_offset;
+		fdt_node_offset_by_prop_value;
+		fdt_node_offset_by_phandle;
+		fdt_node_check_compatible;
+		fdt_node_offset_by_compatible;
+		fdt_setprop_inplace;
+		fdt_nop_property;
+		fdt_nop_node;
+		fdt_create;
+		fdt_add_reservemap_entry;
+		fdt_finish_reservemap;
+		fdt_begin_node;
+		fdt_property;
+		fdt_end_node;
+		fdt_finish;
+		fdt_open_into;
+		fdt_pack;
+		fdt_add_mem_rsv;
+		fdt_del_mem_rsv;
+		fdt_set_name;
+		fdt_setprop;
+		fdt_delprop;
+		fdt_add_subnode_namelen;
+		fdt_add_subnode;
+		fdt_del_node;
+};
-- 
1.5.6.5

Re: [PATCH 1/2] libfdt: Add version.lds file

[Jon Loeliger]

> Add the initial symbol versioning file as groundwork for creating
> a libfdt shared library
> 
> Signed-off-by: Josh Boyer <jwboyer-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> ---
>  libfdt/version.lds |   48 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 48 insertions(+), 0 deletions(-)
>  create mode 100644 libfdt/version.lds
> 
> diff --git a/libfdt/version.lds b/libfdt/version.lds
> new file mode 100644
> index 0000000..7d90672
> --- /dev/null
> +++ b/libfdt/version.lds
> @@ -0,0 +1,48 @@
> +LIBFDT_1.2 {
> +	global:
> +		fdt_next_node;
> +		fdt_check_header;
> +		fdt_move;
> +		fdt_string;

Oh wow....  Any mechanism for making this a NOT hard-coded list?
Some in-source macro-doo-dad-flag-setup-section-list thing?

jdl

Re: [PATCH 1/2] libfdt: Add version.lds file

[Josh Boyer]

On Tue, Nov 25, 2008 at 10:50:32AM -0600, Jon Loeliger wrote:
>> Add the initial symbol versioning file as groundwork for creating
>> a libfdt shared library
>> 
>> Signed-off-by: Josh Boyer <jwboyer-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
>> ---
>>  libfdt/version.lds |   48 ++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 files changed, 48 insertions(+), 0 deletions(-)
>>  create mode 100644 libfdt/version.lds
>> 
>> diff --git a/libfdt/version.lds b/libfdt/version.lds
>> new file mode 100644
>> index 0000000..7d90672
>> --- /dev/null
>> +++ b/libfdt/version.lds
>> @@ -0,0 +1,48 @@
>> +LIBFDT_1.2 {
>> +	global:
>> +		fdt_next_node;
>> +		fdt_check_header;
>> +		fdt_move;
>> +		fdt_string;
>
>Oh wow....  Any mechanism for making this a NOT hard-coded list?
>Some in-source macro-doo-dad-flag-setup-section-list thing?

Yeah, I had the same thought.  I'll look a bit more, but this is what
libhugetlbfs is using at the moment.  The only other library I'm
remotely familiar with that does versioning is glibc.  Maybe they
have magic foo I can steal.

FWIW, you _can_ use globs.  We could trim the list down a bit using
that, but not by much.  Also, I'm not entirely sure what is to be
considered 'public' so I just went with what was in libfdt.h. 
Review on that front is more than welcome.

josh

Re: [PATCH 1/2] libfdt: Add version.lds file

[Josh Boyer]

On Tue, Nov 25, 2008 at 11:57:47AM -0500, Josh Boyer wrote:
>On Tue, Nov 25, 2008 at 10:50:32AM -0600, Jon Loeliger wrote:
>>> Add the initial symbol versioning file as groundwork for creating
>>> a libfdt shared library
>>> 
>>> Signed-off-by: Josh Boyer <jwboyer-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
>>> ---
>>>  libfdt/version.lds |   48 ++++++++++++++++++++++++++++++++++++++++++++++++
>>>  1 files changed, 48 insertions(+), 0 deletions(-)
>>>  create mode 100644 libfdt/version.lds
>>> 
>>> diff --git a/libfdt/version.lds b/libfdt/version.lds
>>> new file mode 100644
>>> index 0000000..7d90672
>>> --- /dev/null
>>> +++ b/libfdt/version.lds
>>> @@ -0,0 +1,48 @@
>>> +LIBFDT_1.2 {
>>> +	global:
>>> +		fdt_next_node;
>>> +		fdt_check_header;
>>> +		fdt_move;
>>> +		fdt_string;
>>
>>Oh wow....  Any mechanism for making this a NOT hard-coded list?
>>Some in-source macro-doo-dad-flag-setup-section-list thing?
>
>Yeah, I had the same thought.  I'll look a bit more, but this is what
>libhugetlbfs is using at the moment.  The only other library I'm
>remotely familiar with that does versioning is glibc.  Maybe they
>have magic foo I can steal.

No really awesome magic.  They have a similar mechanism of having
a hard-coded list.  We could do something like this in the source
code:

#define fdt_func ver_1_2_fdt_func
int fdt_func(...) {

and then this in version.lds:

LIBFDT_1.2 {
	global:
		ver_1_2*;
}

but that seems pretty ugly too...

The hard-coded list is pretty simple, at the risk of missing things.

josh

Re: [PATCH 1/2] libfdt: Add version.lds file

[David Gibson]

On Tue, Nov 25, 2008 at 12:16:48PM -0500, Josh Boyer wrote:
> On Tue, Nov 25, 2008 at 11:57:47AM -0500, Josh Boyer wrote:
> >On Tue, Nov 25, 2008 at 10:50:32AM -0600, Jon Loeliger wrote:
> >>> Add the initial symbol versioning file as groundwork for creating
> >>> a libfdt shared library
> >>> 
> >>> Signed-off-by: Josh Boyer <jwboyer-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> >>> ---
> >>>  libfdt/version.lds |   48 ++++++++++++++++++++++++++++++++++++++++++++++++
> >>>  1 files changed, 48 insertions(+), 0 deletions(-)
> >>>  create mode 100644 libfdt/version.lds
> >>> 
> >>> diff --git a/libfdt/version.lds b/libfdt/version.lds
> >>> new file mode 100644
> >>> index 0000000..7d90672
> >>> --- /dev/null
> >>> +++ b/libfdt/version.lds
> >>> @@ -0,0 +1,48 @@
> >>> +LIBFDT_1.2 {
> >>> +	global:
> >>> +		fdt_next_node;
> >>> +		fdt_check_header;
> >>> +		fdt_move;
> >>> +		fdt_string;
> >>
> >>Oh wow....  Any mechanism for making this a NOT hard-coded list?
> >>Some in-source macro-doo-dad-flag-setup-section-list thing?
> >
> >Yeah, I had the same thought.  I'll look a bit more, but this is what
> >libhugetlbfs is using at the moment.  The only other library I'm
> >remotely familiar with that does versioning is glibc.  Maybe they
> >have magic foo I can steal.
> 
> No really awesome magic.  They have a similar mechanism of having
> a hard-coded list.  We could do something like this in the source
> code:

Not to mention that looking at glibc source tends to make one's eyes
bleed.

> #define fdt_func ver_1_2_fdt_func
> int fdt_func(...) {
> 
> and then this in version.lds:
> 
> LIBFDT_1.2 {
> 	global:
> 		ver_1_2*;
> }
> 
> but that seems pretty ugly too...

I concur

> The hard-coded list is pretty simple, at the risk of missing things.

I'm actually not too wirried about missing things.  If we miss
something, it's pretty easy to fix.  It probably would be a good idea
to make the testsuite build against the shared version of the library
to verify that at least the functions exercised there are correctly
exposed.

I'm marginally more worried about an overbroad wildcard including
something we didn't really want exposed.  I think the versioning
script needs a:
	local:
		*
after the global list to to inhibit exposing everything else.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [PATCH 1/2] libfdt: Add version.lds file

[Josh Boyer]

On Wed, 26 Nov 2008 12:47:53 +1100
David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> wrote:

> > The hard-coded list is pretty simple, at the risk of missing things.
> 
> I'm actually not too wirried about missing things.  If we miss
> something, it's pretty easy to fix.  It probably would be a good idea
> to make the testsuite build against the shared version of the library
> to verify that at least the functions exercised there are correctly
> exposed.

That's a good idea.  I'll see what I can do there.

> I'm marginally more worried about an overbroad wildcard including
> something we didn't really want exposed.  I think the versioning
> script needs a:
> 	local:
> 		*
> after the global list to to inhibit exposing everything else.

Ah, yes.  It would be good for someone with more of a clue than me to
vet the list I have in the file right now, and make sure I didn't
include/omit things that shouldn't/should be there.  Once that is done,
I can do the local thing.

josh

Re: [PATCH 1/2] libfdt: Add version.lds file

[David Gibson]

On Tue, Nov 25, 2008 at 08:57:18PM -0500, Josh Boyer wrote:
> On Wed, 26 Nov 2008 12:47:53 +1100
> David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> wrote:
> 
> > > The hard-coded list is pretty simple, at the risk of missing things.
> > 
> > I'm actually not too wirried about missing things.  If we miss
> > something, it's pretty easy to fix.  It probably would be a good idea
> > to make the testsuite build against the shared version of the library
> > to verify that at least the functions exercised there are correctly
> > exposed.
> 
> That's a good idea.  I'll see what I can do there.
> 
> > I'm marginally more worried about an overbroad wildcard including
> > something we didn't really want exposed.  I think the versioning
> > script needs a:
> > 	local:
> > 		*
> > after the global list to to inhibit exposing everything else.
> 
> Ah, yes.  It would be good for someone with more of a clue than me to
> vet the list I have in the file right now, and make sure I didn't
> include/omit things that shouldn't/should be there.  Once that is done,
> I can do the local thing.

Oh, sorry forgot to add, everything on your list so far looks like it
should be exposed.  Omissions I'll need to look more carefully.  But
if the testsuite builds against it we should be pretty right.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson