[PATCH] Fix libraries (static and dynamic) installation

[PATCH] Fix libraries (static and dynamic) installation

[Emil Medve]

Signed-off-by: Emil Medve <Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
---

The static library was not installed at all and the dynamic library was
installed without execute permission

 Makefile |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index 1cfa28a..be0fc8b 100644
--- a/Makefile
+++ b/Makefile
@@ -142,2 +142,2 @@ endif
 # intermediate target and building them again "for real"
 .SECONDARY: $(DTC_GEN_SRCS) $(CONVERT_GEN_SRCS)

-
-
 install: all
 	@$(VECHO) INSTALL
 	$(INSTALL) -d $(DESTDIR)$(BINDIR)
-	$(INSTALL) -m 755 $(BIN) $(DESTDIR)$(BINDIR)
+	$(INSTALL) $(BIN) $(DESTDIR)$(BINDIR)
 	$(INSTALL) -d $(DESTDIR)$(LIBDIR)
-	$(INSTALL) -m 644 $(LIBFDT_lib) $(DESTDIR)$(LIBDIR)
+	$(INSTALL) $(LIBFDT_lib) $(DESTDIR)$(LIBDIR)
+	$(INSTALL) -m 644 $(LIBFDT_archive) $(DESTDIR)$(LIBDIR)
 	$(INSTALL) -d $(DESTDIR)$(INCLUDEDIR)
 	$(INSTALL) -m 644 $(LIBFDT_include) $(DESTDIR)$(INCLUDEDIR)

--
1.6.1.3

Re: [PATCH] Fix libraries (static and dynamic) installation

[Jon Loeliger]

> Signed-off-by: Emil Medve <Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
> ---
> 
> The static library was not installed at all and the dynamic library was
> installed without execute permission


Emil,

I rearranged that log to put your description in it.
But the real problem is that applying it is a no-op.
I think your patch is mal-formed.  Specifically, it
looks like the line counts:

    @@ -142,2 +142,2 @@ endif

are bogus.  Only 2 lines?

Cleverly, Git applys the patch and yields a commit
with no changes.  (Identical tree before and after.)
Clearly wrong.

Can you send me a better patch?

Thanks,
jdl



>  Makefile |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 1cfa28a..be0fc8b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -142,2 +142,2 @@ endif
>  # intermediate target and building them again "for real"
>  .SECONDARY: $(DTC_GEN_SRCS) $(CONVERT_GEN_SRCS)
> 
> -
> -
>  install: all
>  	@$(VECHO) INSTALL
>  	$(INSTALL) -d $(DESTDIR)$(BINDIR)
> -	$(INSTALL) -m 755 $(BIN) $(DESTDIR)$(BINDIR)
> +	$(INSTALL) $(BIN) $(DESTDIR)$(BINDIR)
>  	$(INSTALL) -d $(DESTDIR)$(LIBDIR)
> -	$(INSTALL) -m 644 $(LIBFDT_lib) $(DESTDIR)$(LIBDIR)
> +	$(INSTALL) $(LIBFDT_lib) $(DESTDIR)$(LIBDIR)
> +	$(INSTALL) -m 644 $(LIBFDT_archive) $(DESTDIR)$(LIBDIR)
>  	$(INSTALL) -d $(DESTDIR)$(INCLUDEDIR)
>  	$(INSTALL) -m 644 $(LIBFDT_include) $(DESTDIR)$(INCLUDEDIR)
> 
> --
> 1.6.1.3
> 
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
> https://ozlabs.org/mailman/listinfo/devicetree-discuss