* dtc: Add -Wredundant-decls (resend)
@ 2010-04-30 5:27 David Gibson
2010-04-30 13:38 ` Jon Loeliger
0 siblings, 1 reply; 2+ messages in thread
From: David Gibson @ 2010-04-30 5:27 UTC (permalink / raw)
To: Jon Loeliger, devicetree-discuss-mnsaURCQ41sdnm+yROfE0A
We are almost clean already with the -Wredundant-decls warning. The
only exception is a declaration for isatty() inside the flex-generated
code. This can be removed by using flex's "never-interactive" option,
which we probably should be using anyway, since we never parse
interactively in the sense that this option implies.
Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Index: dtc/Makefile
===================================================================
--- dtc.orig/Makefile 2010-03-11 11:12:43.704724530 +1100
+++ dtc/Makefile 2010-03-11 11:12:45.920725101 +1100
@@ -17,7 +17,7 @@ CONFIG_LOCALVERSION =
CPPFLAGS = -I libfdt
WARNINGS = -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs \
- -Wstrict-prototypes -Wmissing-prototypes
+ -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls
CFLAGS = -g -Os -fPIC -Werror $(WARNINGS)
BISON = bison
Index: dtc/convert-dtsv0-lexer.l
===================================================================
--- dtc.orig/convert-dtsv0-lexer.l 2010-03-11 11:12:43.600746855 +1100
+++ dtc/convert-dtsv0-lexer.l 2010-03-11 11:12:45.920725101 +1100
@@ -17,7 +17,7 @@
* USA
*/
-%option noyywrap nounput noinput
+%option noyywrap nounput noinput never-interactive
%x INCLUDE
%x BYTESTRING
Index: dtc/dtc-lexer.l
===================================================================
--- dtc.orig/dtc-lexer.l 2010-03-11 11:12:43.612724636 +1100
+++ dtc/dtc-lexer.l 2010-03-11 11:12:45.920725101 +1100
@@ -18,7 +18,7 @@
* USA
*/
-%option noyywrap nounput noinput
+%option noyywrap nounput noinput never-interactive
%x INCLUDE
%x BYTESTRING
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: dtc: Add -Wredundant-decls (resend)
2010-04-30 5:27 dtc: Add -Wredundant-decls (resend) David Gibson
@ 2010-04-30 13:38 ` Jon Loeliger
0 siblings, 0 replies; 2+ messages in thread
From: Jon Loeliger @ 2010-04-30 13:38 UTC (permalink / raw)
To: David Gibson; +Cc: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A
> We are almost clean already with the -Wredundant-decls warning. The
> only exception is a declaration for isatty() inside the flex-generated
> code. This can be removed by using flex's "never-interactive" option,
> which we probably should be using anyway, since we never parse
> interactively in the sense that this option implies.
>
> Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-30 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-30 5:27 dtc: Add -Wredundant-decls (resend) David Gibson
2010-04-30 13:38 ` Jon Loeliger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.