* [PATCH] Fix de2104x driver failing to readout MAC address correctly
@ 2010-06-10 8:48 Morten Holst Larsen
0 siblings, 0 replies; only message in thread
From: Morten Holst Larsen @ 2010-06-10 8:48 UTC (permalink / raw)
To: linux-alpha
Fix de2104x driver failing to readout MAC address correctly
This patch fixes a missing read memory barrier that is needed for the
driver to readout the MAC address correctly from the on-board ROM.
Also it replaces the use of the deprecated functions readl()/writel().
Signed-off-by: Morten H. Larsen <m-larsen@post6.tele.dk>
----
diff -uNr a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
--- a/drivers/net/tulip/de2104x.c 2010-06-06 05:43:24.000000000 +0200
+++ b/drivers/net/tulip/de2104x.c 2010-06-07 15:45:35.000000000 +0200
@@ -367,8 +367,8 @@
static u16 t21041_csr15[] = { 0x0008, 0x0006, 0x000E, 0x0008, 0x0008, };
-#define dr32(reg) readl(de->regs + (reg))
-#define dw32(reg,val) writel((val), de->regs + (reg))
+#define dr32(reg) ioread32(de->regs + (reg))
+#define dw32(reg, val) iowrite32((val), de->regs + (reg))
static void de_rx_err_acct (struct de_private *de, unsigned rx_tail,
@@ -1706,6 +1706,7 @@
int value, boguscnt = 100000;
do {
value = dr32(ROMCmd);
+ rmb();
} while (value < 0 && --boguscnt > 0);
de->dev->dev_addr[i] = value;
udelay(1);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-06-10 8:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-10 8:48 [PATCH] Fix de2104x driver failing to readout MAC address correctly Morten Holst Larsen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.