Re: [PATCH] libfdt: include version number in soname

[Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>]

> On Tue, Apr 26, 2011 at 01:16:27PM +0200, Paolo Bonzini wrote:
> > On 04/26/2011 12:45 PM, David Gibson wrote:
> > > 
> > > libfdt: include version number in soname
> > > 
> > > From: Paolo Bonzini<pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > 
> > > The libfdt shared library is only installed by its unversioned name.
> > > Including it properly in a distribution requires installation of both
> > > the versioned name (used in the binary-only package) and the unversioned
> > > name (used in the development package).  The latter is just a symbolic
> > > link, so you need to change the soname in turn to include the version.
> > > 
> > > While at it, use Makefile variables to shorten some lines and avoid
> > > cut-and-paste typos; and clean up remnants of when shared libraries were
> > > not supported on Darwin.
> > > 
> > > Signed-off-by: Paolo Bonzini<pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > Signed-off-by: David Gibson<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
> > 
> > This:
> > 
> > +	$(CC) $(LDFLAGS) -fPIC $(SHAREDLIB_LINK_OPTIONS)$(LIBFDT_SONAME) -o $(LIBFDT_lib) $^
> > 
> > should be $(LIBFDT_soname).
> 
> Ugh, yes, instead of $(LIBFDT_SONAME) to be clear.  I did check the
> soname on my build, I must have made an accidental press of M-u after
> I did so, sorry.


Applied with last-minute mod and pushed out.

Consider this the candidate for a 1.3.0 release!

Thanks!
jdl