From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/13] FB: sa1100: remove assabet specific initialization
Date: Sat, 04 Feb 2012 09:41:08 +0000 [thread overview]
Message-ID: <E1Rtc7I-0000at-EL@rmk-PC.arm.linux.org.uk> (raw)
In-Reply-To: <20120204093744.GQ889@n2100.arm.linux.org.uk>
Remove the assabet specific initialization for PAL output mode -
we call the lcd_power function before we enable the LCD controller,
which will disable the LCD panel to prevent it receiving incorrect
timings. Therefore, this setup here is redundant.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
drivers/video/sa1100fb.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/video/sa1100fb.c b/drivers/video/sa1100fb.c
index c9f1e7c..f6e27f4 100644
--- a/drivers/video/sa1100fb.c
+++ b/drivers/video/sa1100fb.c
@@ -182,7 +182,6 @@
#include <mach/hardware.h>
#include <asm/mach-types.h>
-#include <mach/assabet.h>
#include <mach/shannon.h>
/*
@@ -190,8 +189,6 @@
*/
#define DEBUG_VAR 1
-#undef ASSABET_PAL_VIDEO
-
#include "sa1100fb.h"
static const struct sa1100fb_rgb rgb_4 = {
@@ -1229,11 +1226,6 @@ static int __devinit sa1100fb_probe(struct platform_device *pdev)
goto failed;
}
-#ifdef ASSABET_PAL_VIDEO
- if (machine_is_assabet())
- ASSABET_BCR_clear(ASSABET_BCR_LCD_ON);
-#endif
-
/*
* This makes sure that our colour bitfield
* descriptors are correctly initialised.
--
1.7.4.4
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/13] FB: sa1100: remove assabet specific initialization
Date: Sat, 04 Feb 2012 09:41:08 +0000 [thread overview]
Message-ID: <E1Rtc7I-0000at-EL@rmk-PC.arm.linux.org.uk> (raw)
In-Reply-To: <20120204093744.GQ889@n2100.arm.linux.org.uk>
Remove the assabet specific initialization for PAL output mode -
we call the lcd_power function before we enable the LCD controller,
which will disable the LCD panel to prevent it receiving incorrect
timings. Therefore, this setup here is redundant.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
drivers/video/sa1100fb.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/video/sa1100fb.c b/drivers/video/sa1100fb.c
index c9f1e7c..f6e27f4 100644
--- a/drivers/video/sa1100fb.c
+++ b/drivers/video/sa1100fb.c
@@ -182,7 +182,6 @@
#include <mach/hardware.h>
#include <asm/mach-types.h>
-#include <mach/assabet.h>
#include <mach/shannon.h>
/*
@@ -190,8 +189,6 @@
*/
#define DEBUG_VAR 1
-#undef ASSABET_PAL_VIDEO
-
#include "sa1100fb.h"
static const struct sa1100fb_rgb rgb_4 = {
@@ -1229,11 +1226,6 @@ static int __devinit sa1100fb_probe(struct platform_device *pdev)
goto failed;
}
-#ifdef ASSABET_PAL_VIDEO
- if (machine_is_assabet())
- ASSABET_BCR_clear(ASSABET_BCR_LCD_ON);
-#endif
-
/*
* This makes sure that our colour bitfield
* descriptors are correctly initialised.
--
1.7.4.4
next prev parent reply other threads:[~2012-02-04 9:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 9:37 [PATCH 00/13] sa1100fb cleanups Russell King - ARM Linux
2012-02-04 9:37 ` Russell King - ARM Linux
2012-02-04 9:38 ` [PATCH 01/13] FB: sa1100: avoid section mismatch warnings Russell King - ARM Linux
2012-02-04 9:38 ` Russell King - ARM Linux
2012-02-04 9:38 ` [PATCH 02/13] FB: sa1100: add .owner initializer to driver structure Russell King - ARM Linux
2012-02-04 9:38 ` Russell King - ARM Linux
2012-02-04 9:39 ` [PATCH 03/13] FB: sa1100: constify rgb structures Russell King - ARM Linux
2012-02-04 9:39 ` Russell King - ARM Linux
2012-02-04 9:39 ` [PATCH 04/13] FB: sa1100: convert printks to dev_xxx() Russell King - ARM Linux
2012-02-04 9:39 ` Russell King - ARM Linux
2012-02-04 9:39 ` [PATCH 05/13] FB: sa1100: combine RGB bitfield overrides into sa1100fb_mach_info Russell King - ARM Linux
2012-02-04 9:39 ` Russell King - ARM Linux
2012-02-04 9:40 ` [PATCH 06/13] FB: sa1100: move machine inf structures to <video/sa1100fb.h> Russell King - ARM Linux
2012-02-04 9:40 ` Russell King - ARM Linux
2012-02-04 9:40 ` [PATCH 07/13] FB: sa1100: move platform data to platform files Russell King - ARM Linux
2012-02-04 9:40 ` Russell King - ARM Linux
2012-02-04 9:40 ` [PATCH 08/13] FB: sa1100: remove global sa1100fb_.*_power function pointers Russell King - ARM Linux
2012-02-04 9:40 ` Russell King - ARM Linux
2012-02-04 9:41 ` Russell King - ARM Linux [this message]
2012-02-04 9:41 ` [PATCH 09/13] FB: sa1100: remove assabet specific initialization Russell King - ARM Linux
2012-02-04 9:41 ` [PATCH 10/13] FB: sa1100: use inf members directly Russell King - ARM Linux
2012-02-04 9:41 ` Russell King - ARM Linux
2012-02-04 9:41 ` [PATCH 11/13] FB: sa1100: make GPIO configuration setting safe Russell King - ARM Linux
2012-02-04 9:41 ` Russell King - ARM Linux
2012-02-04 9:42 ` [PATCH 12/13] FB: sa11x0: fix shannon GPSR/GPCR accesses Russell King - ARM Linux
2012-02-04 9:42 ` Russell King - ARM Linux
2012-02-04 9:42 ` [PATCH 13/13] FB: sa11x0: convert shannon display enable accesses to use GPIO subsystem Russell King - ARM Linux
2012-02-04 9:42 ` Russell King - ARM Linux
2012-02-19 22:40 ` [PATCH 00/13] sa1100fb cleanups Florian Tobias Schandinat
2012-02-19 22:40 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Rtc7I-0000at-EL@rmk-PC.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.