All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+kernel@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-mmc@vger.kernel.org
Cc: Chris Ball <cjb@laptop.org>
Subject: [PATCH 04/12] mmc: omap_hsmmc: release correct resource
Date: Mon, 23 Apr 2012 17:05:30 +0100	[thread overview]
Message-ID: <E1SMLla-0002WE-QO@rmk-PC.arm.linux.org.uk> (raw)
In-Reply-To: <20120423160409.GE24299@n2100.arm.linux.org.uk>

res can be one of several resources, as this variable is re-used several
times during probe.  This can cause the wrong resource parameters to be
passed to release_mem_region().

Get the original memory resource before calling release_mem_region().

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 drivers/mmc/host/omap_hsmmc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 5c2b1c1..ac26f81a 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2030,7 +2030,9 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev)
 err_alloc:
 	omap_hsmmc_gpio_free(pdata);
 err:
-	release_mem_region(res->start, resource_size(res));
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (res)
+		release_mem_region(res->start, resource_size(res));
 	return ret;
 }
 
-- 
1.7.4.4


WARNING: multiple messages have this Message-ID (diff)
From: rmk+kernel@arm.linux.org.uk (Russell King)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/12] mmc: omap_hsmmc: release correct resource
Date: Mon, 23 Apr 2012 17:05:30 +0100	[thread overview]
Message-ID: <E1SMLla-0002WE-QO@rmk-PC.arm.linux.org.uk> (raw)
In-Reply-To: <20120423160409.GE24299@n2100.arm.linux.org.uk>

res can be one of several resources, as this variable is re-used several
times during probe.  This can cause the wrong resource parameters to be
passed to release_mem_region().

Get the original memory resource before calling release_mem_region().

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 drivers/mmc/host/omap_hsmmc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 5c2b1c1..ac26f81a 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2030,7 +2030,9 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev)
 err_alloc:
 	omap_hsmmc_gpio_free(pdata);
 err:
-	release_mem_region(res->start, resource_size(res));
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (res)
+		release_mem_region(res->start, resource_size(res));
 	return ret;
 }
 
-- 
1.7.4.4

  parent reply	other threads:[~2012-04-23 16:05 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23 16:04 [RFC 00/12] OMAP DMA engine conversion Russell King - ARM Linux
2012-04-23 16:04 ` Russell King - ARM Linux
2012-04-23 16:04 ` [PATCH 01/12] ARM: OMAP: fix DMA vs memory ordering Russell King
2012-04-23 16:04   ` Russell King
2012-04-23 16:04 ` [PATCH 02/12] dmaengine: split out virtual channel DMA support from sa11x0 driver Russell King
2012-04-23 16:04   ` Russell King
2012-04-27 18:57   ` Linus Walleij
2012-04-27 18:57     ` Linus Walleij
2012-04-23 16:05 ` [PATCH 03/12] dmaengine: add OMAP DMA engine driver Russell King
2012-04-23 16:05   ` Russell King
2012-04-23 16:05 ` Russell King [this message]
2012-04-23 16:05   ` [PATCH 04/12] mmc: omap_hsmmc: release correct resource Russell King
2012-04-23 16:05 ` [PATCH 05/12] mmc: omap_hsmmc: add DMA engine support Russell King
2012-04-23 16:05   ` Russell King
2012-04-24  0:16   ` Tony Lindgren
2012-04-24  0:16     ` Tony Lindgren
2012-04-27 19:00   ` Linus Walleij
2012-04-27 19:00     ` Linus Walleij
2012-04-27 19:03     ` Russell King - ARM Linux
2012-04-27 19:03       ` Russell King - ARM Linux
2012-04-27 20:34       ` Linus Walleij
2012-04-27 20:34         ` Linus Walleij
2012-04-23 16:06 ` [PATCH 06/12] mmc: omap_hsmmc: remove private DMA API implementation Russell King
2012-04-23 16:06   ` Russell King
2012-04-24  0:17   ` Tony Lindgren
2012-04-24  0:17     ` Tony Lindgren
2012-04-24 21:51   ` Grazvydas Ignotas
2012-04-24 21:51     ` Grazvydas Ignotas
2012-04-24 22:05     ` Russell King - ARM Linux
2012-04-24 22:05       ` Russell King - ARM Linux
2012-04-23 16:06 ` [PATCH 07/12] mmc: omap: add DMA engine support Russell King
2012-04-23 16:06   ` Russell King
2012-04-24  0:13   ` Tony Lindgren
2012-04-24  0:13     ` Tony Lindgren
2012-04-28 16:37     ` Russell King - ARM Linux
2012-04-28 16:37       ` Russell King - ARM Linux
2012-04-30 15:59       ` Tony Lindgren
2012-04-30 15:59         ` Tony Lindgren
2012-04-23 16:06 ` [PATCH 08/12] mmc: omap: remove private DMA API implementation Russell King
2012-04-23 16:06   ` Russell King
2012-04-23 16:07 ` [PATCH 09/12] ARM: omap: remove mmc platform data dma_mask and initialization Russell King
2012-04-23 16:07   ` Russell King
2012-04-23 16:07 ` [PATCH 10/12] spi: omap2-mcspi: add DMA engine support Russell King
2012-04-23 16:07   ` Russell King
2012-04-27 17:20   ` Grant Likely
2012-04-27 17:20     ` Grant Likely
2012-04-23 16:07 ` [PATCH 11/12] spi: omap2-mcspi: remove private DMA API implementation Russell King
2012-04-23 16:07   ` Russell King
2012-04-23 16:08 ` [PATCH 12/12] Add removal of old OMAP private DMA implementation to feature removal Russell King
2012-04-23 16:08   ` Russell King
2012-04-24  0:17   ` Tony Lindgren
2012-04-24  0:17     ` Tony Lindgren
2012-04-27 20:19   ` Linus Walleij
2012-04-27 20:19     ` Linus Walleij
2012-04-24 10:38 ` [RFC 00/12] OMAP DMA engine conversion Russell King - ARM Linux
2012-04-24 10:38   ` Russell King - ARM Linux
2012-04-24 16:51   ` Tony Lindgren
2012-04-24 16:51     ` Tony Lindgren
2012-04-24 22:47     ` Grazvydas Ignotas
2012-04-24 22:47       ` Grazvydas Ignotas
2012-04-24 23:29       ` Russell King - ARM Linux
2012-04-24 23:29         ` Russell King - ARM Linux
2012-04-24 23:59         ` Grazvydas Ignotas
2012-04-24 23:59           ` Grazvydas Ignotas
2012-05-09 12:25 ` T Krishnamoorthy, Balaji
2012-05-09 12:25   ` T Krishnamoorthy, Balaji
2012-05-15  4:19 ` Vinod Koul
2012-05-15  4:19   ` Vinod Koul
2012-05-15  7:41   ` Russell King - ARM Linux
2012-05-15  7:41     ` Russell King - ARM Linux
2012-05-15  8:59     ` Vinod Koul
2012-05-15  8:59       ` Vinod Koul
2012-05-15  9:32       ` Russell King - ARM Linux
2012-05-15  9:32         ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1SMLla-0002WE-QO@rmk-PC.arm.linux.org.uk \
    --to=rmk+kernel@arm.linux.org.uk \
    --cc=cjb@laptop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.