[PATCH] Fix compilation warning/error in setprop_inplace.c

[PATCH] Fix compilation warning/error in setprop_inplace.c

[Stephen Warren]

From: Stephen Warren <swarren@nvidia.com>

When compiling the current code-base with gcc 4.6.1, the following warning
is raised, which is interpreted as an error:

cc1: warnings being treated as errors
tests/setprop_inplace.c: In function ‘main’:
tests/setprop_inplace.c:62: error: format ‘%016llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘uint64_t’
tests/setprop_inplace.c:68: error: format ‘%016llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘uint64_t’

Use printf format specifiers from <inttypes.h> to solve this.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 tests/setprop_inplace.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/setprop_inplace.c b/tests/setprop_inplace.c
index 30a1cf3..82d8951 100644
--- a/tests/setprop_inplace.c
+++ b/tests/setprop_inplace.c
@@ -18,6 +18,7 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
+#include <inttypes.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
@@ -48,7 +49,7 @@ int main(int argc, char *argv[])
 	verbose_printf("Old int value was 0x%08x\n", *intp);
 	err = fdt_setprop_inplace_cell(fdt, 0, "prop-int", ~TEST_VALUE_1);
 	if (err)
-		FAIL("Failed to set \"prop-int\" to 0x08%x: %s",
+		FAIL("Failed to set \"prop-int\" to 0x%08x: %s",
 		     ~TEST_VALUE_1, fdt_strerror(err));
 	intp = check_getprop_cell(fdt, 0, "prop-int", ~TEST_VALUE_1);
 	verbose_printf("New int value is 0x%08x\n", *intp);
@@ -59,13 +60,13 @@ int main(int argc, char *argv[])
 
 	int64p = check_getprop_64(fdt, 0, "prop-int64", TEST_VALUE64_1);
 
-	verbose_printf("Old int64 value was 0x%016llx\n", *int64p);
+	verbose_printf("Old int64 value was 0x%016" PRIx64 "\n", *int64p);
 	err = fdt_setprop_inplace_u64(fdt, 0, "prop-int64", ~TEST_VALUE64_1);
 	if (err)
-		FAIL("Failed to set \"prop-int64\" to 0x016%llx: %s",
+		FAIL("Failed to set \"prop-int64\" to 0x%016llx: %s",
 		     ~TEST_VALUE64_1, fdt_strerror(err));
 	int64p = check_getprop_64(fdt, 0, "prop-int64", ~TEST_VALUE64_1);
-	verbose_printf("New int64 value is 0x%016llx\n", *int64p);
+	verbose_printf("New int64 value is 0x%016" PRIx64 "\n", *int64p);
 
 	strp = check_getprop(fdt, 0, "prop-str", strlen(TEST_STRING_1)+1,
 			     TEST_STRING_1);
-- 
1.7.0.4

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] Fix compilation warning/error in setprop_inplace.c

[David Gibson]

On Tue, Jun 12, 2012 at 02:48:12PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> When compiling the current code-base with gcc 4.6.1, the following warning
> is raised, which is interpreted as an error:
> 
> cc1: warnings being treated as errors
> tests/setprop_inplace.c: In function ‘main’:
> tests/setprop_inplace.c:62: error: format ‘%016llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘uint64_t’
> tests/setprop_inplace.c:68: error: format ‘%016llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘uint64_t’
> 
> Use printf format specifiers from <inttypes.h> to solve this.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

Acked-by: David Gibson <david@gibson.dropbear.id.au>

Thanks.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] Fix compilation warning/error in setprop_inplace.c

[David Gibson]

On Wed, Jun 13, 2012 at 12:31:52PM +1000, David Gibson wrote:
> On Tue, Jun 12, 2012 at 02:48:12PM -0600, Stephen Warren wrote:
> > From: Stephen Warren <swarren@nvidia.com>
> > 
> > When compiling the current code-base with gcc 4.6.1, the following warning
> > is raised, which is interpreted as an error:
> > 
> > cc1: warnings being treated as errors
> > tests/setprop_inplace.c: In function ‘main’:
> > tests/setprop_inplace.c:62: error: format ‘%016llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘uint64_t’
> > tests/setprop_inplace.c:68: error: format ‘%016llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘uint64_t’
> > 
> > Use printf format specifiers from <inttypes.h> to solve this.
> > 
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
> 
> Acked-by: David Gibson <david@gibson.dropbear.id.au>

Jon?

Please apply...


-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] Fix compilation warning/error in setprop_inplace.c

[Jon Loeliger]

> On Wed, Jun 13, 2012 at 12:31:52PM +1000, David Gibson wrote:
> > On Tue, Jun 12, 2012 at 02:48:12PM -0600, Stephen Warren wrote:
> > > From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> > >=20
> > > When compiling the current code-base with gcc 4.6.1, the following wa=
> rning
> > > is raised, which is interpreted as an error:
> > >=20
> > > cc1: warnings being treated as errors
> > > tests/setprop_inplace.c: In function =E2=80=98main=E2=80=99:
> > > tests/setprop_inplace.c:62: error: format =E2=80=98%016llx=E2=80=99 e=
> xpects type =E2=80=98long long unsigned int=E2=80=99, but argument 2 has =
> type =E2=80=98uint64_t=E2=80=99
> > > tests/setprop_inplace.c:68: error: format =E2=80=98%016llx=E2=80=99 e=
> xpects type =E2=80=98long long unsigned int=E2=80=99, but argument 2 has =
> type =E2=80=98uint64_t=E2=80=99
> > >=20
> > > Use printf format specifiers from <inttypes.h> to solve this.
> > >=20
> > > Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >=20
> > Acked-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
> 
> Jon?
> 
> Please apply...

Applied and pushed out.

Sorry,
jdl