From: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH V3] dtc: fix for_each_*() to skip first object if deleted
Date: Mon, 08 Oct 2012 09:13:15 -0500 [thread overview]
Message-ID: <E1TLE55-0001yX-Fp@jdl.com> (raw)
In-Reply-To: <20121005232948.GW29302-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
> On Fri, Oct 05, 2012 at 09:57:41AM -0600, Stephen Warren wrote:
> > From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >
> > The previous definition of for_each_*() would always include the very
> > first object within the list, irrespective of whether it was marked
> > deleted, since the deleted flag was not checked on the first object,
> > but only on any "next" object.
> >
> > Fix for_each_*() to check the deleted flag in the loop body every
> > iteration to correct this.
> >
> > Incidentally, this change is why commit 45013d8 dtc: "Add ability to
> > delete nodes and properties" only caused two "make checkm" failures;
> > only two tests actually use multiple labels on the same property or
> > node. With this current change applied, but commit 317a5d9 "dtc: zero
> > out new label objects" reverted, "make checkm" fails 29 times; i.e.
> > for every test that uses any labels at all.
> >
> > Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Acked-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Applied.
Thanks,
jdl
prev parent reply other threads:[~2012-10-08 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 15:57 [PATCH V3] dtc: fix for_each_*() to skip first object if deleted Stephen Warren
[not found] ` <1349452661-14445-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-05 23:29 ` David Gibson
[not found] ` <20121005232948.GW29302-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-10-08 14:13 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1TLE55-0001yX-Fp@jdl.com \
--to=jdl-cyomk+44s/e@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.