* [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
@ 2014-10-19 15:14 Thomas Meyer
2014-10-20 7:15 ` Geert Uytterhoeven
2014-10-20 9:28 ` Daniel Walter
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Meyer @ 2014-10-19 15:14 UTC (permalink / raw)
To: user-mode-linux-devel
Add TRACE_IRQFLAGS_SUPPORT to UML.
This enables LOCKDEP_SUPPORT and TRACING_SUPPORT.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common
index 87bc868..6a33c3a 100644
--- a/arch/um/Kconfig.common
+++ b/arch/um/Kconfig.common
@@ -28,10 +28,9 @@ config PCI
config PCMCIA
bool
-# Yet to do!
config TRACE_IRQFLAGS_SUPPORT
bool
- default n
+ default y
config LOCKDEP_SUPPORT
bool
diff --git a/arch/um/include/asm/irqflags.h b/arch/um/include/asm/irqflags.h
index c780d8a..c5b636e 100644
--- a/arch/um/include/asm/irqflags.h
+++ b/arch/um/include/asm/irqflags.h
@@ -34,9 +34,9 @@ static inline unsigned long arch_local_irq_save(void)
return flags;
}
-static inline bool arch_irqs_disabled(void)
+static inline int arch_irqs_disabled_flags(unsigned long flags)
{
- return arch_local_save_flags() == 0;
+ return flags == 0;
}
#endif
diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
index f1efeee..fc188d8 100644
--- a/arch/um/kernel/um_arch.c
+++ b/arch/um/kernel/um_arch.c
@@ -251,6 +251,9 @@ static struct notifier_block panic_exit_notifier = {
void uml_finishsetup(void)
{
+#ifdef CONFIG_LOCKDEP
+ lockdep_init();
+#endif
atomic_notifier_chain_register(&panic_notifier_list,
&panic_exit_notifier);
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
2014-10-19 15:14 Thomas Meyer
@ 2014-10-20 7:15 ` Geert Uytterhoeven
2014-10-20 9:28 ` Daniel Walter
1 sibling, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2014-10-20 7:15 UTC (permalink / raw)
To: Thomas Meyer; +Cc: user-mode-linux-devel
On Sun, Oct 19, 2014 at 5:14 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
> --- a/arch/um/kernel/um_arch.c
> +++ b/arch/um/kernel/um_arch.c
> @@ -251,6 +251,9 @@ static struct notifier_block panic_exit_notifier = {
>
> void uml_finishsetup(void)
> {
> +#ifdef CONFIG_LOCKDEP
> + lockdep_init();
> +#endif
The #ifdef is not needed. include/linux/lockdep.h provides a dummy
definition if !CONFIG_LOCKDEP.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
2014-10-19 15:14 Thomas Meyer
2014-10-20 7:15 ` Geert Uytterhoeven
@ 2014-10-20 9:28 ` Daniel Walter
1 sibling, 0 replies; 6+ messages in thread
From: Daniel Walter @ 2014-10-20 9:28 UTC (permalink / raw)
To: Thomas Meyer; +Cc: user-mode-linux-devel
----- Original Message -----
> From: "Thomas Meyer" <thomas@m3y3r.de>
> To: "user-mode-linux-devel" <user-mode-linux-devel@lists.sourceforge.net>
> Sent: Sunday, October 19, 2014 4:14:13 PM
> Subject: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
>
> Add TRACE_IRQFLAGS_SUPPORT to UML.
> This enables LOCKDEP_SUPPORT and TRACING_SUPPORT.
FYI: I'm currently working on porting ftrace() support to
uml. It will take another week or two since I don't have enough
time to debug, and it isn't stable yet (read as is panic()ing randomly)
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
> diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common
> index 87bc868..6a33c3a 100644
> --- a/arch/um/Kconfig.common
> +++ b/arch/um/Kconfig.common
> @@ -28,10 +28,9 @@ config PCI
> config PCMCIA
> bool
>
> -# Yet to do!
> config TRACE_IRQFLAGS_SUPPORT
> bool
> - default n
> + default y
>
> config LOCKDEP_SUPPORT
> bool
> diff --git a/arch/um/include/asm/irqflags.h
> b/arch/um/include/asm/irqflags.h
> index c780d8a..c5b636e 100644
> --- a/arch/um/include/asm/irqflags.h
> +++ b/arch/um/include/asm/irqflags.h
> @@ -34,9 +34,9 @@ static inline unsigned long
> arch_local_irq_save(void)
> return flags;
> }
>
> -static inline bool arch_irqs_disabled(void)
> +static inline int arch_irqs_disabled_flags(unsigned long flags)
> {
> - return arch_local_save_flags() == 0;
> + return flags == 0;
> }
>
> #endif
I'm not sure if this is correct. I'd rather would have another function
implemented instead of removing the check for disabled irqs.
cheers,
daniel
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
@ 2014-10-20 11:18 Thomas Meyer
2014-10-20 12:13 ` Richard Weinberger
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Meyer @ 2014-10-20 11:18 UTC (permalink / raw)
To: Daniel Walter; +Cc: user-mode-linux-devel
Am 20.10.2014 11:28 schrieb Daniel Walter <sahne@0x90.at>:
>
> ----- Original Message -----
> > From: "Thomas Meyer" <thomas@m3y3r.de>
> > To: "user-mode-linux-devel" <user-mode-linux-devel@lists.sourceforge.net>
> > Sent: Sunday, October 19, 2014 4:14:13 PM
> > Subject: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
> >
> > Add TRACE_IRQFLAGS_SUPPORT to UML.
> > This enables LOCKDEP_SUPPORT and TRACING_SUPPORT.
>
>
> FYI: I'm currently working on porting ftrace() support to
> uml. It will take another week or two since I don't have enough
> time to debug, and it isn't stable yet (read as is panic()ing randomly)
Good to know :-)
Thanks for you stack trace support work!
BTW. When triggering a sysrq t with the uml console the stack trace is not displayed, it says that the stack trace failed because a sigsegv happens in the stack trace or something like that. Bug or feature?
>
> >
> > Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> > ---
> > diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common
> > index 87bc868..6a33c3a 100644
> > --- a/arch/um/Kconfig.common
> > +++ b/arch/um/Kconfig.common
> > @@ -28,10 +28,9 @@ config PCI
> > config PCMCIA
> > bool
> >
> > -# Yet to do!
> > config TRACE_IRQFLAGS_SUPPORT
> > bool
> > - default n
> > + default y
> >
> > config LOCKDEP_SUPPORT
> > bool
> > diff --git a/arch/um/include/asm/irqflags.h
> > b/arch/um/include/asm/irqflags.h
> > index c780d8a..c5b636e 100644
> > --- a/arch/um/include/asm/irqflags.h
> > +++ b/arch/um/include/asm/irqflags.h
> > @@ -34,9 +34,9 @@ static inline unsigned long
> > arch_local_irq_save(void)
> > return flags;
> > }
> >
> > -static inline bool arch_irqs_disabled(void)
> > +static inline int arch_irqs_disabled_flags(unsigned long flags)
> > {
> > - return arch_local_save_flags() == 0;
> > + return flags == 0;
> > }
> >
> > #endif
>
> I'm not sure if this is correct. I'd rather would have another function
> implemented instead of removing the check for disabled irqs.
There is a default coding for arch_irqs_disabled which calls arch_irqs_disabled_flags.
The logic after above change should be the same as before.
>
>
> cheers,
>
> daniel
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
2014-10-20 11:18 [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support Thomas Meyer
@ 2014-10-20 12:13 ` Richard Weinberger
2014-10-20 16:14 ` Thomas Meyer
0 siblings, 1 reply; 6+ messages in thread
From: Richard Weinberger @ 2014-10-20 12:13 UTC (permalink / raw)
To: Thomas Meyer; +Cc: Daniel Walter, user-mode-linux-devel
On Mon, Oct 20, 2014 at 1:18 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
> Am 20.10.2014 11:28 schrieb Daniel Walter <sahne@0x90.at>:
>>
>> ----- Original Message -----
>> > From: "Thomas Meyer" <thomas@m3y3r.de>
>> > To: "user-mode-linux-devel" <user-mode-linux-devel@lists.sourceforge.net>
>> > Sent: Sunday, October 19, 2014 4:14:13 PM
>> > Subject: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
>> >
>> > Add TRACE_IRQFLAGS_SUPPORT to UML.
>> > This enables LOCKDEP_SUPPORT and TRACING_SUPPORT.
>>
>>
>> FYI: I'm currently working on porting ftrace() support to
>> uml. It will take another week or two since I don't have enough
>> time to debug, and it isn't stable yet (read as is panic()ing randomly)
>
> Good to know :-)
>
> Thanks for you stack trace support work!
>
> BTW. When triggering a sysrq t with the uml console the stack trace is not displayed, it says that the stack trace failed because a sigsegv happens in the stack trace or something like that. Bug or feature?
Huh? More details please. uml_mconsole's sysrq t works fine here with
both x86 and x86_86 uml.
--
Thanks,
//richard
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
2014-10-20 12:13 ` Richard Weinberger
@ 2014-10-20 16:14 ` Thomas Meyer
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Meyer @ 2014-10-20 16:14 UTC (permalink / raw)
To: Richard Weinberger; +Cc: Daniel Walter, user-mode-linux-devel
Am 20.10.2014 um 14:13 schrieb Richard Weinberger:
> On Mon, Oct 20, 2014 at 1:18 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
>> Am 20.10.2014 11:28 schrieb Daniel Walter <sahne@0x90.at>:
>>>
>>> ----- Original Message -----
>>>> From: "Thomas Meyer" <thomas@m3y3r.de>
>>>> To: "user-mode-linux-devel" <user-mode-linux-devel@lists.sourceforge.net>
>>>> Sent: Sunday, October 19, 2014 4:14:13 PM
>>>> Subject: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
>>>>
>>>> Add TRACE_IRQFLAGS_SUPPORT to UML.
>>>> This enables LOCKDEP_SUPPORT and TRACING_SUPPORT.
>>>
>>>
>>> FYI: I'm currently working on porting ftrace() support to
>>> uml. It will take another week or two since I don't have enough
>>> time to debug, and it isn't stable yet (read as is panic()ing randomly)
>>
>> Good to know :-)
>>
>> Thanks for you stack trace support work!
>>
>> BTW. When triggering a sysrq t with the uml console the stack trace is not displayed, it says that the stack trace failed because a sigsegv happens in the stack trace or something like that. Bug or feature?
>
> Huh? More details please. uml_mconsole's sysrq t works fine here with
> both x86 and x86_86 uml.
Hi,
sorry about the fuss. everything seems to work correctly.
Maybe I did see this while doing some testing with some fixes.
sorry.
>
> --
> Thanks,
> //richard
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-20 16:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-20 11:18 [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support Thomas Meyer
2014-10-20 12:13 ` Richard Weinberger
2014-10-20 16:14 ` Thomas Meyer
-- strict thread matches above, loose matches on Subject: below --
2014-10-19 15:14 Thomas Meyer
2014-10-20 7:15 ` Geert Uytterhoeven
2014-10-20 9:28 ` Daniel Walter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.