[PATCH][Bugfix] debian/grub.d/05_debian_theme: quote background image pathname in output

[PATCH][Bugfix] debian/grub.d/05_debian_theme: quote background image pathname in output

[Pascal Hambourg]

This is required if the pathname contains spaces or grub shell
metacharacters, else the generated config file check will fail.

Signed-off-by: Pascal Hambourg <pascal@plouf.fr.eu.org>
---
 util/grub.d/00_header.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/grub.d/00_header.in b/util/grub.d/00_header.in
index 6a316a5ba..f86b69bad 100644
--- a/util/grub.d/00_header.in
+++ b/util/grub.d/00_header.in
@@ -275,7 +275,7 @@ EOF
 	prepare_grub_to_access_device `${grub_probe} --target=device "$GRUB_BACKGROUND"`
 	cat << EOF
 insmod $reader
-background_image -m stretch `make_system_path_relative_to_its_root "$GRUB_BACKGROUND"`
+background_image -m stretch "`make_system_path_relative_to_its_root "$GRUB_BACKGROUND"`"
 EOF
     fi
 fi
-- 
2.39.2


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v2][Bugfix] util/grub.d/00_header.in: quote background image pathname in output

[Pascal Hambourg]

This is required if the pathname contains spaces or grub shell
metacharacters, else the generated config file check will fail.

Signed-off-by: Pascal Hambourg <pascal@plouf.fr.eu.org>
---
v2: Correct subject

 util/grub.d/00_header.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/grub.d/00_header.in b/util/grub.d/00_header.in
index 6a316a5ba..f86b69bad 100644
--- a/util/grub.d/00_header.in
+++ b/util/grub.d/00_header.in
@@ -275,7 +275,7 @@ EOF
 	prepare_grub_to_access_device `${grub_probe} --target=device "$GRUB_BACKGROUND"`
 	cat << EOF
 insmod $reader
-background_image -m stretch `make_system_path_relative_to_its_root "$GRUB_BACKGROUND"`
+background_image -m stretch "`make_system_path_relative_to_its_root "$GRUB_BACKGROUND"`"
 EOF
     fi
 fi
-- 
2.39.2


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2][Bugfix] util/grub.d/00_header.in: quote background image pathname in output

[Daniel Kiper]

On Sun, May 19, 2024 at 05:50:10PM +0200, Pascal Hambourg wrote:
> This is required if the pathname contains spaces or grub shell
> metacharacters, else the generated config file check will fail.
>
> Signed-off-by: Pascal Hambourg <pascal@plouf.fr.eu.org>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel