From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Alexei Starovoitov <ast@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
bpf@vger.kernel.org, Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org,
Paolo Abeni <pabeni@redhat.com>,
Stanislav Fomichev <sdf@fomichev.me>
Subject: [PATCH net-next 05/15] net: stmmac: add helper to get size of a receive descriptor
Date: Wed, 11 Mar 2026 09:52:29 +0000 [thread overview]
Message-ID: <E1w0GEv-0000000CiT1-3c8e@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <abE7LWj04-JNxgS2@shell.armlinux.org.uk>
Add and use a helper to get the size of the hardware receive
descriptor.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 24 +++++++++----------
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index a3dfd3501604..dca62e7b259a 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -362,6 +362,14 @@ static inline u32 stmmac_tx_avail(struct stmmac_priv *priv, u32 queue)
priv->dma_conf.dma_tx_size);
}
+static size_t stmmac_get_rx_desc_size(struct stmmac_priv *priv)
+{
+ if (priv->extend_desc)
+ return sizeof(struct dma_extended_desc);
+ else
+ return sizeof(struct dma_desc);
+}
+
static struct dma_desc *stmmac_get_rx_desc(struct stmmac_priv *priv,
struct stmmac_rx_queue *rx_q,
unsigned int index)
@@ -1432,10 +1440,7 @@ static void stmmac_display_rx_rings(struct stmmac_priv *priv,
pr_info("\tRX Queue %u rings\n", queue);
head_rx = stmmac_get_rx_desc(priv, rx_q, 0);
- if (priv->extend_desc)
- desc_size = sizeof(struct dma_extended_desc);
- else
- desc_size = sizeof(struct dma_desc);
+ desc_size = stmmac_get_rx_desc_size(priv);
/* Display RX ring */
stmmac_display_ring(priv, head_rx, dma_conf->dma_rx_size, true,
@@ -5412,11 +5417,7 @@ static int stmmac_rx_zc(struct stmmac_priv *priv, int limit, u32 queue)
void *rx_head = stmmac_get_rx_desc(priv, rx_q, 0);
netdev_dbg(priv->dev, "%s: descriptor ring:\n", __func__);
- if (priv->extend_desc) {
- desc_size = sizeof(struct dma_extended_desc);
- } else {
- desc_size = sizeof(struct dma_desc);
- }
+ desc_size = stmmac_get_rx_desc_size(priv);
stmmac_display_ring(priv, rx_head, priv->dma_conf.dma_rx_size, true,
rx_q->dma_rx_phy, desc_size);
@@ -5604,10 +5605,7 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
void *rx_head = stmmac_get_rx_desc(priv, rx_q, 0);
netdev_dbg(priv->dev, "%s: descriptor ring:\n", __func__);
- if (priv->extend_desc)
- desc_size = sizeof(struct dma_extended_desc);
- else
- desc_size = sizeof(struct dma_desc);
+ desc_size = stmmac_get_rx_desc_size(priv);
stmmac_display_ring(priv, rx_head, priv->dma_conf.dma_rx_size, true,
rx_q->dma_rx_phy, desc_size);
--
2.47.3
next prev parent reply other threads:[~2026-03-11 9:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 9:51 [PATCH net-next 00/15] net: stmmac: clean up descriptor handling part 1 Russell King (Oracle)
2026-03-11 9:52 ` [PATCH net-next 01/15] net: stmmac: rearrange stmmac_tx_info members to pack better Russell King (Oracle)
2026-03-11 9:52 ` [PATCH net-next 02/15] net: stmmac: helpers for filling tx_q->tx_skbuff_dma Russell King (Oracle)
2026-03-11 14:57 ` Andrew Lunn
2026-03-11 14:59 ` Russell King (Oracle)
2026-03-12 8:54 ` Russell King (Oracle)
2026-03-11 9:52 ` [PATCH net-next 03/15] net: stmmac: clean up stmmac_clear_rx_descriptors() Russell King (Oracle)
2026-03-11 9:52 ` [PATCH net-next 04/15] net: stmmac: add helper to get hardware receive descriptor Russell King (Oracle)
2026-03-11 9:52 ` Russell King (Oracle) [this message]
2026-03-11 9:52 ` [PATCH net-next 06/15] net: stmmac: add helper to set receive tail pointer Russell King (Oracle)
2026-03-11 9:52 ` [PATCH net-next 07/15] net: stmmac: remove rx_tail_addr Russell King (Oracle)
2026-03-11 9:52 ` [PATCH net-next 08/15] net: stmmac: use consistent tests for receive buffer size Russell King (Oracle)
2026-03-11 9:52 ` [PATCH net-next 09/15] net: stmmac: add helper to set " Russell King (Oracle)
2026-03-11 9:52 ` [PATCH net-next 10/15] net: stmmac: simplify stmmac_set_queue_rx_buf_size() Russell King (Oracle)
2026-03-11 9:53 ` [PATCH net-next 11/15] net: stmmac: add helper to get hardware transmit descriptor Russell King (Oracle)
2026-03-11 9:53 ` [PATCH net-next 12/15] net: stmmac: add helper to get size of a " Russell King (Oracle)
2026-03-11 9:53 ` [PATCH net-next 13/15] net: stmmac: add helper to set transmit tail pointer Russell King (Oracle)
2026-03-11 9:53 ` [PATCH net-next 14/15] net: stmmac: remove tx_tail_addr Russell King (Oracle)
2026-03-11 9:53 ` [PATCH net-next 15/15] net: stmmac: use queue rather than ->queue_index Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1w0GEv-0000000CiT1-3c8e@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.