From: Kainoa <kainoa@t1c.dev>
To: harry.wentland@amd.com
Cc: Kaitlyn.Tse@amd.com, amd-gfx@lists.freedesktop.org,
daniel.wheeler@amd.com, luke@ljones.dev,
mario.limonciello@amd.com, nicholas.kazlauskas@amd.com,
regressions@lists.linux.dev, superm1@kernel.org,
zaeem.mohamed@amd.com
Subject: Re: [PATCH] drm/amd/display: Fix programming backlight on OLED panels
Date: Wed, 04 Dec 2024 10:13:27 -0800 [thread overview]
Message-ID: <FMEZNS.X49653TQV28U3@t1c.dev> (raw)
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> commit 38077562e0594 ("drm/amd/display: Implement new
> backlight_level_params structure") adjusted DC core to require
> the backlight type to be programmed in the dc link when changing
> brightness. This isn't initialized in amdgpu_dm for OLED panels
> though which broke brightness.
>
> Explicitly initialize when aux support is enabled.
>
> Reported-and-tested-by: Luke Jones <luke@ljones.dev>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3792
> Fixes: 38077562e059 ("drm/amd/display: Implement new
backlight_level_params structure")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Can confirm that this works for me! :)
next reply other threads:[~2024-12-04 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 18:13 Kainoa [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-11-28 3:22 [PATCH] drm/amd/display: Fix programming backlight on OLED panels Mario Limonciello
2024-11-28 16:14 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FMEZNS.X49653TQV28U3@t1c.dev \
--to=kainoa@t1c.dev \
--cc=Kaitlyn.Tse@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel.wheeler@amd.com \
--cc=harry.wentland@amd.com \
--cc=luke@ljones.dev \
--cc=mario.limonciello@amd.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=regressions@lists.linux.dev \
--cc=superm1@kernel.org \
--cc=zaeem.mohamed@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.