* Re: [PATCH] drm/amd/display: Fix programming backlight on OLED panels
@ 2024-12-04 18:13 Kainoa
0 siblings, 0 replies; 3+ messages in thread
From: Kainoa @ 2024-12-04 18:13 UTC (permalink / raw)
To: harry.wentland
Cc: Kaitlyn.Tse, amd-gfx, daniel.wheeler, luke, mario.limonciello,
nicholas.kazlauskas, regressions, superm1, zaeem.mohamed
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> commit 38077562e0594 ("drm/amd/display: Implement new
> backlight_level_params structure") adjusted DC core to require
> the backlight type to be programmed in the dc link when changing
> brightness. This isn't initialized in amdgpu_dm for OLED panels
> though which broke brightness.
>
> Explicitly initialize when aux support is enabled.
>
> Reported-and-tested-by: Luke Jones <luke@ljones.dev>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3792
> Fixes: 38077562e059 ("drm/amd/display: Implement new
backlight_level_params structure")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Can confirm that this works for me! :)
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] drm/amd/display: Fix programming backlight on OLED panels
@ 2024-11-28 3:22 Mario Limonciello
2024-11-28 16:14 ` Harry Wentland
0 siblings, 1 reply; 3+ messages in thread
From: Mario Limonciello @ 2024-11-28 3:22 UTC (permalink / raw)
To: amd-gfx
Cc: Kaitlyn.Tse, nicholas.kazlauskas, zaeem.mohamed, daniel.wheeler,
harry.wentland, regressions, Mario Limonciello, Luke Jones
From: Mario Limonciello <mario.limonciello@amd.com>
commit 38077562e0594 ("drm/amd/display: Implement new
backlight_level_params structure") adjusted DC core to require
the backlight type to be programmed in the dc link when changing
brightness. This isn't initialized in amdgpu_dm for OLED panels
though which broke brightness.
Explicitly initialize when aux support is enabled.
Reported-and-tested-by: Luke Jones <luke@ljones.dev>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3792
Fixes: 38077562e059 ("drm/amd/display: Implement new backlight_level_params structure")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 19a58630e7740..243cee2841312 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -3483,6 +3483,8 @@ static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector)
caps->aux_support = false;
else if (amdgpu_backlight == 1)
caps->aux_support = true;
+ if (caps->aux_support)
+ aconnector->dc_link->backlight_control_type = BACKLIGHT_CONTROL_AMD_AUX;
luminance_range = &conn_base->display_info.luminance_range;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amd/display: Fix programming backlight on OLED panels
2024-11-28 3:22 Mario Limonciello
@ 2024-11-28 16:14 ` Harry Wentland
0 siblings, 0 replies; 3+ messages in thread
From: Harry Wentland @ 2024-11-28 16:14 UTC (permalink / raw)
To: Mario Limonciello, amd-gfx
Cc: Kaitlyn.Tse, nicholas.kazlauskas, zaeem.mohamed, daniel.wheeler,
regressions, Mario Limonciello, Luke Jones
On 2024-11-27 22:22, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> commit 38077562e0594 ("drm/amd/display: Implement new
> backlight_level_params structure") adjusted DC core to require
> the backlight type to be programmed in the dc link when changing
> brightness. This isn't initialized in amdgpu_dm for OLED panels
> though which broke brightness.
>
> Explicitly initialize when aux support is enabled.
>
> Reported-and-tested-by: Luke Jones <luke@ljones.dev>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3792
> Fixes: 38077562e059 ("drm/amd/display: Implement new backlight_level_params structure")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 19a58630e7740..243cee2841312 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -3483,6 +3483,8 @@ static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector)
> caps->aux_support = false;
> else if (amdgpu_backlight == 1)
> caps->aux_support = true;
> + if (caps->aux_support)
> + aconnector->dc_link->backlight_control_type = BACKLIGHT_CONTROL_AMD_AUX;
>
> luminance_range = &conn_base->display_info.luminance_range;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-04 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-04 18:13 [PATCH] drm/amd/display: Fix programming backlight on OLED panels Kainoa
-- strict thread matches above, loose matches on Subject: below --
2024-11-28 3:22 Mario Limonciello
2024-11-28 16:14 ` Harry Wentland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.