[LTP] [PATCH] syscalls/fanotify26: Move from staging to syscalls

[LTP] [PATCH] syscalls/fanotify26: Move from staging to syscalls

[Edvard Conrad via ltp]

The kernel fix the second test case needs, commit c3d355f427ce ("fs:
let backing files inherit FMODE_NONOTIFY from the user file"), was
merged into Linus' tree on 2026-10-30 and will appear in v7.4-rc1.

Move the test out of runtest/staging, and record the fix in a
linux-git tag so that a failure points at the missing kernel commit
rather than at the test.

Signed-off-by: Edvard Conrad <edvard@tuta.io>
---
The follow-up Petr asked for on the fanotify26 thread:
  https://lore.kernel.org/ltp/20261030110233.GA66190@pevik/

The fix is in Linus' tree as of 2026-10-30, but v7.4-rc1 is not tagged
yet, so if you would rather hold this until the rc is out, please do.

Kernel commit:
  https://git.kernel.org/torvalds/c/c3d355f427cea70fbe31b49e21f1915dbf37f2e6

Both test cases pass on a kernel carrying the fix, and the second one
fails without it; that is unchanged by this patch, which only moves the
runtest entry and adds the tag.

 runtest/staging                                 | 1 -
 runtest/syscalls                                | 1 +
 testcases/kernel/syscalls/fanotify/fanotify26.c | 4 ++++
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/runtest/staging b/runtest/staging
index 2ce76b119..ef1cdea15 100644
--- a/runtest/staging
+++ b/runtest/staging
@@ -1,2 +1 @@
 # Tests for features that are not yet in the stable kernel ABI
-fanotify26 fanotify26
diff --git a/runtest/syscalls b/runtest/syscalls
index ff3de1b15..23d3e21ef 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -703,6 +703,7 @@ fanotify22 fanotify22
 fanotify23 fanotify23
 fanotify24 fanotify24
 fanotify25 fanotify25
+fanotify26 fanotify26
 
 ioperm01 ioperm01
 ioperm02 ioperm02
diff --git a/testcases/kernel/syscalls/fanotify/fanotify26.c b/testcases/kernel/syscalls/fanotify/fanotify26.c
index 8741cd560..63d7eea0f 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify26.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify26.c
@@ -192,6 +192,10 @@ static struct tst_test test = {
 	.mount_device = 1,
 	.needs_overlay = 1,
 	.mntpoint = OVL_BASE_MNTPOINT,
+	.tags = (const struct tst_tag[]) {
+		{"linux-git", "c3d355f427cea70fbe31b49e21f1915dbf37f2e6"},
+		{}
+	}
 };
 
 #else
-- 
2.56.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] syscalls/fanotify26: Move from staging to syscalls

[linuxtestproject.agent]

Hi Edvard,

On Sat Oct 31 18:31:21 2026 +0100, Edvard Conrad <edvard@tuta.io> wrote:
> syscalls/fanotify26: Move from staging to syscalls

> diff --git a/runtest/staging b/runtest/staging
> index 2ce76b119..ef1cdea15 100644
> --- a/runtest/staging
> +++ b/runtest/staging
> @@ -1,2 +1 @@
>  # Tests for features that are not yet in the stable kernel ABI
> -fanotify26 fanotify26
> diff --git a/runtest/syscalls b/runtest/syscalls
> index ff3de1b15..23d3e21ef 100644
> --- a/runtest/syscalls
> +++ b/runtest/syscalls
> @@ -703,6 +703,7 @@ fanotify22 fanotify22
>  fanotify23 fanotify23
>  fanotify24 fanotify24
>  fanotify25 fanotify25
> +fanotify26 fanotify26

Kernel commit c3d355f427ce targets v7.4-rc1, while the latest stable
kernel release is v7.3. Tests that depend on kernel changes not yet in a
finalized mainline release must remain in runtest/staging until v7.4 is
released. Keep fanotify26 in runtest/staging until v7.4 is out, or split
the linux-git tag addition into its own patch if needed now.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] syscalls/fanotify26: Move from staging to syscalls

[Amir Goldstein]

On Sat, Oct 31, 2026 at 6:31 PM Edvard Conrad <edvard@tuta.io> wrote:
>
> The kernel fix the second test case needs, commit c3d355f427ce ("fs:
> let backing files inherit FMODE_NONOTIFY from the user file"), was
> merged into Linus' tree on 2026-10-30 and will appear in v7.4-rc1.
>
> Move the test out of runtest/staging, and record the fix in a
> linux-git tag so that a failure points at the missing kernel commit
> rather than at the test.
>
> Signed-off-by: Edvard Conrad <edvard@tuta.io>
> ---
> The follow-up Petr asked for on the fanotify26 thread:
>   https://lore.kernel.org/ltp/20261030110233.GA66190@pevik/
>
> The fix is in Linus' tree as of 2026-10-30, but v7.4-rc1 is not tagged
> yet, so if you would rather hold this until the rc is out, please do.

Not only is rc1 not out yet, but we already have a report on
the dir open bug for which you have added another test case.
So I think it is best wait for the other bug fix to land, hopefully
sometime next week before moving the test out of staging.

On the other hand, Petr, this is not a new feature, it is a real bug fix.
Are we holding off on running tests on newly found bugs
until those bugs are fixed upstream?

Hopefully there is not going to be a large time gap between
bug report and bug fix, so it does not matter much.
I was just wondering about best practice.

Thanks,
Amir.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] syscalls/fanotify26: Move from staging to syscalls

[Edvard Conrad via ltp]

On Sun, Nov 1, 2026 at 5:46 PM Amir Goldstein <amir73il@gmail.com> wrote:
> So I think it is best wait for the other bug fix to land, hopefully
> sometime next week before moving the test out of staging.

Agreed. Petr, please drop this one. Once the directory fix has landed I
will send a single patch that moves fanotify26 to runtest/syscalls with
linux-git tags for both fixes, at whatever point you prefer for the
move.

Thanks,
Edvard

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] syscalls/fanotify26: Move from staging to syscalls

[Cyril Hrubis]

Hi!
> On the other hand, Petr, this is not a new feature, it is a real bug fix.
> Are we holding off on running tests on newly found bugs
> until those bugs are fixed upstream?

I do not think that we need to hold off tests for bugs. The rule we have
has been introduced since newly added kernel ABIs are subject to change
in the rc phases.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] syscalls/fanotify26: Move from staging to syscalls

[Petr Vorel]

Hi all,

> Hi!
> > On the other hand, Petr, this is not a new feature, it is a real bug fix.
> > Are we holding off on running tests on newly found bugs
> > until those bugs are fixed upstream?

> I do not think that we need to hold off tests for bugs. The rule we have
> has been introduced since newly added kernel ABIs are subject to change
> in the rc phases.

Yes that's true, this is a different case. Anyway, if all distro users test with
LTP releases (they are using master branch), I'm ok to merge before fix is
merged and it's hash added to the test.

We are using LTP master branch for testing SLES in development and openSUSE
Tumbleweed, filtering these errors involves some work, but that's ok.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp