From: kristofferhaugsbakk@fastmail.com
To: Junio C Hamano <gitster@pobox.com>
Cc: Kristoffer Haugsbakk <code@khaugsbakk.name>,
Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org
Subject: [PATCH v2 1/2] *: replace deprecated free_commit_list
Date: Thu, 28 May 2026 09:00:10 +0200 [thread overview]
Message-ID: <V2_commit.h_replace_deprecated.733@msgid.xyz> (raw)
In-Reply-To: <V2_CV_commit.h_remove_deprecated.732@msgid.xyz>
From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Replace `free_commit_list` with `commit_list_free`. The former was
deprecated in 9f18d089 (commit: rename `free_commit_list()` to conform
to coding guidelines, 2026-01-15).
This allows us to remove all the deprecated functions in the
next commit:
• `copy_commit_list`
• `reverse_commit_list`
• `free_commit_list`
Acked-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
---
Notes (series):
v2: add ack
builtin/history.c | 4 ++--
replay.c | 2 +-
upload-pack.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/builtin/history.c b/builtin/history.c
index 0fc06fb2045..091465a59e2 100644
--- a/builtin/history.c
+++ b/builtin/history.c
@@ -284,7 +284,7 @@ static int setup_revwalk(struct repository *repo,
commit_list_insert(original, &from_list);
ret = repo_is_descendant_of(repo, head, from_list);
- free_commit_list(from_list);
+ commit_list_free(from_list);
if (ret < 0) {
ret = error(_("cannot determine descendance"));
@@ -892,7 +892,7 @@ static int split_commit(struct repository *repo,
if (index_file.len)
unlink(index_file.buf);
strbuf_release(&index_file);
- free_commit_list(parents);
+ commit_list_free(parents);
release_index(&index);
return ret;
}
diff --git a/replay.c b/replay.c
index 4ef8abb6077..da531d5bc68 100644
--- a/replay.c
+++ b/replay.c
@@ -120,7 +120,7 @@ static struct commit *create_commit(struct repository *repo,
out:
repo_unuse_commit_buffer(repo, based_on, message);
free_commit_extra_headers(extra);
- free_commit_list(parents);
+ commit_list_free(parents);
strbuf_release(&msg);
free(author);
return (struct commit *)obj;
diff --git a/upload-pack.c b/upload-pack.c
index 9f6d6fe48c8..2bf450ab288 100644
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -886,7 +886,7 @@ static void deepen(struct upload_pack_data *data, int depth)
data->deepen_relative, depth,
SHALLOW, NOT_SHALLOW);
send_shallow(data, result);
- free_commit_list(result);
+ commit_list_free(result);
}
send_unshallow(data);
@@ -900,7 +900,7 @@ static void deepen_by_rev_list(struct upload_pack_data *data,
disable_commit_graph(the_repository);
result = get_shallow_commits_by_rev_list(argv, SHALLOW, NOT_SHALLOW);
send_shallow(data, result);
- free_commit_list(result);
+ commit_list_free(result);
send_unshallow(data);
}
--
2.54.0.16.g8f27b399cbe
next prev parent reply other threads:[~2026-05-28 7:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 13:59 [PATCH 0/2] commit: remove deprecated functions kristofferhaugsbakk
2026-05-27 13:59 ` [PATCH 1/2] *: replace deprecated free_commit_list kristofferhaugsbakk
2026-05-28 5:24 ` Patrick Steinhardt
2026-05-28 6:49 ` Kristoffer Haugsbakk
2026-05-27 13:59 ` [PATCH 2/2] commit: remove deprecated functions kristofferhaugsbakk
2026-05-28 5:24 ` Patrick Steinhardt
2026-05-28 7:00 ` [PATCH v2 0/2] " kristofferhaugsbakk
2026-05-28 7:00 ` kristofferhaugsbakk [this message]
2026-05-28 7:00 ` [PATCH v2 2/2] " kristofferhaugsbakk
2026-05-29 8:37 ` [PATCH v2 0/2] " Jeff King
2026-06-01 5:58 ` Patrick Steinhardt
2026-06-01 7:14 ` Junio C Hamano
2026-06-02 6:23 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=V2_commit.h_replace_deprecated.733@msgid.xyz \
--to=kristofferhaugsbakk@fastmail.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.