All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: kristofferhaugsbakk@fastmail.com
Cc: git@vger.kernel.org, Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: Re: [PATCH 1/2] *: replace deprecated free_commit_list
Date: Thu, 28 May 2026 07:24:04 +0200	[thread overview]
Message-ID: <ahfRdFXJf9SRaz5q@pks.im> (raw)
In-Reply-To: <commit.h_replace_deprecated.715@msgid.xyz>

On Wed, May 27, 2026 at 03:59:25PM +0200, kristofferhaugsbakk@fastmail.com wrote:
> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
> 
> Replace `free_commit_list` with `commit_list_free`. The former was
> deprecated in 9f18d089 (commit: rename `free_commit_list()` to conform
> to coding guidelines, 2026-01-15).
> 
> This allows us to remove all the deprecated functions in the
> next commit:
> 
> • `copy_commit_list`
> • `reverse_commit_list`
> • `free_commit_list`
> 
> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
> ---
>  builtin/history.c | 4 ++--
>  replay.c          | 2 +-
>  upload-pack.c     | 4 ++--
>  3 files changed, 5 insertions(+), 5 deletions(-)

Heh. Funny to see that I introduced the new functions, and that I was
also the one that continued using the old ones most :)

Patrick

  reply	other threads:[~2026-05-28  5:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27 13:59 [PATCH 0/2] commit: remove deprecated functions kristofferhaugsbakk
2026-05-27 13:59 ` [PATCH 1/2] *: replace deprecated free_commit_list kristofferhaugsbakk
2026-05-28  5:24   ` Patrick Steinhardt [this message]
2026-05-28  6:49     ` Kristoffer Haugsbakk
2026-05-27 13:59 ` [PATCH 2/2] commit: remove deprecated functions kristofferhaugsbakk
2026-05-28  5:24   ` Patrick Steinhardt
2026-05-28  7:00 ` [PATCH v2 0/2] " kristofferhaugsbakk
2026-05-28  7:00   ` [PATCH v2 1/2] *: replace deprecated free_commit_list kristofferhaugsbakk
2026-05-28  7:00   ` [PATCH v2 2/2] commit: remove deprecated functions kristofferhaugsbakk
2026-05-29  8:37   ` [PATCH v2 0/2] " Jeff King
2026-06-01  5:58     ` Patrick Steinhardt
2026-06-01  7:14     ` Junio C Hamano
2026-06-02  6:23       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahfRdFXJf9SRaz5q@pks.im \
    --to=ps@pks.im \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.