All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steve Magnani" <steve@digidescorp.com>
To: "KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>
Cc: balbir@linux.vnet.ibm.com, linux-mm@kvack.org,
	dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] nommu: add anonymous page memcg accounting
Date: Wed, 20 Oct 2010 21:35:16 -0500	[thread overview]
Message-ID: <WC20101021023516.32042E@digidescorp.com> (raw)
In-Reply-To: <20101021090847.b4e23dde.kamezawa.hiroyu@jp.fujitsu.com>

On Thu, 2010-10-21 at 09:08 +0900, KAMEZAWA Hiroyuki wrote:
> I myself can't maintain NOMMU kernel. So, please test every -rc1 when
> this patch merged. OK ?

It's reasonable to ask that features be tested every so often, and since the memory cgroup code seems to be 
changing relatively frequently it probably needs exercising more often. I can't commit to this, though - I 
don't know how much longer I'll be working with NOMMU kernels, and they are notoriously fragile. Any memory 
access bug that would cause an oops (or SEGV) in a "normal" kernel can cause subtle and almost impossible to 
debug behavior on a NOMMU system. For this reason I always try to work with "stable" kernels (recent threads 
debating the term notwithstanding)...so it would be a pretty far jump to a -rc1 kernel.

Is this a showstopper (in which case David's patch to make the CGROUP_MEM_RES_CTLR Kconfig option depend on MMU 
should be implemented), or should I post V3 of the patch that has Balbir's suggested change? 

Steve



WARNING: multiple messages have this Message-ID (diff)
From: "Steve Magnani" <steve@digidescorp.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: balbir@linux.vnet.ibm.com, linux-mm@kvack.org,
	dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] nommu: add anonymous page memcg accounting
Date: Wed, 20 Oct 2010 21:35:16 -0500	[thread overview]
Message-ID: <WC20101021023516.32042E@digidescorp.com> (raw)
In-Reply-To: <20101021090847.b4e23dde.kamezawa.hiroyu@jp.fujitsu.com>

On Thu, 2010-10-21 at 09:08 +0900, KAMEZAWA Hiroyuki wrote:
> I myself can't maintain NOMMU kernel. So, please test every -rc1 when
> this patch merged. OK ?

It's reasonable to ask that features be tested every so often, and since the memory cgroup code seems to be 
changing relatively frequently it probably needs exercising more often. I can't commit to this, though - I 
don't know how much longer I'll be working with NOMMU kernels, and they are notoriously fragile. Any memory 
access bug that would cause an oops (or SEGV) in a "normal" kernel can cause subtle and almost impossible to 
debug behavior on a NOMMU system. For this reason I always try to work with "stable" kernels (recent threads 
debating the term notwithstanding)...so it would be a pretty far jump to a -rc1 kernel.

Is this a showstopper (in which case David's patch to make the CGROUP_MEM_RES_CTLR Kconfig option depend on MMU 
should be implemented), or should I post V3 of the patch that has Balbir's suggested change? 

Steve


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-10-21  2:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19 12:34 [PATCH V2] nommu: add anonymous page memcg accounting Steven J. Magnani
2010-10-19 12:34 ` Steven J. Magnani
2010-10-19 15:48 ` Balbir Singh
2010-10-19 15:48   ` Balbir Singh
2010-10-19 18:24   ` Steven J. Magnani
2010-10-19 18:24     ` Steven J. Magnani
2010-10-20  0:17     ` KAMEZAWA Hiroyuki
2010-10-20  0:17       ` KAMEZAWA Hiroyuki
2010-10-20 12:49       ` Steven J. Magnani
2010-10-20 12:49         ` Steven J. Magnani
2010-10-21  0:08         ` KAMEZAWA Hiroyuki
2010-10-21  0:08           ` KAMEZAWA Hiroyuki
2010-10-21  2:35           ` Steve Magnani [this message]
2010-10-21  2:35             ` Steve Magnani
2010-10-21  2:42             ` KAMEZAWA Hiroyuki
2010-10-21  2:42               ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=WC20101021023516.32042E@digidescorp.com \
    --to=steve@digidescorp.com \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=dhowells@redhat.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.