From: Paul Cercueil <paul@crapouillou.net>
To: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
tiwai@suse.com, broonie@kernel.org
Subject: Re: [PATCH 01/11] ASoC: jz4740-i2s: Remove Open Firmware dependency
Date: Thu, 07 Jul 2022 10:16:44 +0100 [thread overview]
Message-ID: <WF8NER.2XOF3ZGKDQYB3@crapouillou.net> (raw)
In-Reply-To: <20220706211330.120198-2-aidanmacdonald.0x0@gmail.com>
Hi Aidan,
Le mer., juil. 6 2022 at 22:13:20 +0100, Aidan MacDonald
<aidanmacdonald.0x0@gmail.com> a écrit :
> This driver doesn't require Open Firmware support. Remove the
> OF-specific includes and drop the Kconfig dependency.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Acked-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
> sound/soc/jz4740/Kconfig | 2 +-
> sound/soc/jz4740/jz4740-i2s.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/jz4740/Kconfig b/sound/soc/jz4740/Kconfig
> index 29144720cb62..e72f826062e9 100644
> --- a/sound/soc/jz4740/Kconfig
> +++ b/sound/soc/jz4740/Kconfig
> @@ -2,7 +2,7 @@
> config SND_JZ4740_SOC_I2S
> tristate "SoC Audio (I2S protocol) for Ingenic JZ4740 SoC"
> depends on MIPS || COMPILE_TEST
> - depends on OF && HAS_IOMEM
> + depends on HAS_IOMEM
> select SND_SOC_GENERIC_DMAENGINE_PCM
> help
> Say Y if you want to use I2S protocol and I2S codec on Ingenic
> JZ4740
> diff --git a/sound/soc/jz4740/jz4740-i2s.c
> b/sound/soc/jz4740/jz4740-i2s.c
> index 79afac0c5003..298ff0a83931 100644
> --- a/sound/soc/jz4740/jz4740-i2s.c
> +++ b/sound/soc/jz4740/jz4740-i2s.c
> @@ -5,10 +5,9 @@
>
> #include <linux/init.h>
> #include <linux/io.h>
> -#include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
>
> --
> 2.35.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net>
To: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, linux-mips@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] ASoC: jz4740-i2s: Remove Open Firmware dependency
Date: Thu, 07 Jul 2022 10:16:44 +0100 [thread overview]
Message-ID: <WF8NER.2XOF3ZGKDQYB3@crapouillou.net> (raw)
In-Reply-To: <20220706211330.120198-2-aidanmacdonald.0x0@gmail.com>
Hi Aidan,
Le mer., juil. 6 2022 at 22:13:20 +0100, Aidan MacDonald
<aidanmacdonald.0x0@gmail.com> a écrit :
> This driver doesn't require Open Firmware support. Remove the
> OF-specific includes and drop the Kconfig dependency.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Acked-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
> sound/soc/jz4740/Kconfig | 2 +-
> sound/soc/jz4740/jz4740-i2s.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/jz4740/Kconfig b/sound/soc/jz4740/Kconfig
> index 29144720cb62..e72f826062e9 100644
> --- a/sound/soc/jz4740/Kconfig
> +++ b/sound/soc/jz4740/Kconfig
> @@ -2,7 +2,7 @@
> config SND_JZ4740_SOC_I2S
> tristate "SoC Audio (I2S protocol) for Ingenic JZ4740 SoC"
> depends on MIPS || COMPILE_TEST
> - depends on OF && HAS_IOMEM
> + depends on HAS_IOMEM
> select SND_SOC_GENERIC_DMAENGINE_PCM
> help
> Say Y if you want to use I2S protocol and I2S codec on Ingenic
> JZ4740
> diff --git a/sound/soc/jz4740/jz4740-i2s.c
> b/sound/soc/jz4740/jz4740-i2s.c
> index 79afac0c5003..298ff0a83931 100644
> --- a/sound/soc/jz4740/jz4740-i2s.c
> +++ b/sound/soc/jz4740/jz4740-i2s.c
> @@ -5,10 +5,9 @@
>
> #include <linux/init.h>
> #include <linux/io.h>
> -#include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
>
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-07-07 9:17 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 21:13 [PATCH 00/11] ASoC: cleanups and improvements for jz4740-i2s Aidan MacDonald
2022-07-06 21:13 ` Aidan MacDonald
2022-07-06 21:13 ` [PATCH 01/11] ASoC: jz4740-i2s: Remove Open Firmware dependency Aidan MacDonald
2022-07-06 21:13 ` Aidan MacDonald
2022-07-07 9:16 ` Paul Cercueil [this message]
2022-07-07 9:16 ` Paul Cercueil
2022-07-06 21:13 ` [PATCH 02/11] ASoC: jz4740-i2s: Refactor DMA channel setup Aidan MacDonald
2022-07-06 21:13 ` Aidan MacDonald
2022-07-07 9:30 ` Paul Cercueil
2022-07-07 9:30 ` Paul Cercueil
2022-07-06 21:13 ` [PATCH 03/11] ASoC: jz4740-i2s: Convert to regmap API Aidan MacDonald
2022-07-06 21:13 ` Aidan MacDonald
2022-07-06 21:53 ` Paul Cercueil
2022-07-06 21:53 ` Paul Cercueil
2022-07-07 14:12 ` Aidan MacDonald
2022-07-07 14:12 ` Aidan MacDonald
2022-07-06 21:13 ` [PATCH 04/11] ASoC: jz4740-i2s: Simplify using regmap fields Aidan MacDonald
2022-07-06 21:13 ` Aidan MacDonald
2022-07-07 9:36 ` Paul Cercueil
2022-07-07 9:36 ` Paul Cercueil
2022-07-07 14:13 ` Aidan MacDonald
2022-07-07 14:13 ` Aidan MacDonald
2022-07-06 21:13 ` [PATCH 05/11] ASoC: jz4740-i2s: Remove unused SoC version IDs Aidan MacDonald
2022-07-06 21:13 ` Aidan MacDonald
2022-07-07 9:37 ` Paul Cercueil
2022-07-07 9:37 ` Paul Cercueil
2022-07-06 21:13 ` [PATCH 06/11] ASoC: jz4740-i2s: Use FIELD_PREP() macros in hw_params callback Aidan MacDonald
2022-07-06 21:13 ` Aidan MacDonald
2022-07-07 9:40 ` Paul Cercueil
2022-07-07 9:40 ` Paul Cercueil
2022-07-06 21:13 ` [PATCH 07/11] ASoC: jz4740-i2s: Remove some unused macros Aidan MacDonald
2022-07-06 21:13 ` Aidan MacDonald
2022-07-07 9:42 ` Paul Cercueil
2022-07-07 9:42 ` Paul Cercueil
2022-07-06 21:13 ` [PATCH 08/11] ASoC: jz4740-i2s: Align macro values and sort includes Aidan MacDonald
2022-07-06 21:13 ` Aidan MacDonald
2022-07-07 9:42 ` Paul Cercueil
2022-07-07 9:42 ` Paul Cercueil
2022-07-06 21:13 ` [PATCH 09/11] ASoC: jz4740-i2s: Make the PLL clock name SoC-specific Aidan MacDonald
2022-07-06 21:13 ` Aidan MacDonald
2022-07-07 9:47 ` Paul Cercueil
2022-07-07 9:47 ` Paul Cercueil
2022-07-07 14:24 ` Aidan MacDonald
2022-07-07 14:24 ` Aidan MacDonald
2022-07-06 21:13 ` [PATCH 10/11] ASoC: jz4740-i2s: Support S20_LE and S24_LE sample formats Aidan MacDonald
2022-07-06 21:13 ` Aidan MacDonald
2022-07-07 9:53 ` Paul Cercueil
2022-07-07 9:53 ` Paul Cercueil
2022-07-07 14:25 ` Aidan MacDonald
2022-07-07 14:25 ` Aidan MacDonald
2022-07-06 21:13 ` [PATCH 11/11] ASoC: jz4740-i2s: Support continuous sample rate Aidan MacDonald
2022-07-06 21:13 ` Aidan MacDonald
2022-07-07 9:53 ` Paul Cercueil
2022-07-07 9:53 ` Paul Cercueil
2022-07-07 13:54 ` (subset) [PATCH 00/11] ASoC: cleanups and improvements for jz4740-i2s Mark Brown
2022-07-07 13:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=WF8NER.2XOF3ZGKDQYB3@crapouillou.net \
--to=paul@crapouillou.net \
--cc=aidanmacdonald.0x0@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.