* [PATCH] ext4: Fix wrong list_splice in ext4_fc_cleanup [not found] <CGME20201230094851epcms2p6eeead8cc984379b37b2efd21af90fd1a@epcms2p6> @ 2020-12-30 9:48 ` Daejun Park 2021-01-05 22:10 ` harshad shirwadkar 2021-01-14 3:34 ` Theodore Ts'o 0 siblings, 2 replies; 3+ messages in thread From: Daejun Park @ 2020-12-30 9:48 UTC (permalink / raw) To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org After full/fast commit, entries in staging queue are promoted to main queue. In ext4_fs_cleanup function, it splice to staging queue to staging queue. Signed-off-by: Daejun Park <daejun7.park@samsung.com> --- fs/ext4/fast_commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c index 4fcc21c25e79..5b6bb3ef0f33 100644 --- a/fs/ext4/fast_commit.c +++ b/fs/ext4/fast_commit.c @@ -1268,7 +1268,7 @@ static void ext4_fc_cleanup(journal_t *journal, int full) list_splice_init(&sbi->s_fc_dentry_q[FC_Q_STAGING], &sbi->s_fc_dentry_q[FC_Q_MAIN]); list_splice_init(&sbi->s_fc_q[FC_Q_STAGING], - &sbi->s_fc_q[FC_Q_STAGING]); + &sbi->s_fc_q[FC_Q_MAIN]); ext4_clear_mount_flag(sb, EXT4_MF_FC_COMMITTING); ext4_clear_mount_flag(sb, EXT4_MF_FC_INELIGIBLE); -- 2.25.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: Fix wrong list_splice in ext4_fc_cleanup 2020-12-30 9:48 ` [PATCH] ext4: Fix wrong list_splice in ext4_fc_cleanup Daejun Park @ 2021-01-05 22:10 ` harshad shirwadkar 2021-01-14 3:34 ` Theodore Ts'o 1 sibling, 0 replies; 3+ messages in thread From: harshad shirwadkar @ 2021-01-05 22:10 UTC (permalink / raw) To: daejun7.park Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Thanks, that's a good catch! Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com> On Wed, Dec 30, 2020 at 1:53 AM Daejun Park <daejun7.park@samsung.com> wrote: > > After full/fast commit, entries in staging queue are promoted to main > queue. In ext4_fs_cleanup function, it splice to staging queue to > staging queue. > > Signed-off-by: Daejun Park <daejun7.park@samsung.com> > --- > fs/ext4/fast_commit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c > index 4fcc21c25e79..5b6bb3ef0f33 100644 > --- a/fs/ext4/fast_commit.c > +++ b/fs/ext4/fast_commit.c > @@ -1268,7 +1268,7 @@ static void ext4_fc_cleanup(journal_t *journal, int full) > list_splice_init(&sbi->s_fc_dentry_q[FC_Q_STAGING], > &sbi->s_fc_dentry_q[FC_Q_MAIN]); > list_splice_init(&sbi->s_fc_q[FC_Q_STAGING], > - &sbi->s_fc_q[FC_Q_STAGING]); > + &sbi->s_fc_q[FC_Q_MAIN]); > > ext4_clear_mount_flag(sb, EXT4_MF_FC_COMMITTING); > ext4_clear_mount_flag(sb, EXT4_MF_FC_INELIGIBLE); > -- > 2.25.1 > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: Fix wrong list_splice in ext4_fc_cleanup 2020-12-30 9:48 ` [PATCH] ext4: Fix wrong list_splice in ext4_fc_cleanup Daejun Park 2021-01-05 22:10 ` harshad shirwadkar @ 2021-01-14 3:34 ` Theodore Ts'o 1 sibling, 0 replies; 3+ messages in thread From: Theodore Ts'o @ 2021-01-14 3:34 UTC (permalink / raw) To: Daejun Park Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Dec 30, 2020 at 06:48:51PM +0900, Daejun Park wrote: > After full/fast commit, entries in staging queue are promoted to main > queue. In ext4_fs_cleanup function, it splice to staging queue to > staging queue. > > Signed-off-by: Daejun Park <daejun7.park@samsung.com> Thanks, applied. - Ted ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-14 3:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20201230094851epcms2p6eeead8cc984379b37b2efd21af90fd1a@epcms2p6>
2020-12-30 9:48 ` [PATCH] ext4: Fix wrong list_splice in ext4_fc_cleanup Daejun Park
2021-01-05 22:10 ` harshad shirwadkar
2021-01-14 3:34 ` Theodore Ts'o
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.