From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-fscrypt@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: clean up post-read processing
Date: Sun, 3 Jan 2021 19:45:45 -0800 [thread overview]
Message-ID: <X/KPaX7Z0WDEXhBM@sol.localdomain> (raw)
In-Reply-To: <a43158eb-114e-7f7f-871a-7bd9c70639d6@huawei.com>
On Mon, Jan 04, 2021 at 11:35:58AM +0800, Chao Yu wrote:
> On 2020/12/29 7:26, Eric Biggers wrote:
> > + if (ctx && (ctx->enabled_steps & (STEP_DECRYPT | STEP_DECOMPRESS))) {
> > + INIT_WORK(&ctx->work, f2fs_post_read_work);
> > + queue_work(ctx->sbi->post_read_wq, &ctx->work);
>
> Could you keep STEP_DECOMPRESS_NOWQ related logic? so that bio only includes
> non-compressed pages could be handled in irq context rather than in wq context
> which should be unneeded.
>
> Thanks,
>
That's already handled; I made it so that STEP_DECOMPRESS is only enabled when
it's actually needed.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: clean up post-read processing
Date: Sun, 3 Jan 2021 19:45:45 -0800 [thread overview]
Message-ID: <X/KPaX7Z0WDEXhBM@sol.localdomain> (raw)
In-Reply-To: <a43158eb-114e-7f7f-871a-7bd9c70639d6@huawei.com>
On Mon, Jan 04, 2021 at 11:35:58AM +0800, Chao Yu wrote:
> On 2020/12/29 7:26, Eric Biggers wrote:
> > + if (ctx && (ctx->enabled_steps & (STEP_DECRYPT | STEP_DECOMPRESS))) {
> > + INIT_WORK(&ctx->work, f2fs_post_read_work);
> > + queue_work(ctx->sbi->post_read_wq, &ctx->work);
>
> Could you keep STEP_DECOMPRESS_NOWQ related logic? so that bio only includes
> non-compressed pages could be handled in irq context rather than in wq context
> which should be unneeded.
>
> Thanks,
>
That's already handled; I made it so that STEP_DECOMPRESS is only enabled when
it's actually needed.
- Eric
next prev parent reply other threads:[~2021-01-04 3:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 23:26 [f2fs-dev] [PATCH v2] f2fs: clean up post-read processing Eric Biggers
2020-12-28 23:26 ` Eric Biggers
2021-01-04 3:35 ` [f2fs-dev] " Chao Yu
2021-01-04 3:35 ` Chao Yu
2021-01-04 3:45 ` Eric Biggers [this message]
2021-01-04 3:45 ` Eric Biggers
2021-01-04 8:43 ` Chao Yu
2021-01-04 8:43 ` Chao Yu
2021-01-04 18:33 ` Eric Biggers
2021-01-04 18:33 ` Eric Biggers
2021-01-05 1:26 ` Chao Yu
2021-01-05 1:26 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/KPaX7Z0WDEXhBM@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.