From: Greg KH <gregkh@linuxfoundation.org>
To: Claire Chang <tientzu@chromium.org>
Cc: heikki.krogerus@linux.intel.com, peterz@infradead.org,
benh@kernel.crashing.org, grant.likely@arm.com, paulus@samba.org,
frowand.list@gmail.com, mingo@kernel.org, sstabellini@kernel.org,
saravanak@google.com, mpe@ellerman.id.au,
rafael.j.wysocki@intel.com, hch@lst.de,
bgolaszewski@baylibre.com, xen-devel@lists.xenproject.org,
treding@nvidia.com, devicetree@vger.kernel.org, will@kernel.org,
konrad.wilk@oracle.com, dan.j.williams@intel.com,
robh+dt@kernel.org, boris.ostrovsky@oracle.com,
andriy.shevchenko@linux.intel.com, jgross@suse.com,
drinkcat@chromium.org, linuxppc-dev@lists.ozlabs.org,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, xypron.glpk@gmx.de,
robin.murphy@arm.com
Subject: Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool
Date: Wed, 6 Jan 2021 08:50:03 +0100 [thread overview]
Message-ID: <X/VrqxcaAMi65CF0@kroah.com> (raw)
In-Reply-To: <20210106034124.30560-3-tientzu@chromium.org>
On Wed, Jan 06, 2021 at 11:41:20AM +0800, Claire Chang wrote:
> Add the initialization function to create restricted DMA pools from
> matching reserved-memory nodes in the device tree.
>
> Signed-off-by: Claire Chang <tientzu@chromium.org>
> ---
> include/linux/device.h | 4 ++
> include/linux/swiotlb.h | 7 +-
> kernel/dma/Kconfig | 1 +
> kernel/dma/swiotlb.c | 144 ++++++++++++++++++++++++++++++++++------
> 4 files changed, 131 insertions(+), 25 deletions(-)
>
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 89bb8b84173e..ca6f71ec8871 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -413,6 +413,7 @@ struct dev_links_info {
> * @dma_pools: Dma pools (if dma'ble device).
> * @dma_mem: Internal for coherent mem override.
> * @cma_area: Contiguous memory area for dma allocations
> + * @dma_io_tlb_mem: Internal for swiotlb io_tlb_mem override.
Why does this have to be added here? Shouldn't the platform-specific
code handle it instead?
thanks,
greg k-h
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Claire Chang <tientzu@chromium.org>
Cc: heikki.krogerus@linux.intel.com, peterz@infradead.org,
grant.likely@arm.com, paulus@samba.org, frowand.list@gmail.com,
mingo@kernel.org, m.szyprowski@samsung.com,
sstabellini@kernel.org, saravanak@google.com, joro@8bytes.org,
rafael.j.wysocki@intel.com, hch@lst.de,
bgolaszewski@baylibre.com, xen-devel@lists.xenproject.org,
treding@nvidia.com, devicetree@vger.kernel.org, will@kernel.org,
konrad.wilk@oracle.com, dan.j.williams@intel.com,
robh+dt@kernel.org, boris.ostrovsky@oracle.com,
andriy.shevchenko@linux.intel.com, jgross@suse.com,
drinkcat@chromium.org, linuxppc-dev@lists.ozlabs.org,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
tfiga@chromium.org, iommu@lists.linux-foundation.org,
xypron.glpk@gmx.de, robin.murphy@arm.com, bauerman@linux.ibm.com
Subject: Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool
Date: Wed, 6 Jan 2021 08:50:03 +0100 [thread overview]
Message-ID: <X/VrqxcaAMi65CF0@kroah.com> (raw)
In-Reply-To: <20210106034124.30560-3-tientzu@chromium.org>
On Wed, Jan 06, 2021 at 11:41:20AM +0800, Claire Chang wrote:
> Add the initialization function to create restricted DMA pools from
> matching reserved-memory nodes in the device tree.
>
> Signed-off-by: Claire Chang <tientzu@chromium.org>
> ---
> include/linux/device.h | 4 ++
> include/linux/swiotlb.h | 7 +-
> kernel/dma/Kconfig | 1 +
> kernel/dma/swiotlb.c | 144 ++++++++++++++++++++++++++++++++++------
> 4 files changed, 131 insertions(+), 25 deletions(-)
>
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 89bb8b84173e..ca6f71ec8871 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -413,6 +413,7 @@ struct dev_links_info {
> * @dma_pools: Dma pools (if dma'ble device).
> * @dma_mem: Internal for coherent mem override.
> * @cma_area: Contiguous memory area for dma allocations
> + * @dma_io_tlb_mem: Internal for swiotlb io_tlb_mem override.
Why does this have to be added here? Shouldn't the platform-specific
code handle it instead?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Claire Chang <tientzu@chromium.org>
Cc: robh+dt@kernel.org, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, joro@8bytes.org, will@kernel.org,
frowand.list@gmail.com, konrad.wilk@oracle.com,
boris.ostrovsky@oracle.com, jgross@suse.com,
sstabellini@kernel.org, hch@lst.de, m.szyprowski@samsung.com,
robin.murphy@arm.com, grant.likely@arm.com, xypron.glpk@gmx.de,
treding@nvidia.com, mingo@kernel.org, bauerman@linux.ibm.com,
peterz@infradead.org, saravanak@google.com,
rafael.j.wysocki@intel.com, heikki.krogerus@linux.intel.com,
andriy.shevchenko@linux.intel.com, rdunlap@infradead.org,
dan.j.williams@intel.com, bgolaszewski@baylibre.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org,
xen-devel@lists.xenproject.org, tfiga@chromium.org,
drinkcat@chromium.org
Subject: Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool
Date: Wed, 6 Jan 2021 08:50:03 +0100 [thread overview]
Message-ID: <X/VrqxcaAMi65CF0@kroah.com> (raw)
In-Reply-To: <20210106034124.30560-3-tientzu@chromium.org>
On Wed, Jan 06, 2021 at 11:41:20AM +0800, Claire Chang wrote:
> Add the initialization function to create restricted DMA pools from
> matching reserved-memory nodes in the device tree.
>
> Signed-off-by: Claire Chang <tientzu@chromium.org>
> ---
> include/linux/device.h | 4 ++
> include/linux/swiotlb.h | 7 +-
> kernel/dma/Kconfig | 1 +
> kernel/dma/swiotlb.c | 144 ++++++++++++++++++++++++++++++++++------
> 4 files changed, 131 insertions(+), 25 deletions(-)
>
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 89bb8b84173e..ca6f71ec8871 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -413,6 +413,7 @@ struct dev_links_info {
> * @dma_pools: Dma pools (if dma'ble device).
> * @dma_mem: Internal for coherent mem override.
> * @cma_area: Contiguous memory area for dma allocations
> + * @dma_io_tlb_mem: Internal for swiotlb io_tlb_mem override.
Why does this have to be added here? Shouldn't the platform-specific
code handle it instead?
thanks,
greg k-h
next prev parent reply other threads:[~2021-01-06 7:50 UTC|newest]
Thread overview: 180+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 3:41 [RFC PATCH v3 0/6] Restricted DMA Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` [RFC PATCH v3 1/6] swiotlb: Add io_tlb_mem struct Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-13 11:50 ` Christoph Hellwig
2021-01-13 11:50 ` Christoph Hellwig
2021-01-13 11:50 ` Christoph Hellwig
2021-01-06 3:41 ` [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 7:50 ` Greg KH [this message]
2021-01-06 7:50 ` Greg KH
2021-01-06 7:50 ` Greg KH
2021-01-13 11:51 ` Christoph Hellwig
2021-01-13 11:51 ` Christoph Hellwig
2021-01-13 11:51 ` Christoph Hellwig
2021-01-13 12:29 ` Greg KH
2021-01-13 12:29 ` Greg KH
2021-01-13 12:29 ` Greg KH
2021-01-13 12:37 ` Christoph Hellwig
2021-01-13 12:37 ` Christoph Hellwig
2021-01-13 12:37 ` Christoph Hellwig
2021-01-06 18:52 ` Konrad Rzeszutek Wilk
2021-01-06 18:52 ` Konrad Rzeszutek Wilk
2021-01-06 18:52 ` Konrad Rzeszutek Wilk
2021-01-07 17:39 ` Claire Chang
2021-01-07 17:39 ` Claire Chang
2021-01-07 17:39 ` Claire Chang
2021-01-07 17:57 ` Konrad Rzeszutek Wilk
2021-01-07 17:57 ` Konrad Rzeszutek Wilk
2021-01-07 17:57 ` Konrad Rzeszutek Wilk
2021-01-07 18:09 ` Florian Fainelli
2021-01-07 18:09 ` Florian Fainelli
2021-01-07 18:09 ` Florian Fainelli
2021-01-07 21:19 ` Konrad Rzeszutek Wilk
2021-01-07 21:19 ` Konrad Rzeszutek Wilk
2021-01-07 21:19 ` Konrad Rzeszutek Wilk
2021-01-12 23:52 ` Florian Fainelli
2021-01-12 23:52 ` Florian Fainelli
2021-01-12 23:52 ` Florian Fainelli
2021-01-25 5:26 ` Jon Masters
2021-01-25 5:26 ` Jon Masters
2021-01-25 5:26 ` Jon Masters
2021-01-13 1:53 ` Robin Murphy
2021-01-13 1:53 ` Robin Murphy
2021-01-13 1:53 ` Robin Murphy
2021-01-13 0:03 ` Florian Fainelli
2021-01-13 0:03 ` Florian Fainelli
2021-01-13 0:03 ` Florian Fainelli
2021-01-13 13:59 ` Nicolas Saenz Julienne
2021-01-13 13:59 ` Nicolas Saenz Julienne
2021-01-13 13:59 ` Nicolas Saenz Julienne
2021-01-13 15:27 ` Robin Murphy
2021-01-13 15:27 ` Robin Murphy
2021-01-13 15:27 ` Robin Murphy
2021-01-13 17:43 ` Florian Fainelli
2021-01-13 17:43 ` Florian Fainelli
2021-01-13 17:43 ` Florian Fainelli
2021-01-13 18:03 ` Robin Murphy
2021-01-13 18:03 ` Robin Murphy
2021-01-13 18:03 ` Robin Murphy
2021-01-13 12:42 ` Christoph Hellwig
2021-01-13 12:42 ` Christoph Hellwig
2021-01-13 12:42 ` Christoph Hellwig
2021-01-14 9:06 ` Claire Chang
2021-01-14 9:06 ` Claire Chang
2021-01-14 9:06 ` Claire Chang
2021-01-16 13:09 ` kernel test robot
2021-01-06 3:41 ` [RFC PATCH v3 3/6] swiotlb: Use restricted DMA pool if available Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-12 23:39 ` Florian Fainelli
2021-01-12 23:39 ` Florian Fainelli
2021-01-12 23:39 ` Florian Fainelli
2021-01-13 12:44 ` Christoph Hellwig
2021-01-13 12:44 ` Christoph Hellwig
2021-01-13 12:44 ` Christoph Hellwig
2021-01-06 3:41 ` [RFC PATCH v3 4/6] swiotlb: Add restricted DMA alloc/free support Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 5:38 ` kernel test robot
2021-01-12 23:41 ` Florian Fainelli
2021-01-12 23:41 ` Florian Fainelli
2021-01-12 23:41 ` Florian Fainelli
2021-01-13 12:48 ` Christoph Hellwig
2021-01-13 12:48 ` Christoph Hellwig
2021-01-13 12:48 ` Christoph Hellwig
2021-01-13 18:27 ` Robin Murphy
2021-01-13 18:27 ` Robin Murphy
2021-01-13 18:27 ` Robin Murphy
2021-01-13 18:32 ` Christoph Hellwig
2021-01-13 18:32 ` Christoph Hellwig
2021-01-13 18:32 ` Christoph Hellwig
2021-01-06 3:41 ` [RFC PATCH v3 5/6] dt-bindings: of: Add restricted DMA pool Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 18:57 ` Konrad Rzeszutek Wilk
2021-01-06 18:57 ` Konrad Rzeszutek Wilk
2021-01-06 18:57 ` Konrad Rzeszutek Wilk
2021-01-07 17:39 ` Claire Chang
2021-01-07 17:39 ` Claire Chang
2021-01-07 17:39 ` Claire Chang
2021-01-07 18:00 ` Konrad Rzeszutek Wilk
2021-01-07 18:00 ` Konrad Rzeszutek Wilk
2021-01-07 18:00 ` Konrad Rzeszutek Wilk
2021-01-07 18:14 ` Florian Fainelli
2021-01-07 18:14 ` Florian Fainelli
2021-01-07 18:14 ` Florian Fainelli
2021-01-12 7:47 ` Claire Chang
2021-01-12 7:47 ` Claire Chang
2021-01-12 7:47 ` Claire Chang
2021-01-20 16:53 ` Rob Herring
2021-01-20 16:53 ` Rob Herring
2021-01-20 16:53 ` Rob Herring
2021-01-20 17:30 ` Robin Murphy
2021-01-20 17:30 ` Robin Murphy
2021-01-20 17:30 ` Robin Murphy
2021-01-20 21:31 ` Rob Herring
2021-01-20 21:31 ` Rob Herring
2021-01-20 21:31 ` Rob Herring
2021-01-21 1:09 ` Robin Murphy
2021-01-21 1:09 ` Robin Murphy
2021-01-21 1:09 ` Robin Murphy
2021-01-21 15:48 ` Rob Herring
2021-01-21 15:48 ` Rob Herring
2021-01-21 15:48 ` Rob Herring
2021-01-21 17:29 ` Robin Murphy
2021-01-21 17:29 ` Robin Murphy
2021-01-21 17:29 ` Robin Murphy
2021-01-06 3:41 ` [RFC PATCH v3 6/6] of: Add plumbing for " Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 10:57 ` kernel test robot
2021-01-12 23:48 ` Florian Fainelli
2021-01-12 23:48 ` Florian Fainelli
2021-01-12 23:48 ` Florian Fainelli
2021-01-14 9:08 ` Claire Chang
2021-01-14 9:08 ` Claire Chang
2021-01-14 9:08 ` Claire Chang
2021-01-14 18:52 ` Florian Fainelli
2021-01-14 18:52 ` Florian Fainelli
2021-01-14 18:52 ` Florian Fainelli
2021-01-15 3:46 ` Claire Chang
2021-01-15 3:46 ` Claire Chang
2021-01-15 3:46 ` Claire Chang
2021-01-06 18:48 ` [RFC PATCH v3 0/6] Restricted DMA Florian Fainelli
2021-01-06 18:48 ` Florian Fainelli
2021-01-06 18:48 ` Florian Fainelli
2021-01-07 17:38 ` Claire Chang
2021-01-07 17:38 ` Claire Chang
2021-01-07 17:38 ` Claire Chang
2021-01-07 17:42 ` Claire Chang
2021-01-07 17:42 ` Claire Chang
2021-01-07 17:42 ` Claire Chang
2021-01-07 17:59 ` Florian Fainelli
2021-01-07 17:59 ` Florian Fainelli
2021-01-07 17:59 ` Florian Fainelli
2021-01-12 7:48 ` Claire Chang
2021-01-12 7:48 ` Claire Chang
2021-01-12 7:48 ` Claire Chang
2021-01-12 18:01 ` Florian Fainelli
2021-01-12 18:01 ` Florian Fainelli
2021-01-12 18:01 ` Florian Fainelli
2021-01-13 2:29 ` Tomasz Figa
2021-01-13 2:29 ` Tomasz Figa
2021-01-13 2:29 ` Tomasz Figa
2021-01-13 3:56 ` Florian Fainelli
2021-01-13 3:56 ` Florian Fainelli
2021-01-13 3:56 ` Florian Fainelli
2021-01-13 4:25 ` Tomasz Figa
2021-01-13 4:25 ` Tomasz Figa
2021-01-13 4:25 ` Tomasz Figa
2021-01-13 4:41 ` Florian Fainelli
2021-01-13 4:41 ` Florian Fainelli
2021-01-13 4:41 ` Florian Fainelli
2021-02-09 6:27 ` Claire Chang
2021-02-09 6:27 ` Claire Chang
2021-02-09 6:27 ` Claire Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/VrqxcaAMi65CF0@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=bgolaszewski@baylibre.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@arm.com \
--cc=hch@lst.de \
--cc=heikki.krogerus@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@google.com \
--cc=sstabellini@kernel.org \
--cc=tientzu@chromium.org \
--cc=treding@nvidia.com \
--cc=will@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.