From: Moritz Fischer <mdf@kernel.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wu Hao <hao.wu@intel.com>, Moritz Fischer <mdf@kernel.org>,
Matthew Gerlach <matthew.gerlach@linux.intel.com>,
linux-fpga@vger.kernel.org, Tom Rix <trix@redhat.com>,
linux-doc@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] fpga: dfl-pci: rectify ReST formatting
Date: Mon, 11 Jan 2021 15:55:25 +0000 [thread overview]
Message-ID: <X/x07V2WqhmkIMcr@archbook> (raw)
In-Reply-To: <20210111112113.27242-1-lukas.bulwahn@gmail.com>
Hi Lukas,
On Mon, Jan 11, 2021 at 12:21:13PM +0100, Lukas Bulwahn wrote:
> Commit fa41d10589be ("fpga: dfl-pci: locate DFLs by PCIe vendor specific
> capability") provides documentation to the FPGA Device Feature List (DFL)
Nit: Do you want to make this a Fixes: tag instead?
> Framework Overview, but introduced new documentation warnings:
>
> ./Documentation/fpga/dfl.rst:
> 505: WARNING: Title underline too short.
> 523: WARNING: Unexpected indentation.
> 523: WARNING: Blank line required after table.
> 524: WARNING: Block quote ends without a blank line; unexpected unindent.
>
> Rectify ReST formatting in ./Documentation/fpga/dfl.rst.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Acked-by: Moritz Fischer <mdf@kernel.org>
> ---
> applies cleanly on next-20210111
>
> Moritz, Matthew, please ack.
>
> Greg, please pick this doc fixup to your fpga -next tree on top of
> the commit above.
>
> Documentation/fpga/dfl.rst | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/fpga/dfl.rst b/Documentation/fpga/dfl.rst
> index ea8cefc18bdb..c41ac76ffaae 100644
> --- a/Documentation/fpga/dfl.rst
> +++ b/Documentation/fpga/dfl.rst
> @@ -502,7 +502,7 @@ FME Partial Reconfiguration Sub Feature driver (see drivers/fpga/dfl-fme-pr.c)
> could be a reference.
>
> Location of DFLs on a PCI Device
> -=============> +================
> The original method for finding a DFL on a PCI device assumed the start of the
> first DFL to offset 0 of bar 0. If the first node of the DFL is an FME,
> then further DFLs in the port(s) are specified in FME header registers.
> @@ -514,6 +514,7 @@ data begins with a 4 byte vendor specific register for the number of DFLs follow
> Offset/BIR vendor specific registers for each DFL. Bits 2:0 of Offset/BIR register
> indicates the BAR, and bits 31:3 form the 8 byte aligned offset where bits 2:0 are
> zero.
> +::
>
> +----------------------------+
> |31 Number of DFLS 0|
> --
> 2.17.1
>
Thanks for doing this, I was about to send that same patch myself.
- Moritz
WARNING: multiple messages have this Message-ID (diff)
From: Moritz Fischer <mdf@kernel.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wu Hao <hao.wu@intel.com>, Moritz Fischer <mdf@kernel.org>,
Matthew Gerlach <matthew.gerlach@linux.intel.com>,
linux-fpga@vger.kernel.org, Tom Rix <trix@redhat.com>,
linux-doc@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] fpga: dfl-pci: rectify ReST formatting
Date: Mon, 11 Jan 2021 07:55:25 -0800 [thread overview]
Message-ID: <X/x07V2WqhmkIMcr@archbook> (raw)
In-Reply-To: <20210111112113.27242-1-lukas.bulwahn@gmail.com>
Hi Lukas,
On Mon, Jan 11, 2021 at 12:21:13PM +0100, Lukas Bulwahn wrote:
> Commit fa41d10589be ("fpga: dfl-pci: locate DFLs by PCIe vendor specific
> capability") provides documentation to the FPGA Device Feature List (DFL)
Nit: Do you want to make this a Fixes: tag instead?
> Framework Overview, but introduced new documentation warnings:
>
> ./Documentation/fpga/dfl.rst:
> 505: WARNING: Title underline too short.
> 523: WARNING: Unexpected indentation.
> 523: WARNING: Blank line required after table.
> 524: WARNING: Block quote ends without a blank line; unexpected unindent.
>
> Rectify ReST formatting in ./Documentation/fpga/dfl.rst.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Acked-by: Moritz Fischer <mdf@kernel.org>
> ---
> applies cleanly on next-20210111
>
> Moritz, Matthew, please ack.
>
> Greg, please pick this doc fixup to your fpga -next tree on top of
> the commit above.
>
> Documentation/fpga/dfl.rst | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/fpga/dfl.rst b/Documentation/fpga/dfl.rst
> index ea8cefc18bdb..c41ac76ffaae 100644
> --- a/Documentation/fpga/dfl.rst
> +++ b/Documentation/fpga/dfl.rst
> @@ -502,7 +502,7 @@ FME Partial Reconfiguration Sub Feature driver (see drivers/fpga/dfl-fme-pr.c)
> could be a reference.
>
> Location of DFLs on a PCI Device
> -===========================
> +================================
> The original method for finding a DFL on a PCI device assumed the start of the
> first DFL to offset 0 of bar 0. If the first node of the DFL is an FME,
> then further DFLs in the port(s) are specified in FME header registers.
> @@ -514,6 +514,7 @@ data begins with a 4 byte vendor specific register for the number of DFLs follow
> Offset/BIR vendor specific registers for each DFL. Bits 2:0 of Offset/BIR register
> indicates the BAR, and bits 31:3 form the 8 byte aligned offset where bits 2:0 are
> zero.
> +::
>
> +----------------------------+
> |31 Number of DFLS 0|
> --
> 2.17.1
>
Thanks for doing this, I was about to send that same patch myself.
- Moritz
next prev parent reply other threads:[~2021-01-11 15:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 11:21 [PATCH -next] fpga: dfl-pci: rectify ReST formatting Lukas Bulwahn
2021-01-11 11:21 ` Lukas Bulwahn
2021-01-11 15:11 ` Tom Rix
2021-01-11 15:11 ` Tom Rix
2021-01-11 15:53 ` Greg Kroah-Hartman
2021-01-11 15:53 ` Greg Kroah-Hartman
2021-01-11 16:07 ` Tom Rix
2021-01-11 16:07 ` Tom Rix
2021-01-11 15:53 ` Greg Kroah-Hartman
2021-01-11 15:53 ` Greg Kroah-Hartman
2021-01-11 16:34 ` Lukas Bulwahn
2021-01-11 16:34 ` Lukas Bulwahn
2021-01-11 18:14 ` Greg Kroah-Hartman
2021-01-11 18:14 ` Greg Kroah-Hartman
2021-01-14 16:45 ` Moritz Fischer
2021-01-14 16:45 ` Moritz Fischer
2021-01-14 17:05 ` Greg Kroah-Hartman
2021-01-14 17:05 ` Greg Kroah-Hartman
2021-01-11 15:55 ` Moritz Fischer [this message]
2021-01-11 15:55 ` Moritz Fischer
2021-01-11 17:10 ` Lukas Bulwahn
2021-01-11 17:10 ` Lukas Bulwahn
2021-01-11 18:16 ` matthew.gerlach
2021-01-11 18:16 ` matthew.gerlach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/x07V2WqhmkIMcr@archbook \
--to=mdf@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.