From: Eric Biggers <ebiggers@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>
Cc: Daeho Jeong <daehojeong@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: add disable_auto_compr mount option
Date: Mon, 16 Nov 2020 20:14:54 -0800 [thread overview]
Message-ID: <X7NOPrbIMtHFvVwp@sol.localdomain> (raw)
In-Reply-To: <20201117040223.858979-1-daeho43@gmail.com>
This patchset doesn't have a cover letter, and it doesn't apply to f2fs/dev, so
I'm not sure what its purpose is.
On Tue, Nov 17, 2020 at 01:02:22PM +0900, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> We will add a new disable_auto_compr mount option to turn off the
> automaic compression on the compression enabled file, in order to
> give discretion of choosing the target file and the timing of
> compression to the user.
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> ---
> Documentation/filesystems/f2fs.rst | 4 ++++
> fs/f2fs/data.c | 10 +++++-----
> fs/f2fs/f2fs.h | 8 ++++++++
> fs/f2fs/segment.c | 2 +-
> fs/f2fs/super.c | 9 +++++++++
> 5 files changed, 27 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst
> index b8ee761c9922..c36ca1e0f7ab 100644
> --- a/Documentation/filesystems/f2fs.rst
> +++ b/Documentation/filesystems/f2fs.rst
> @@ -260,6 +260,10 @@ compress_extension=%s Support adding specified extension, so that f2fs can enab
> For other files, we can still enable compression via ioctl.
> Note that, there is one reserved special extension '*', it
> can be set to enable compression for all files.
> +disable_auto_compr Even if compression feature is enabled, this option can
> + disable automaic compression on the compression enabled
> + file to give discretion of choosing the target file and
> + the timing of compression to the user.
I don't understand. How is this different from just not specifying the
compress_extension mount option? And how can a file have compression both
enabled and disabled at the same time?
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: add disable_auto_compr mount option
Date: Mon, 16 Nov 2020 20:14:54 -0800 [thread overview]
Message-ID: <X7NOPrbIMtHFvVwp@sol.localdomain> (raw)
In-Reply-To: <20201117040223.858979-1-daeho43@gmail.com>
This patchset doesn't have a cover letter, and it doesn't apply to f2fs/dev, so
I'm not sure what its purpose is.
On Tue, Nov 17, 2020 at 01:02:22PM +0900, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> We will add a new disable_auto_compr mount option to turn off the
> automaic compression on the compression enabled file, in order to
> give discretion of choosing the target file and the timing of
> compression to the user.
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> ---
> Documentation/filesystems/f2fs.rst | 4 ++++
> fs/f2fs/data.c | 10 +++++-----
> fs/f2fs/f2fs.h | 8 ++++++++
> fs/f2fs/segment.c | 2 +-
> fs/f2fs/super.c | 9 +++++++++
> 5 files changed, 27 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst
> index b8ee761c9922..c36ca1e0f7ab 100644
> --- a/Documentation/filesystems/f2fs.rst
> +++ b/Documentation/filesystems/f2fs.rst
> @@ -260,6 +260,10 @@ compress_extension=%s Support adding specified extension, so that f2fs can enab
> For other files, we can still enable compression via ioctl.
> Note that, there is one reserved special extension '*', it
> can be set to enable compression for all files.
> +disable_auto_compr Even if compression feature is enabled, this option can
> + disable automaic compression on the compression enabled
> + file to give discretion of choosing the target file and
> + the timing of compression to the user.
I don't understand. How is this different from just not specifying the
compress_extension mount option? And how can a file have compression both
enabled and disabled at the same time?
- Eric
next prev parent reply other threads:[~2020-11-17 4:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 4:02 [f2fs-dev] [PATCH 1/2] f2fs: add disable_auto_compr mount option Daeho Jeong
2020-11-17 4:02 ` Daeho Jeong
2020-11-17 4:02 ` [f2fs-dev] [PATCH 2/2] f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE Daeho Jeong
2020-11-17 4:02 ` Daeho Jeong
2020-11-17 4:14 ` Eric Biggers [this message]
2020-11-17 4:14 ` [f2fs-dev] [PATCH 1/2] f2fs: add disable_auto_compr mount option Eric Biggers
2020-11-17 17:13 ` Jaegeuk Kim
2020-11-17 17:13 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X7NOPrbIMtHFvVwp@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.