Re: [PATCH v4 2/2] media: i2c: Add support for the OV5648 image sensor

From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Maxime Ripard <mripard@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Rob Herring <robh+dt@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v4 2/2] media: i2c: Add support for the OV5648 image sensor
Date: Wed, 2 Dec 2020 14:50:13 +0100	[thread overview]
Message-ID: <X8eblRy3iqjcInyg@aptenodytes> (raw)
In-Reply-To: <20201130135331.GW3940@paasikivi.fi.intel.com>

[-- Attachment #1.1: Type: text/plain, Size: 1322 bytes --]

Hi Sakari,

On Mon 30 Nov 20, 15:53, Sakari Ailus wrote:
> Hi Paul,
> 
> On Mon, Nov 30, 2020 at 02:48:04PM +0100, Paul Kocialkowski wrote:
> > Hi Sakari,
> > 
> > On Mon 30 Nov 20, 11:28, Sakari Ailus wrote:
> > > Hi Paul,
> > > 
> > > Thanks for the update. I have a few comments on the driver, too.
> > 
> > Thanks for the review!
> > 
> > [...]
> > 
> > > > +	ret = ov5648_write(sensor, OV5648_GAIN_BLUE_MAN_L_REG,
> > > > +			   OV5648_GAIN_BLUE_MAN_L(blue_balance));
> > > 
> > > return ...
> > > 
> > > Same below (and above).
> > 
> > Well I don't think that makes any functional difference, right?
> > My personal preference is to have explicit checks even at the end of functions
> > for symetry and alignment with other blocks.
> > 
> > If it's okay, it'd like to keep it as-is. But if that's against kernel coding
> > style guidelines, I won't argue more.
> 
> Please do change them.
> 
> It's useless code, repeated at the end of a number of functions in this
> driver. I wouldn't mind otherwise, but people do take examples from
> existing drivers so such patterns tend to repeat in other places.

I don't agree that it's useless but I will do as you ask.

Cheers,

Paul

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel