Re: [PATCH v2 4/5] amba: Make the remove callback return void

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	David Airlie <airlied@linux.ie>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Jaroslav Kysela <perex@perex.cz>, Eric Anholt <eric@anholt.net>,
	Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Russell King <linux@armlinux.org.uk>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Guenter Roeck <linux@roeck-us.net>,
	kernel@pengutronix.de, Arnd Bergmann <arnd@arndb.de>,
	Alex Williamson <alex.williamson@redhat.com>,
	Mark Brown <broonie@kernel.org>, Matt Mackall <mpm@selenic.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	linux-arm-kernel@lists.infradead.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Cornelia Huck <cohuck@redhat.com>, Takashi Iwai <tiwai@suse.com>,
	linux-kernel@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
	Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v2 4/5] amba: Make the remove callback return void
Date: Thu, 3 Dec 2020 11:36:16 -0800	[thread overview]
Message-ID: <X8k+MDeyKZCWxMOw@google.com> (raw)
In-Reply-To: <20201203130141.ys2s7aaltyzkdena@pengutronix.de>

On Thu, Dec 03, 2020 at 02:01:41PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> [This is a resend because somehow my MUA failed to parse the To: list
> and dropped it without me noticing it. Sorry to those who got it twice
> now.]
> 
> On Tue, Nov 24, 2020 at 02:31:38PM +0100, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > 
> > All amba drivers return 0 in their remove callback. Together with the
> > driver core ignoring the return value anyhow, it doesn't make sense to
> > return a value here.
> > 
> > Change the remove prototype to return void, which makes it explicit that
> > returning an error value doesn't work as expected. This simplifies changing
> > the core remove callback to return void, too.
> > 
> > Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  drivers/amba/bus.c                                 | 5 ++---
> >  drivers/char/hw_random/nomadik-rng.c               | 3 +--
> >  drivers/dma/pl330.c                                | 3 +--
> >  drivers/gpu/drm/pl111/pl111_drv.c                  | 4 +---
> >  drivers/hwtracing/coresight/coresight-catu.c       | 3 +--
> >  drivers/hwtracing/coresight/coresight-cpu-debug.c  | 4 +---
> >  drivers/hwtracing/coresight/coresight-cti-core.c   | 4 +---
> >  drivers/hwtracing/coresight/coresight-etb10.c      | 4 +---
> >  drivers/hwtracing/coresight/coresight-etm3x-core.c | 4 +---
> >  drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +---
> >  drivers/hwtracing/coresight/coresight-funnel.c     | 4 ++--
> >  drivers/hwtracing/coresight/coresight-replicator.c | 4 ++--
> >  drivers/hwtracing/coresight/coresight-stm.c        | 4 +---
> >  drivers/hwtracing/coresight/coresight-tmc-core.c   | 4 +---
> >  drivers/hwtracing/coresight/coresight-tpiu.c       | 4 +---
> >  drivers/i2c/busses/i2c-nomadik.c                   | 4 +---
> >  drivers/input/serio/ambakmi.c                      | 3 +--

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks.

-- 
Dmitry

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel