All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Himadri Pandya <himadrispandya@gmail.com>
Cc: linux-usb@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org, johan@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH 02/15] usb: serial: belkin_sa: use usb_control_msg_send()
Date: Fri, 4 Dec 2020 10:17:44 +0100	[thread overview]
Message-ID: <X8n+uO2nYzRcxaLk@localhost> (raw)
In-Reply-To: <20201104064703.15123-3-himadrispandya@gmail.com>

On Wed, Nov 04, 2020 at 12:16:50PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_send() nicely wraps usb_control_msg() with
> proper error check. Hence use the wrapper instead of calling
> usb_control_msg() directly.
> 
> Signed-off-by: Himadri Pandya <himadrispandya@gmail.com>
> ---
>  drivers/usb/serial/belkin_sa.c | 35 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/usb/serial/belkin_sa.c b/drivers/usb/serial/belkin_sa.c
> index 9bb123ab9bc9..a5ff55f48303 100644
> --- a/drivers/usb/serial/belkin_sa.c
> +++ b/drivers/usb/serial/belkin_sa.c
> @@ -105,9 +105,10 @@ struct belkin_sa_private {
>  #define WDR_TIMEOUT 5000 /* default urb timeout */
>  
>  /* assumes that struct usb_serial *serial is available */
> -#define BSA_USB_CMD(c, v) usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), \
> -					    (c), BELKIN_SA_SET_REQUEST_TYPE, \
> -					    (v), 0, NULL, 0, WDR_TIMEOUT)
> +#define BSA_USB_CMD(c, v) usb_control_msg_send(serial->dev, 0, (c), \
> +					       BELKIN_SA_SET_REQUEST_TYPE, \
> +					       (v), 0, NULL, 0, WDR_TIMEOUT, \
> +					       GFP_KERNEL)

Also here there's no data stage so there no point in using the new
helpers.

Please drop this one as well.

Johan
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Himadri Pandya <himadrispandya@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH 02/15] usb: serial: belkin_sa: use usb_control_msg_send()
Date: Fri, 4 Dec 2020 10:17:44 +0100	[thread overview]
Message-ID: <X8n+uO2nYzRcxaLk@localhost> (raw)
In-Reply-To: <20201104064703.15123-3-himadrispandya@gmail.com>

On Wed, Nov 04, 2020 at 12:16:50PM +0530, Himadri Pandya wrote:
> The new usb_control_msg_send() nicely wraps usb_control_msg() with
> proper error check. Hence use the wrapper instead of calling
> usb_control_msg() directly.
> 
> Signed-off-by: Himadri Pandya <himadrispandya@gmail.com>
> ---
>  drivers/usb/serial/belkin_sa.c | 35 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/usb/serial/belkin_sa.c b/drivers/usb/serial/belkin_sa.c
> index 9bb123ab9bc9..a5ff55f48303 100644
> --- a/drivers/usb/serial/belkin_sa.c
> +++ b/drivers/usb/serial/belkin_sa.c
> @@ -105,9 +105,10 @@ struct belkin_sa_private {
>  #define WDR_TIMEOUT 5000 /* default urb timeout */
>  
>  /* assumes that struct usb_serial *serial is available */
> -#define BSA_USB_CMD(c, v) usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), \
> -					    (c), BELKIN_SA_SET_REQUEST_TYPE, \
> -					    (v), 0, NULL, 0, WDR_TIMEOUT)
> +#define BSA_USB_CMD(c, v) usb_control_msg_send(serial->dev, 0, (c), \
> +					       BELKIN_SA_SET_REQUEST_TYPE, \
> +					       (v), 0, NULL, 0, WDR_TIMEOUT, \
> +					       GFP_KERNEL)

Also here there's no data stage so there no point in using the new
helpers.

Please drop this one as well.

Johan

  reply	other threads:[~2020-12-04  9:17 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04  6:46 [Linux-kernel-mentees] [PATCH 00/15] usb: serial: avoid using usb_control_msg() directly Himadri Pandya
2020-11-04  6:46 ` Himadri Pandya
2020-11-04  6:46 ` [Linux-kernel-mentees] [PATCH 01/15] usb: serial: ark3116: use usb_control_msg_recv() and usb_control_msg_send() Himadri Pandya
2020-11-04  6:46   ` Himadri Pandya
2020-12-04  9:16   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04  9:16     ` Johan Hovold
2020-11-04  6:46 ` [Linux-kernel-mentees] [PATCH 02/15] usb: serial: belkin_sa: use usb_control_msg_send() Himadri Pandya
2020-11-04  6:46   ` Himadri Pandya
2020-12-04  9:17   ` Johan Hovold [this message]
2020-12-04  9:17     ` Johan Hovold
2020-11-04  6:46 ` [Linux-kernel-mentees] [PATCH 03/15] usb: serial: ch314: use usb_control_msg_recv() and usb_control_msg_send() Himadri Pandya
2020-11-04  6:46   ` Himadri Pandya
2020-12-04  9:24   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04  9:24     ` Johan Hovold
2020-11-04  6:46 ` [Linux-kernel-mentees] [PATCH 04/15] usb: serial: cp210x: " Himadri Pandya
2020-11-04  6:46   ` Himadri Pandya
2020-12-04  9:34   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04  9:34     ` Johan Hovold
2020-11-04  6:46 ` [Linux-kernel-mentees] [PATCH 05/15] usb: serial: cypress_m8: " Himadri Pandya
2020-11-04  6:46   ` Himadri Pandya
2020-12-04  9:37   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04  9:37     ` Johan Hovold
2020-11-04  6:46 ` [Linux-kernel-mentees] [PATCH 06/15] usb: serial: f81232: " Himadri Pandya
2020-11-04  6:46   ` Himadri Pandya
2020-12-04  9:49   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04  9:49     ` Johan Hovold
2020-11-04  6:46 ` [Linux-kernel-mentees] [PATCH 07/15] usb: serial: f81534: " Himadri Pandya
2020-11-04  6:46   ` Himadri Pandya
2020-12-04  9:55   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04  9:55     ` Johan Hovold
2020-11-04  6:46 ` [Linux-kernel-mentees] [PATCH 08/15] usb: serial: ftdi_sio: " Himadri Pandya
2020-11-04  6:46   ` Himadri Pandya
2020-12-04 10:03   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04 10:03     ` Johan Hovold
2020-11-04  6:46 ` [Linux-kernel-mentees] [PATCH 09/15] usb: serial: io_edgeport: " Himadri Pandya
2020-11-04  6:46   ` Himadri Pandya
2020-12-04 10:10   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04 10:10     ` Johan Hovold
2020-11-04  6:46 ` [Linux-kernel-mentees] [PATCH 10/15] usb: serial: io_ti: " Himadri Pandya
2020-11-04  6:46   ` Himadri Pandya
2020-12-04 10:12   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04 10:12     ` Johan Hovold
2020-11-04  6:46 ` [Linux-kernel-mentees] [PATCH 11/15] usb: serial: ipaq: use usb_control_msg_send() Himadri Pandya
2020-11-04  6:46   ` Himadri Pandya
2020-12-04 10:21   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04 10:21     ` Johan Hovold
2020-11-04  6:47 ` [Linux-kernel-mentees] [PATCH 12/15] usb: serial: ipw: " Himadri Pandya
2020-11-04  6:47   ` Himadri Pandya
2020-12-04 10:27   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04 10:27     ` Johan Hovold
2020-11-04  6:47 ` [Linux-kernel-mentees] [PATCH 13/15] usb: serial: iuu_phoenix: " Himadri Pandya
2020-11-04  6:47   ` Himadri Pandya
2020-12-04 10:28   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04 10:28     ` Johan Hovold
2020-11-04  6:47 ` [Linux-kernel-mentees] [PATCH 14/15] usb: serial: keyspan_pda: use usb_control_msg_recv() and usb_control_msg_send() Himadri Pandya
2020-11-04  6:47   ` Himadri Pandya
2020-12-04 10:31   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04 10:31     ` Johan Hovold
2020-11-04  6:47 ` [Linux-kernel-mentees] [PATCH 15/15] usb: serial: kl5kusb105: " Himadri Pandya
2020-11-04  6:47   ` Himadri Pandya
2020-12-04 10:37   ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04 10:37     ` Johan Hovold
2020-11-06 10:43 ` [Linux-kernel-mentees] [PATCH 00/15] usb: serial: avoid using usb_control_msg() directly Greg KH
2020-11-06 10:43   ` Greg KH
2020-12-04  9:09 ` [Linux-kernel-mentees] " Johan Hovold
2020-12-04  9:09   ` Johan Hovold
2020-12-24 10:01   ` [Linux-kernel-mentees] " Himadri Pandya
2020-12-24 10:01     ` Himadri Pandya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X8n+uO2nYzRcxaLk@localhost \
    --to=johan@kernel.org \
    --cc=himadrispandya@gmail.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.