All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: u.kleine-koenig@pengutronix.de, lee.jones@linaro.org,
	nsaenzjulienne@suse.de, f.fainelli@gmail.com, rjui@broadcom.com,
	sean@mess.org, sbranden@broadcom.com,
	bcm-kernel-feedback-list@broadcom.com, linux-pwm@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] pwm: bcm2835: Support apply function for atomic configuration
Date: Thu, 10 Dec 2020 18:21:22 +0100	[thread overview]
Message-ID: <X9JZEohJLGiT42lu@ulmo> (raw)
In-Reply-To: <1607546905-20549-1-git-send-email-LinoSanfilippo@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

On Wed, Dec 09, 2020 at 09:48:25PM +0100, Lino Sanfilippo wrote:
> Use the newer .apply function of pwm_ops instead of .config, .enable,
> .disable and .set_polarity. This guarantees atomic changes of the pwm
> controller configuration. It also reduces the size of the driver.
> 
> Since now period is a 64 bit value, add an extra check to reject periods
> that exceed the possible max value for the 32 bit register.
> 
> This has been tested on a Raspberry PI 4.
> 
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
> ---
> 
> v4: Remove a superfluous blank line
>     Remove an unneeded cast (both requested by Uwe Kleine-König)
> v3: Check against period truncation (also based on a review by Uwe)
> v2: Fix compiler error for 64 bit builds
> 
>  drivers/pwm/pwm-bcm2835.c | 69 +++++++++++++++++------------------------------
>  1 file changed, 24 insertions(+), 45 deletions(-) j

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
	f.fainelli@gmail.com, sbranden@broadcom.com, sean@mess.org,
	rjui@broadcom.com, linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	u.kleine-koenig@pengutronix.de, lee.jones@linaro.org,
	nsaenzjulienne@suse.de
Subject: Re: [PATCH v4] pwm: bcm2835: Support apply function for atomic configuration
Date: Thu, 10 Dec 2020 18:21:22 +0100	[thread overview]
Message-ID: <X9JZEohJLGiT42lu@ulmo> (raw)
In-Reply-To: <1607546905-20549-1-git-send-email-LinoSanfilippo@gmx.de>


[-- Attachment #1.1: Type: text/plain, Size: 943 bytes --]

On Wed, Dec 09, 2020 at 09:48:25PM +0100, Lino Sanfilippo wrote:
> Use the newer .apply function of pwm_ops instead of .config, .enable,
> .disable and .set_polarity. This guarantees atomic changes of the pwm
> controller configuration. It also reduces the size of the driver.
> 
> Since now period is a 64 bit value, add an extra check to reject periods
> that exceed the possible max value for the 32 bit register.
> 
> This has been tested on a Raspberry PI 4.
> 
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
> ---
> 
> v4: Remove a superfluous blank line
>     Remove an unneeded cast (both requested by Uwe Kleine-König)
> v3: Check against period truncation (also based on a review by Uwe)
> v2: Fix compiler error for 64 bit builds
> 
>  drivers/pwm/pwm-bcm2835.c | 69 +++++++++++++++++------------------------------
>  1 file changed, 24 insertions(+), 45 deletions(-) j

Applied, thanks.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-12-10 17:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09 20:48 [PATCH v4] pwm: bcm2835: Support apply function for atomic configuration Lino Sanfilippo
2020-12-09 20:48 ` Lino Sanfilippo
2020-12-10 12:58 ` Uwe Kleine-König
2020-12-10 12:58   ` Uwe Kleine-König
2020-12-10 17:21 ` Thierry Reding [this message]
2020-12-10 17:21   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X9JZEohJLGiT42lu@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=LinoSanfilippo@gmx.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=nsaenzjulienne@suse.de \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=sean@mess.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.