From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH RFC] f2fs: compress: add compress_flag in struct f2fs_comp_option
Date: Thu, 10 Dec 2020 09:23:43 -0800 [thread overview]
Message-ID: <X9JZn2ELSZISEQpU@google.com> (raw)
In-Reply-To: <20201210092020.66245-1-yuchao0@huawei.com>
On 12/10, Chao Yu wrote:
> Add a extra field compress_flag to get/set more compress option from/to
> compressed inode.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
>
> Daeho, Jaegeuk,
>
> Could you please check whether we could add this new field to struct
> f2fs_comp_option? so we can expand to allow user to query/config more
> options of compressed inode via new ioctl.
>
> It needs to consider before original patches goes to merge window, let
> me know you have other concerns.
Chao, I think it'd hard to add this at time point, unless there's critical
info that we need to set very urgently.
>
> fs/f2fs/file.c | 1 +
> include/uapi/linux/f2fs.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 16ea10f2bcf5..fbf06311c88d 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -3965,6 +3965,7 @@ static int f2fs_ioc_get_compress_option(struct file *filp, unsigned long arg)
>
> option.algorithm = F2FS_I(inode)->i_compress_algorithm;
> option.log_cluster_size = F2FS_I(inode)->i_log_cluster_size;
> + option.compress_flag = F2FS_I(inode)->i_compress_flag;
>
> inode_unlock_shared(inode);
>
> diff --git a/include/uapi/linux/f2fs.h b/include/uapi/linux/f2fs.h
> index 352a822d4370..2b9c4c99ceee 100644
> --- a/include/uapi/linux/f2fs.h
> +++ b/include/uapi/linux/f2fs.h
> @@ -93,6 +93,7 @@ struct f2fs_sectrim_range {
> struct f2fs_comp_option {
> __u8 algorithm;
> __u8 log_cluster_size;
> + __u16 compress_flag;
> };
>
> #endif /* _UAPI_LINUX_F2FS_H */
> --
> 2.29.2
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, chao@kernel.org
Subject: Re: [PATCH RFC] f2fs: compress: add compress_flag in struct f2fs_comp_option
Date: Thu, 10 Dec 2020 09:23:43 -0800 [thread overview]
Message-ID: <X9JZn2ELSZISEQpU@google.com> (raw)
In-Reply-To: <20201210092020.66245-1-yuchao0@huawei.com>
On 12/10, Chao Yu wrote:
> Add a extra field compress_flag to get/set more compress option from/to
> compressed inode.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
>
> Daeho, Jaegeuk,
>
> Could you please check whether we could add this new field to struct
> f2fs_comp_option? so we can expand to allow user to query/config more
> options of compressed inode via new ioctl.
>
> It needs to consider before original patches goes to merge window, let
> me know you have other concerns.
Chao, I think it'd hard to add this at time point, unless there's critical
info that we need to set very urgently.
>
> fs/f2fs/file.c | 1 +
> include/uapi/linux/f2fs.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 16ea10f2bcf5..fbf06311c88d 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -3965,6 +3965,7 @@ static int f2fs_ioc_get_compress_option(struct file *filp, unsigned long arg)
>
> option.algorithm = F2FS_I(inode)->i_compress_algorithm;
> option.log_cluster_size = F2FS_I(inode)->i_log_cluster_size;
> + option.compress_flag = F2FS_I(inode)->i_compress_flag;
>
> inode_unlock_shared(inode);
>
> diff --git a/include/uapi/linux/f2fs.h b/include/uapi/linux/f2fs.h
> index 352a822d4370..2b9c4c99ceee 100644
> --- a/include/uapi/linux/f2fs.h
> +++ b/include/uapi/linux/f2fs.h
> @@ -93,6 +93,7 @@ struct f2fs_sectrim_range {
> struct f2fs_comp_option {
> __u8 algorithm;
> __u8 log_cluster_size;
> + __u16 compress_flag;
> };
>
> #endif /* _UAPI_LINUX_F2FS_H */
> --
> 2.29.2
next prev parent reply other threads:[~2020-12-10 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 9:20 [f2fs-dev] [PATCH RFC] f2fs: compress: add compress_flag in struct f2fs_comp_option Chao Yu
2020-12-10 9:20 ` Chao Yu
2020-12-10 17:23 ` Jaegeuk Kim [this message]
2020-12-10 17:23 ` Jaegeuk Kim
2020-12-11 6:08 ` [f2fs-dev] " Chao Yu
2020-12-11 6:08 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9JZn2ELSZISEQpU@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.