* [PATCH v1] drm/bridge: lt9611: Fix handling of 4k panels
@ 2020-11-23 10:46 ` Robert Foss
0 siblings, 0 replies; 9+ messages in thread
From: Robert Foss @ 2020-11-23 10:46 UTC (permalink / raw)
To: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel, dri-devel, linux-kernel, John Stultz,
Peter Collingbourne
Cc: Alistair Delva, Vinod Koul, Anibal Limon, Bjorn Andersson,
Robert Foss
4k requires two dsi pipes, so don't report MODE_OK when only a
single pipe is configured. But rather report MODE_PANEL to
signal that requirements of the panel are not being met.
Reported-by: Peter Collingbourne <pcc@google.com>
Suggested-by: Peter Collingbourne <pcc@google.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Tested-by: John Stultz <john.stultz@linaro.org>
---
drivers/gpu/drm/bridge/lontium-lt9611.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index d734d9402c35..e8eb8deb444b 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -867,8 +867,14 @@ static enum drm_mode_status lt9611_bridge_mode_valid(struct drm_bridge *bridge,
const struct drm_display_mode *mode)
{
struct lt9611_mode *lt9611_mode = lt9611_find_mode(mode);
+ struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
- return lt9611_mode ? MODE_OK : MODE_BAD;
+ if (!lt9611_mode)
+ return MODE_BAD;
+ else if (lt9611_mode->intfs > 1 && !lt9611->dsi1)
+ return MODE_PANEL;
+ else
+ return MODE_OK;
}
static void lt9611_bridge_pre_enable(struct drm_bridge *bridge)
--
2.27.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v1] drm/bridge: lt9611: Fix handling of 4k panels
2020-11-23 10:46 ` Robert Foss
(?)
@ 2020-11-23 16:04 ` Anibal Limon
-1 siblings, 0 replies; 9+ messages in thread
From: Anibal Limon @ 2020-11-23 16:04 UTC (permalink / raw)
To: Robert Foss
Cc: Alistair Delva, jernej.skrabec, Vinod Koul, jonas, airlied,
narmstrong, linux-kernel, dri-devel, Bjorn Andersson, a.hajda,
Laurent.pinchart, Peter Collingbourne
[-- Attachment #1.1: Type: text/plain, Size: 1613 bytes --]
I just tested on non 4k display. Looks good to me.
On Mon, 23 Nov 2020 at 04:46, Robert Foss <robert.foss@linaro.org> wrote:
> 4k requires two dsi pipes, so don't report MODE_OK when only a
> single pipe is configured. But rather report MODE_PANEL to
> signal that requirements of the panel are not being met.
>
> Reported-by: Peter Collingbourne <pcc@google.com>
> Suggested-by: Peter Collingbourne <pcc@google.com>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
>
Tested-by: Anibal Limon <anibal.limon@linaro.org>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c
> b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index d734d9402c35..e8eb8deb444b 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -867,8 +867,14 @@ static enum drm_mode_status
> lt9611_bridge_mode_valid(struct drm_bridge *bridge,
> const struct
> drm_display_mode *mode)
> {
> struct lt9611_mode *lt9611_mode = lt9611_find_mode(mode);
> + struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
>
> - return lt9611_mode ? MODE_OK : MODE_BAD;
> + if (!lt9611_mode)
> + return MODE_BAD;
> + else if (lt9611_mode->intfs > 1 && !lt9611->dsi1)
> + return MODE_PANEL;
> + else
> + return MODE_OK;
> }
>
> static void lt9611_bridge_pre_enable(struct drm_bridge *bridge)
> --
> 2.27.0
>
>
[-- Attachment #1.2: Type: text/html, Size: 2562 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1] drm/bridge: lt9611: Fix handling of 4k panels
2020-11-23 10:46 ` Robert Foss
@ 2020-11-23 16:05 ` Vinod Koul
-1 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2020-11-23 16:05 UTC (permalink / raw)
To: Robert Foss
Cc: Alistair Delva, jernej.skrabec, jonas, airlied, narmstrong,
Anibal Limon, linux-kernel, dri-devel, Bjorn Andersson, a.hajda,
Laurent.pinchart, Peter Collingbourne
On 23-11-20, 11:46, Robert Foss wrote:
> 4k requires two dsi pipes, so don't report MODE_OK when only a
> single pipe is configured. But rather report MODE_PANEL to
> signal that requirements of the panel are not being met.
Acked-By: Vinod Koul <vkoul@kernel.org>
> Reported-by: Peter Collingbourne <pcc@google.com>
> Suggested-by: Peter Collingbourne <pcc@google.com>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index d734d9402c35..e8eb8deb444b 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -867,8 +867,14 @@ static enum drm_mode_status lt9611_bridge_mode_valid(struct drm_bridge *bridge,
> const struct drm_display_mode *mode)
> {
> struct lt9611_mode *lt9611_mode = lt9611_find_mode(mode);
> + struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
>
> - return lt9611_mode ? MODE_OK : MODE_BAD;
> + if (!lt9611_mode)
> + return MODE_BAD;
> + else if (lt9611_mode->intfs > 1 && !lt9611->dsi1)
> + return MODE_PANEL;
> + else
> + return MODE_OK;
> }
>
> static void lt9611_bridge_pre_enable(struct drm_bridge *bridge)
> --
> 2.27.0
--
~Vinod
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1] drm/bridge: lt9611: Fix handling of 4k panels
@ 2020-11-23 16:05 ` Vinod Koul
0 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2020-11-23 16:05 UTC (permalink / raw)
To: Robert Foss
Cc: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel, dri-devel, linux-kernel, John Stultz,
Peter Collingbourne, Alistair Delva, Anibal Limon,
Bjorn Andersson
On 23-11-20, 11:46, Robert Foss wrote:
> 4k requires two dsi pipes, so don't report MODE_OK when only a
> single pipe is configured. But rather report MODE_PANEL to
> signal that requirements of the panel are not being met.
Acked-By: Vinod Koul <vkoul@kernel.org>
> Reported-by: Peter Collingbourne <pcc@google.com>
> Suggested-by: Peter Collingbourne <pcc@google.com>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index d734d9402c35..e8eb8deb444b 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -867,8 +867,14 @@ static enum drm_mode_status lt9611_bridge_mode_valid(struct drm_bridge *bridge,
> const struct drm_display_mode *mode)
> {
> struct lt9611_mode *lt9611_mode = lt9611_find_mode(mode);
> + struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
>
> - return lt9611_mode ? MODE_OK : MODE_BAD;
> + if (!lt9611_mode)
> + return MODE_BAD;
> + else if (lt9611_mode->intfs > 1 && !lt9611->dsi1)
> + return MODE_PANEL;
> + else
> + return MODE_OK;
> }
>
> static void lt9611_bridge_pre_enable(struct drm_bridge *bridge)
> --
> 2.27.0
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] drm/bridge: lt9611: Fix handling of 4k panels
2020-11-23 10:46 ` Robert Foss
@ 2020-12-10 21:00 ` Peter Collingbourne
-1 siblings, 0 replies; 9+ messages in thread
From: Peter Collingbourne @ 2020-12-10 21:00 UTC (permalink / raw)
To: Robert Foss
Cc: Alistair Delva, jernej.skrabec, Vinod Koul, jonas, airlied,
Neil Armstrong, Anibal Limon, Linux Kernel Mailing List,
ML dri-devel, Bjorn Andersson, a.hajda, Laurent.pinchart
Thanks. Confirmed that this fixes display output for me on a 4K monitor.
On Mon, Nov 23, 2020 at 2:46 AM Robert Foss <robert.foss@linaro.org> wrote:
>
> 4k requires two dsi pipes, so don't report MODE_OK when only a
> single pipe is configured. But rather report MODE_PANEL to
> signal that requirements of the panel are not being met.
>
> Reported-by: Peter Collingbourne <pcc@google.com>
> Suggested-by: Peter Collingbourne <pcc@google.com>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
Tested-by: Peter Collingbourne <pcc@google.com>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index d734d9402c35..e8eb8deb444b 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -867,8 +867,14 @@ static enum drm_mode_status lt9611_bridge_mode_valid(struct drm_bridge *bridge,
> const struct drm_display_mode *mode)
> {
> struct lt9611_mode *lt9611_mode = lt9611_find_mode(mode);
> + struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
>
> - return lt9611_mode ? MODE_OK : MODE_BAD;
> + if (!lt9611_mode)
> + return MODE_BAD;
> + else if (lt9611_mode->intfs > 1 && !lt9611->dsi1)
> + return MODE_PANEL;
> + else
> + return MODE_OK;
> }
>
> static void lt9611_bridge_pre_enable(struct drm_bridge *bridge)
> --
> 2.27.0
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1] drm/bridge: lt9611: Fix handling of 4k panels
@ 2020-12-10 21:00 ` Peter Collingbourne
0 siblings, 0 replies; 9+ messages in thread
From: Peter Collingbourne @ 2020-12-10 21:00 UTC (permalink / raw)
To: Robert Foss
Cc: a.hajda, Neil Armstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, Daniel Vetter, ML dri-devel, Linux Kernel Mailing List,
John Stultz, Alistair Delva, Vinod Koul, Anibal Limon,
Bjorn Andersson
Thanks. Confirmed that this fixes display output for me on a 4K monitor.
On Mon, Nov 23, 2020 at 2:46 AM Robert Foss <robert.foss@linaro.org> wrote:
>
> 4k requires two dsi pipes, so don't report MODE_OK when only a
> single pipe is configured. But rather report MODE_PANEL to
> signal that requirements of the panel are not being met.
>
> Reported-by: Peter Collingbourne <pcc@google.com>
> Suggested-by: Peter Collingbourne <pcc@google.com>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
Tested-by: Peter Collingbourne <pcc@google.com>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index d734d9402c35..e8eb8deb444b 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -867,8 +867,14 @@ static enum drm_mode_status lt9611_bridge_mode_valid(struct drm_bridge *bridge,
> const struct drm_display_mode *mode)
> {
> struct lt9611_mode *lt9611_mode = lt9611_find_mode(mode);
> + struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
>
> - return lt9611_mode ? MODE_OK : MODE_BAD;
> + if (!lt9611_mode)
> + return MODE_BAD;
> + else if (lt9611_mode->intfs > 1 && !lt9611->dsi1)
> + return MODE_PANEL;
> + else
> + return MODE_OK;
> }
>
> static void lt9611_bridge_pre_enable(struct drm_bridge *bridge)
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] drm/bridge: lt9611: Fix handling of 4k panels
2020-11-23 10:46 ` Robert Foss
@ 2020-12-11 0:25 ` Bjorn Andersson
-1 siblings, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2020-12-11 0:25 UTC (permalink / raw)
To: Robert Foss
Cc: Alistair Delva, jernej.skrabec, Vinod Koul, jonas, airlied,
narmstrong, Anibal Limon, linux-kernel, dri-devel, a.hajda,
Laurent.pinchart, Peter Collingbourne
On Mon 23 Nov 04:46 CST 2020, Robert Foss wrote:
> 4k requires two dsi pipes, so don't report MODE_OK when only a
> single pipe is configured. But rather report MODE_PANEL to
> signal that requirements of the panel are not being met.
>
> Reported-by: Peter Collingbourne <pcc@google.com>
> Suggested-by: Peter Collingbourne <pcc@google.com>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
This looks very similar to what I had in the early revisions of the
driver.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index d734d9402c35..e8eb8deb444b 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -867,8 +867,14 @@ static enum drm_mode_status lt9611_bridge_mode_valid(struct drm_bridge *bridge,
> const struct drm_display_mode *mode)
> {
> struct lt9611_mode *lt9611_mode = lt9611_find_mode(mode);
> + struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
>
> - return lt9611_mode ? MODE_OK : MODE_BAD;
> + if (!lt9611_mode)
> + return MODE_BAD;
> + else if (lt9611_mode->intfs > 1 && !lt9611->dsi1)
> + return MODE_PANEL;
> + else
> + return MODE_OK;
> }
>
> static void lt9611_bridge_pre_enable(struct drm_bridge *bridge)
> --
> 2.27.0
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1] drm/bridge: lt9611: Fix handling of 4k panels
@ 2020-12-11 0:25 ` Bjorn Andersson
0 siblings, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2020-12-11 0:25 UTC (permalink / raw)
To: Robert Foss
Cc: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel, dri-devel, linux-kernel, John Stultz,
Peter Collingbourne, Alistair Delva, Vinod Koul, Anibal Limon
On Mon 23 Nov 04:46 CST 2020, Robert Foss wrote:
> 4k requires two dsi pipes, so don't report MODE_OK when only a
> single pipe is configured. But rather report MODE_PANEL to
> signal that requirements of the panel are not being met.
>
> Reported-by: Peter Collingbourne <pcc@google.com>
> Suggested-by: Peter Collingbourne <pcc@google.com>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
This looks very similar to what I had in the early revisions of the
driver.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index d734d9402c35..e8eb8deb444b 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -867,8 +867,14 @@ static enum drm_mode_status lt9611_bridge_mode_valid(struct drm_bridge *bridge,
> const struct drm_display_mode *mode)
> {
> struct lt9611_mode *lt9611_mode = lt9611_find_mode(mode);
> + struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
>
> - return lt9611_mode ? MODE_OK : MODE_BAD;
> + if (!lt9611_mode)
> + return MODE_BAD;
> + else if (lt9611_mode->intfs > 1 && !lt9611->dsi1)
> + return MODE_PANEL;
> + else
> + return MODE_OK;
> }
>
> static void lt9611_bridge_pre_enable(struct drm_bridge *bridge)
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread