From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Satya Tangirala <satyat@google.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-fscrypt@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 0/1] userspace support for F2FS metadata encryption
Date: Thu, 17 Dec 2020 08:23:18 -0800 [thread overview]
Message-ID: <X9uF9kNjWFq8KlL9@google.com> (raw)
In-Reply-To: <20201005074133.1958633-1-satyat@google.com>
Hi Satya,
Could you please consider to rebase the patches on f2fs-tools/dev branch?
I've applied compression support which will have some conflicts with this
series. And, could you check this works with multi-partition support?
Thanks,
On 10/05, Satya Tangirala wrote:
> The kernel patches for F2FS metadata encryption are at:
>
> https://lore.kernel.org/linux-fscrypt/20201005073606.1949772-4-satyat@google.com/
>
> This patch implements the userspace changes required for metadata
> encryption support as implemented in the kernel changes above. All blocks
> in the filesystem are encrypted with the user provided metadata encryption
> key except for the superblock (and its redundant copy). The DUN for a block
> is its offset from the start of the filesystem.
>
> This patch introduces two new options for the userspace tools: '-A' to
> specify the encryption algorithm, and '-M' to specify the encryption key.
> mkfs.f2fs will store the encryption algorithm used for metadata encryption
> in the superblock itself, so '-A' is only applicable to mkfs.f2fs. The rest
> of the tools only take the '-M' option, and will obtain the encryption
> algorithm from the superblock of the FS.
>
> Limitations:
> Metadata encryption with sparse storage has not been implemented yet in
> this patch.
>
> This patch requires the metadata encryption key to be readable from
> userspace, and does not ensure that it is zeroed before the program exits
> for any reason.
>
> Satya Tangirala (1):
> f2fs-tools: Introduce metadata encryption support
>
> fsck/main.c | 47 ++++++-
> fsck/mount.c | 33 ++++-
> include/f2fs_fs.h | 10 +-
> include/f2fs_metadata_crypt.h | 21 ++++
> lib/Makefile.am | 4 +-
> lib/f2fs_metadata_crypt.c | 226 ++++++++++++++++++++++++++++++++++
> lib/libf2fs_io.c | 87 +++++++++++--
> mkfs/f2fs_format.c | 5 +-
> mkfs/f2fs_format_main.c | 33 ++++-
> 9 files changed, 446 insertions(+), 20 deletions(-)
> create mode 100644 include/f2fs_metadata_crypt.h
> create mode 100644 lib/f2fs_metadata_crypt.c
>
> --
> 2.28.0.806.g8561365e88-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Satya Tangirala <satyat@google.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org
Subject: Re: [PATCH 0/1] userspace support for F2FS metadata encryption
Date: Thu, 17 Dec 2020 08:23:18 -0800 [thread overview]
Message-ID: <X9uF9kNjWFq8KlL9@google.com> (raw)
In-Reply-To: <20201005074133.1958633-1-satyat@google.com>
Hi Satya,
Could you please consider to rebase the patches on f2fs-tools/dev branch?
I've applied compression support which will have some conflicts with this
series. And, could you check this works with multi-partition support?
Thanks,
On 10/05, Satya Tangirala wrote:
> The kernel patches for F2FS metadata encryption are at:
>
> https://lore.kernel.org/linux-fscrypt/20201005073606.1949772-4-satyat@google.com/
>
> This patch implements the userspace changes required for metadata
> encryption support as implemented in the kernel changes above. All blocks
> in the filesystem are encrypted with the user provided metadata encryption
> key except for the superblock (and its redundant copy). The DUN for a block
> is its offset from the start of the filesystem.
>
> This patch introduces two new options for the userspace tools: '-A' to
> specify the encryption algorithm, and '-M' to specify the encryption key.
> mkfs.f2fs will store the encryption algorithm used for metadata encryption
> in the superblock itself, so '-A' is only applicable to mkfs.f2fs. The rest
> of the tools only take the '-M' option, and will obtain the encryption
> algorithm from the superblock of the FS.
>
> Limitations:
> Metadata encryption with sparse storage has not been implemented yet in
> this patch.
>
> This patch requires the metadata encryption key to be readable from
> userspace, and does not ensure that it is zeroed before the program exits
> for any reason.
>
> Satya Tangirala (1):
> f2fs-tools: Introduce metadata encryption support
>
> fsck/main.c | 47 ++++++-
> fsck/mount.c | 33 ++++-
> include/f2fs_fs.h | 10 +-
> include/f2fs_metadata_crypt.h | 21 ++++
> lib/Makefile.am | 4 +-
> lib/f2fs_metadata_crypt.c | 226 ++++++++++++++++++++++++++++++++++
> lib/libf2fs_io.c | 87 +++++++++++--
> mkfs/f2fs_format.c | 5 +-
> mkfs/f2fs_format_main.c | 33 ++++-
> 9 files changed, 446 insertions(+), 20 deletions(-)
> create mode 100644 include/f2fs_metadata_crypt.h
> create mode 100644 lib/f2fs_metadata_crypt.c
>
> --
> 2.28.0.806.g8561365e88-goog
next prev parent reply other threads:[~2020-12-17 16:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 7:41 [f2fs-dev] [PATCH 0/1] userspace support for F2FS metadata encryption Satya Tangirala via Linux-f2fs-devel
2020-10-05 7:41 ` Satya Tangirala
2020-10-05 7:41 ` [f2fs-dev] [PATCH 1/1] f2fs-tools: Introduce metadata encryption support Satya Tangirala via Linux-f2fs-devel
2020-10-05 7:41 ` Satya Tangirala
2020-10-07 19:42 ` [f2fs-dev] " jaegeuk
2020-10-07 19:42 ` jaegeuk
2020-12-17 16:04 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-12-17 16:04 ` Satya Tangirala
2020-10-07 21:52 ` [f2fs-dev] " Eric Biggers
2020-10-07 21:52 ` Eric Biggers
2020-10-07 21:39 ` [f2fs-dev] [PATCH 0/1] userspace support for F2FS metadata encryption Eric Biggers
2020-10-07 21:39 ` Eric Biggers
2020-12-17 16:23 ` Jaegeuk Kim [this message]
2020-12-17 16:23 ` Jaegeuk Kim
2020-12-18 6:41 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-12-18 6:41 ` Satya Tangirala
2020-12-18 16:19 ` [f2fs-dev] " Jaegeuk Kim
2020-12-18 16:19 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9uF9kNjWFq8KlL9@google.com \
--to=jaegeuk@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.