[virtio-comment] virtio-net : 5.1.6.2 descriptor-chains on transmitq

[virtio-comment] virtio-net : 5.1.6.2 descriptor-chains on transmitq

[Awais Masood]

Hi,

Seeking some clarity on:

 5.1.6.2
 Packet Transmission

 5. The header and packet are added as one output descriptor to the
transmitq, and the device is notified of the new entry

Does it imply no descriptor-chains for packets in transmitq? If
descriptor-chains are allowed on transmitq then why does it not state
'output buffer' instead of 'output descriptor'?

Regards,
Awais

This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Re: [virtio-comment] virtio-net : 5.1.6.2 descriptor-chains on transmitq

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

On Wed, Mar 09, 2022 at 06:00:08PM +0500, Awais Masood wrote:
> Hi,
> 
> Seeking some clarity on:
> 
>  5.1.6.2
>  Packet Transmission
> 
>  5. The header and packet are added as one output descriptor to the
> transmitq, and the device is notified of the new entry
> 
> Does it imply no descriptor-chains for packets in transmitq? If
> descriptor-chains are allowed on transmitq then why does it not state
> 'output buffer' instead of 'output descriptor'?

Good point, the spec is misleading.

TX buffers can be chains and/or use indirect descriptors. I think it
should read:

  The header and packet output descriptors are added as one buffer to
  the transmitq, and the device is notified of the new entry

There are no restrictions on descriptor framing, it would violate the
spec:

  2.6.4 Message Framing

  The framing of messages with descriptors is independent of the
  contents of the buffers. For example, a network transmit buffer
  consists of a 12 byte header followed by the network packet. This
  could be most simply placed in the descriptor table as a 12 byte
  output descriptor followed by a 1514 byte output descriptor, but it
  could also consist of a single 1526 byte output descriptor in the case
  where the header and packet are adjacent, or even three or more
  descriptors (possibly with loss of efficiency in that case). 

Would you like to send a patch to update the spec? The guidelines for
contributing spec changes are here:
https://github.com/oasis-tcs/virtio-spec/blob/master/CONTRIBUTING.md

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Fwd: [virtio-comment] virtio-net : 5.1.6.2 descriptor-chains on transmitq

[Gordon Stewart]

[-- Attachment #1.1: Type: text/plain, Size: 3106 bytes --]

Hi Stefan,

It took us a while to follow-up on this -- apologies.

Here's a patch:

From: Gordon Stewart <gordon@bedrocksystems.com>
Date: Mon, 27 Feb 2023 13:59:45 -0500
Subject: [PATCH] 5.1.6.2 Packet Transmission; clarify "output descriptor"

---
 device-types/net/description.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/device-types/net/description.tex b/device-types/net/description.tex
index 0500bb6..98f0f20 100644
--- a/device-types/net/description.tex
+++ b/device-types/net/description.tex
@@ -487,8 +487,8 @@ \subsubsection{Packet
Transmission}\label{sec:Device Types / Network Device / De

 \item \field{num_buffers} is set to zero.  This field is unused on
transmitted packets.

-\item The header and packet are added as one output descriptor to the
-  transmitq, and the device is notified of the new entry
+\item The header and packet output descriptors are added as one buffer to
+  the transmitq, and the device is notified of the new entry
   (see \ref{sec:Device Types / Network Device / Device
Initialization}~\nameref{sec:Device Types / Network Device / Device
Initialization}).
 \end{enumerate}

- Gordon

---------- Forwarded message ---------
From: Stefan Hajnoczi <stefanha@redhat.com>
Date: Wed, Mar 9, 2022 at 7:53 PM
Subject: Re: [virtio-comment] virtio-net : 5.1.6.2 descriptor-chains
on transmitq
To: Awais Masood <awais@bedrocksystems.com>
Cc: <virtio-comment@lists.oasis-open.org>


On Wed, Mar 09, 2022 at 06:00:08PM +0500, Awais Masood wrote:
> Hi,
>
> Seeking some clarity on:
>
>  5.1.6.2
>  Packet Transmission
>
>  5. The header and packet are added as one output descriptor to the
> transmitq, and the device is notified of the new entry
>
> Does it imply no descriptor-chains for packets in transmitq? If
> descriptor-chains are allowed on transmitq then why does it not state
> 'output buffer' instead of 'output descriptor'?

Good point, the spec is misleading.

TX buffers can be chains and/or use indirect descriptors. I think it
should read:

  The header and packet output descriptors are added as one buffer to
  the transmitq, and the device is notified of the new entry

There are no restrictions on descriptor framing, it would violate the
spec:

  2.6.4 Message Framing

  The framing of messages with descriptors is independent of the
  contents of the buffers. For example, a network transmit buffer
  consists of a 12 byte header followed by the network packet. This
  could be most simply placed in the descriptor table as a 12 byte
  output descriptor followed by a 1514 byte output descriptor, but it
  could also consist of a single 1526 byte output descriptor in the case
  where the header and packet are adjacent, or even three or more
  descriptors (possibly with loss of efficiency in that case).

Would you like to send a patch to update the spec? The guidelines for
contributing spec changes are here:
https://github.com/oasis-tcs/virtio-spec/blob/master/CONTRIBUTING.md

Stefan


-- 
Gordon Stewart
gordon@bedrocksystems.com

BedRock

Systems Inc
*UNBREAKABLE FOUNDATION* *FOR *
*FORMALLY SECURED COMPUTING*

[-- Attachment #1.2: Type: text/html, Size: 5277 bytes --]

[-- Attachment #2: signature.asc --]
[-- Type: text/plain, Size: 499 bytes --]

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmIov00ACgkQnKSrs4Gr
c8g6zAgAkVXHm5nRY3LM68mY3duLF+cURuGHt2KRwjKiNw3dEVEomS0DaN4NL0U1
6Z7o80vfkfmHU0i492vcTxhtj3Q05dC4eOX8Ku2QaGPKYs3XUfE/2FnWrIfqa1ic
Q9b93wl3VZKK7yIvbu4sBsxZ3jc1XgJ5FtPOgv27oTdcOZbmO3myD8CTK3euCCtF
eXcNisHsVrI0okPtR/Qqr+Dki8M3tSMkVBDoDxZxrj8M3Pq5ApSGz+O7jhEYi96W
URlrysseWaHK/5Sju5ztO4wUF4EFkQY3o6a5ZqQESjRUQ3EmBzbJVZSAor8R1psZ
jW+wX34W78Drppjd3Dx13JAu5bTg1Q==
=pDji
-----END PGP SIGNATURE-----

[-- Attachment #3: Type: text/plain, Size: 744 bytes --]


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Re: Fwd: [virtio-comment] virtio-net : 5.1.6.2 descriptor-chains on transmitq

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

On Mon, Feb 27, 2023 at 03:27:25PM -0500, Gordon Stewart wrote:
> Hi Stefan,
> 
> It took us a while to follow-up on this -- apologies.
> 
> Here's a patch:
> 
> From: Gordon Stewart <gordon@bedrocksystems.com>
> Date: Mon, 27 Feb 2023 13:59:45 -0500
> Subject: [PATCH] 5.1.6.2 Packet Transmission; clarify "output descriptor"
> 
> ---
>  device-types/net/description.tex | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

The next step is creating a GitHub Issue, please see
https://github.com/oasis-tcs/virtio-spec/#use-of-github-issues.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Fwd: [virtio-comment] virtio-net : 5.1.6.2 descriptor-chains on transmitq

[Gordon Stewart]

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

Thanks. Here's the issue:

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/165.

I request a vote by TC members that this fix be included in the next
version of the standard.

On Mon, Feb 27, 2023 at 4:01 PM Stefan Hajnoczi <stefanha@redhat.com> wrote:

> On Mon, Feb 27, 2023 at 03:27:25PM -0500, Gordon Stewart wrote:
> > Hi Stefan,
> >
> > It took us a while to follow-up on this -- apologies.
> >
> > Here's a patch:
> >
> > From: Gordon Stewart <gordon@bedrocksystems.com>
> > Date: Mon, 27 Feb 2023 13:59:45 -0500
> > Subject: [PATCH] 5.1.6.2 Packet Transmission; clarify "output descriptor"
> >
> > ---
> >  device-types/net/description.tex | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> The next step is creating a GitHub Issue, please see
> https://github.com/oasis-tcs/virtio-spec/#use-of-github-issues.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>


-- 
Gordon Stewart
gordon@bedrocksystems.com

BedRock

Systems Inc
*UNBREAKABLE FOUNDATION* *FOR *
*FORMALLY SECURED COMPUTING*

[-- Attachment #2: Type: text/html, Size: 3026 bytes --]