From: Heiko Carstens <hca@linux.ibm.com>
To: Yu Zhe <yuzhe@nfschina.com>
Cc: freude@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
borntraeger@linux.ibm.com, svens@linux.ibm.com,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, liqiong@nfschina.com
Subject: Re: [PATCH] s390/zcrypt: remove unnecessary (void*) conversions
Date: Tue, 28 Feb 2023 19:05:58 +0100 [thread overview]
Message-ID: <Y/5Chi/JhrSoI65x@osiris> (raw)
In-Reply-To: <20230223011212.13045-1-yuzhe@nfschina.com>
On Thu, Feb 23, 2023 at 09:12:12AM +0800, Yu Zhe wrote:
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> ---
> drivers/s390/crypto/zcrypt_msgtype6.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/s390/crypto/zcrypt_msgtype6.c b/drivers/s390/crypto/zcrypt_msgtype6.c
> index 5ad251477593..09b714c6adc3 100644
> --- a/drivers/s390/crypto/zcrypt_msgtype6.c
> +++ b/drivers/s390/crypto/zcrypt_msgtype6.c
> @@ -926,8 +926,7 @@ static void zcrypt_msgtype6_receive(struct ap_queue *aq,
> .type = TYPE82_RSP_CODE,
> .reply_code = REP82_ERROR_MACHINE_FAILURE,
> };
> - struct response_type *resp_type =
> - (struct response_type *)msg->private;
> + struct response_type *resp_type = msg->private;
> struct type86x_reply *t86r;
> int len;
There are many more of this. Please convert all of them, or none.
next prev parent reply other threads:[~2023-02-28 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 1:12 [PATCH] s390/zcrypt: remove unnecessary (void*) conversions Yu Zhe
2023-02-28 18:05 ` Heiko Carstens [this message]
2023-03-03 1:32 ` [PATCH v2] " Yu Zhe
2023-03-03 4:23 ` Dan Carpenter
2023-03-03 5:21 ` [PATCH v3] " Yu Zhe
2023-03-03 11:02 ` Muhammad Usama Anjum
2023-03-03 12:16 ` Dan Carpenter
2023-03-03 13:10 ` Harald Freudenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/5Chi/JhrSoI65x@osiris \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=svens@linux.ibm.com \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.