From: Dan Carpenter <error27@gmail.com>
To: Yu Zhe <yuzhe@nfschina.com>
Cc: freude@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
liqiong@nfschina.com
Subject: Re: [PATCH v2] s390/zcrypt: remove unnecessary (void*) conversions
Date: Fri, 3 Mar 2023 07:23:52 +0300 [thread overview]
Message-ID: <ZAF2WA5pDQYFjwtm@kadam> (raw)
In-Reply-To: <20230303013250.3058-1-yuzhe@nfschina.com>
On Fri, Mar 03, 2023 at 09:32:50AM +0800, Yu Zhe wrote:
> @@ -1157,7 +1155,7 @@ static long zcrypt_msgtype6_send_cprb(bool userspace, struct zcrypt_queue *zq,
> struct ap_message *ap_msg)
> {
> int rc;
> - struct response_type *rtype = (struct response_type *)(ap_msg->private);
> + struct response_type *rtype = (ap_msg->private);
If you're going to do this the get rid of the parentheses as well:
struct response_type *rtype = ap_msg->private;
Same in other places.
regards,
dan carpenter
next prev parent reply other threads:[~2023-03-03 4:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 1:12 [PATCH] s390/zcrypt: remove unnecessary (void*) conversions Yu Zhe
2023-02-28 18:05 ` Heiko Carstens
2023-03-03 1:32 ` [PATCH v2] " Yu Zhe
2023-03-03 4:23 ` Dan Carpenter [this message]
2023-03-03 5:21 ` [PATCH v3] " Yu Zhe
2023-03-03 11:02 ` Muhammad Usama Anjum
2023-03-03 12:16 ` Dan Carpenter
2023-03-03 13:10 ` Harald Freudenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAF2WA5pDQYFjwtm@kadam \
--to=error27@gmail.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=svens@linux.ibm.com \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.